Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration UI kit to tailwindcss #8222

Closed
33 tasks done
shashkovdanil opened this issue Nov 23, 2023 · 5 comments · Fixed by #8412, #8473, #8502, #8509 or #8514
Closed
33 tasks done

Migration UI kit to tailwindcss #8222

shashkovdanil opened this issue Nov 23, 2023 · 5 comments · Fixed by #8412, #8473, #8502, #8509 or #8514
Assignees
Labels
chief enhancement New feature or request

Comments

@shashkovdanil
Copy link
Contributor

shashkovdanil commented Nov 23, 2023

Is your feature request related to a problem?

We migrated NeoButton component to tailwindcss. Next step is migration of other components from libs/ui

Describe the solution you would like

List of components:

Since these components are used in many places, you should not rewrite them all in one PR, better 1 component 1 task. This task is something like Epic Task

Describe alternatives you have considered

--

Screenshots

No response

Are there opened related issues?

@exezbcz
Copy link
Member

exezbcz commented Nov 23, 2023

I will make library in the handoff file with all the button components till end of week

@exezbcz
Copy link
Member

exezbcz commented Nov 25, 2023

Update

components done, in the figma

there are also some changes

  • regular button now has a height of 40px instead of 36. Will work better as a touchpoint

The large button is on the other hand smaller - 52px instead of 56

both light and dark mode

image

@roiLeo
Copy link
Contributor

roiLeo commented Dec 1, 2023

@import 'bulma/bulma.sass';

@shashkovdanil
Copy link
Contributor Author

@roiLeo reopen this task please and assign on me

@shashkovdanil
Copy link
Contributor Author

shashkovdanil commented Dec 12, 2023

@roiLeo All components are rewritten, waiting for review and merge in main, then I will remove bulma and other global styles

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment