Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NeoNotification to tailwindcss #8517

Merged
merged 2 commits into from
Dec 13, 2023

Conversation

shashkovdanil
Copy link
Contributor

@shashkovdanil shashkovdanil commented Dec 10, 2023

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality

Optional

  • I've tested it at </ksm/collection>
  • I've tested PR on mobile
  • I've written unit tests 🧪
  • I've found edge cases

Did your issue had any of the "$" label on it?

  • Fill up your DOT address: Payout

Community participation

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

Copilot Summary

🤖[deprecated] Generated by Copilot at f9c20d1

Refactored NeoNotification component to use Tailwind CSS instead of theme scss. This enhances the UI design system.

🤖[deprecated] Generated by Copilot at f9c20d1

We're sailing on the web with a mighty fine design
We've ditched the theme scss and we're using Tailwind
So heave away, me hearties, and refactor as you go
We'll make the NeoNotification component shine and glow

@shashkovdanil shashkovdanil requested a review from a team as a code owner December 10, 2023 15:04
@shashkovdanil shashkovdanil requested review from vikiival and removed request for a team December 10, 2023 15:04
Copy link

netlify bot commented Dec 10, 2023

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 08211e0
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/65795e38bb0ea30008cad658
😎 Deploy Preview https://deploy-preview-8517--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@kodabot
Copy link
Collaborator

kodabot commented Dec 10, 2023

WARNING @shashkovdanil PR for issue #8222 which isn't assigned to you. Please be warned that this PR may get rejected if there's another assignee for issue #8222

@reviewpad reviewpad bot added small Pull request is small waiting-for-review labels Dec 10, 2023
Copy link

codeclimate bot commented Dec 10, 2023

Code Climate has analyzed commit f9c20d1 and detected 0 issues on this pull request.

View more on Code Climate.

Copy link
Contributor

reviewpad bot commented Dec 10, 2023

AI-Generated Summary: This pull request transforms the NeoNotification component styling from SCSS to utility-first CSS with Tailwind. It also removes redundant imports and refactors class attributes to use '@apply' directive of Tailwind CSS. This simplifies codebase and enhances maintainability adhering to Tailwind's utility-first style for achieving more efficient future customization.

@shashkovdanil shashkovdanil mentioned this pull request Dec 10, 2023
33 tasks
@prury prury requested a review from daiagi December 12, 2023 18:22
@roiLeo roiLeo added this pull request to the merge queue Dec 13, 2023
Merged via the queue into kodadot:main with commit ee58f47 Dec 13, 2023
11 of 14 checks passed
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
small Pull request is small waiting-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migration UI kit to tailwindcss
4 participants