-
-
Notifications
You must be signed in to change notification settings - Fork 364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrated NeoSelect to tailwindcss #8502
Conversation
WARNING @shashkovdanil PR for issue #8222 which isn't assigned to you. Please be warned that this PR may get rejected if there's another assignee for issue #8222 |
✅ Deploy Preview for koda-canary ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
AI-Generated Summary: This pull request migrates the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's try to use select class props when we can (o-sel
=> selectClass
)
lgtm for now
.neo-select.o-ctrl-sel { | ||
display: inline-block; | ||
max-width: 100%; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
already doable with expanded
prop
Could you share some code example, please? I don't know Oruga well yet |
see for example |
Code Climate has analyzed commit 37e6349 and detected 0 issues on this pull request. View more on Code Climate. |
Quality Gate passedKudos, no new issues were introduced! 0 New issues |
thanks! |
😍 Perfect, I’ve sent the payout 🪅 Let’s grab another issue and get rewarded! |
Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.
👇 __ Let's make a quick check before the contribution.
PR Type
Context
tailwindcss
#8222Before submitting pull request, please make sure:
Optional
Did your issue had any of the "$" label on it?
Community participation
Screenshot 📸
Copilot Summary
🤖[deprecated] Generated by Copilot at b64b6d2
Refactored NeoSelect component style with Tailwind CSS and oruga-ui theme. Simplified SCSS code and removed unused import in
NeoSelect.scss
.🤖[deprecated] Generated by Copilot at b64b6d2