Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrated NeoSelect to tailwindcss #8502

Merged
merged 3 commits into from
Dec 18, 2023

Conversation

shashkovdanil
Copy link
Contributor

@shashkovdanil shashkovdanil commented Dec 9, 2023

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality

Optional

  • I've tested it at </ksm/collection>
  • I've tested PR on mobile
  • I've written unit tests 🧪
  • I've found edge cases

Did your issue had any of the "$" label on it?

  • Fill up your DOT address: Payout

Community participation

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

Copilot Summary

🤖[deprecated] Generated by Copilot at b64b6d2

Refactored NeoSelect component style with Tailwind CSS and oruga-ui theme. Simplified SCSS code and removed unused import in NeoSelect.scss.

🤖[deprecated] Generated by Copilot at b64b6d2

Sing, O Muse, of the skillful coder who refined
The NeoSelect component, a marvel of design,
And with the @apply directive and theme function wrought
A splendid style with Tailwind CSS and oruga-ui, as he thought.

@shashkovdanil shashkovdanil requested a review from a team as a code owner December 9, 2023 16:36
@shashkovdanil shashkovdanil requested review from vikiival and removed request for a team December 9, 2023 16:36
@kodabot
Copy link
Collaborator

kodabot commented Dec 9, 2023

WARNING @shashkovdanil PR for issue #8222 which isn't assigned to you. Please be warned that this PR may get rejected if there's another assignee for issue #8222

Copy link

netlify bot commented Dec 9, 2023

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 37e6349
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/6580274e3eaa7e00087afd06
😎 Deploy Preview https://deploy-preview-8502--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@reviewpad reviewpad bot added small Pull request is small waiting-for-review labels Dec 9, 2023
Copy link
Contributor

reviewpad bot commented Dec 9, 2023

AI-Generated Summary: This pull request migrates the NeoSelect component to tailwindcss. It replaces the traditional CSS properties with corresponding tailwindcss utility classes in NeoSelect.scss. Notably, the definitions of the .neo-select.o-ctrl-sel and .o-sel were refactored to use the @apply directive with appropriate tailwind classes. This change simplifies the codebase and adheres to the tailwindcss methodology for styling components.

@shashkovdanil shashkovdanil mentioned this pull request Dec 10, 2023
33 tasks
Copy link
Contributor

@roiLeo roiLeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's try to use select class props when we can (o-sel => selectClass)

lgtm for now

.neo-select.o-ctrl-sel {
display: inline-block;
max-width: 100%;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

already doable with expanded prop

@shashkovdanil
Copy link
Contributor Author

let's try to use select class props when we can (o-sel => selectClass)

lgtm for now

Could you share some code example, please? I don't know Oruga well yet

@roiLeo
Copy link
Contributor

roiLeo commented Dec 11, 2023

Could you share some code example, please? I don't know Oruga well yet

see for example NeoTooltip or NeoSkeleton, you can define some wrapper class of component

@prury prury requested review from Jarsen136 and removed request for vikiival December 12, 2023 18:36
@prury prury added the S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked label Dec 13, 2023
@roiLeo roiLeo requested a review from daiagi December 14, 2023 16:46
Copy link

codeclimate bot commented Dec 18, 2023

Code Climate has analyzed commit 37e6349 and detected 0 issues on this pull request.

View more on Code Climate.

Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@yangwao
Copy link
Member

yangwao commented Dec 18, 2023

thanks!
pay 20 usd

@yangwao yangwao merged commit 37ecbe8 into kodadot:main Dec 18, 2023
16 checks passed
@yangwao
Copy link
Member

yangwao commented Dec 18, 2023

😍 Perfect, I’ve sent the payout
💵 $20 @ 6.5 USD/DOT ~ 3.077 $DOT
🧗 16SpvdDgKNiQ3c53DxX7refnQcKUD3uRNim3Z1HBJLNGrtSP
🔗 0x9cfe44f58e51cfe72b795f2a69ad9f83ddf1b4908420e98956fe1d3a90f2c480

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Dec 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
paid pull-request has been paid S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked small Pull request is small waiting-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migration UI kit to tailwindcss
5 participants