Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NeoSlider to tailwindcss #8520

Merged
merged 1 commit into from
Dec 14, 2023
Merged

NeoSlider to tailwindcss #8520

merged 1 commit into from
Dec 14, 2023

Conversation

shashkovdanil
Copy link
Contributor

@shashkovdanil shashkovdanil commented Dec 10, 2023 •
edited by ghost
Loading

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality

Optional

  • I've tested it at </ksm/collection>
  • I've tested PR on mobile
  • I've written unit tests 🧪
  • I've found edge cases

Did your issue had any of the "$" label on it?

  • Fill up your DOT address: Payout

Community participation

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

Copilot Summary

🤖[deprecated] Generated by Copilot at 459021b

Refactored NeoSlider component to use Tailwind CSS instead of scss.

🤖[deprecated] Generated by Copilot at 459021b

No more scss, we don't need it
We use Tailwind to color our fate
Slider fill, a class of power
We refactor and we dominate

@shashkovdanil shashkovdanil requested a review from a team as a code owner December 10, 2023 15:31
@shashkovdanil shashkovdanil requested review from yangwao and removed request for a team December 10, 2023 15:31
@kodabot
Copy link
Collaborator

kodabot commented Dec 10, 2023

WARNING @shashkovdanil PR for issue #8222 which isn't assigned to you. Please be warned that this PR may get rejected if there's another assignee for issue #8222

@netlify Netlify
Copy link

netlify bot commented Dec 10, 2023 •
edited
Loading

✅ Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 459021b
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/6575d9ca94e2410008a0f61b
😎 Deploy Preview https://deploy-preview-8520--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@reviewpad Reviewpad
Copy link
Contributor

reviewpad bot commented Dec 10, 2023

AI-Generated Summary: This pull request includes changes to the NeoSlider component. The author has migrated the styling from previous SCSS based implementation to using the Tailwind CSS utility. The local theme import has been removed, and the previous SCSS specific directive @include ktheme has been replaced with the Tailwind CSS directive @apply bg-k-primary. This suggests a move towards increasing the usage of the utility-first CSS framework, Tailwind CSS, in the project.

@reviewpad reviewpad bot added small Pull request is small waiting-for-review labels Dec 10, 2023
@sonarqubecloud SonarQubeCloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codeclimate CodeClimate
Copy link

codeclimate bot commented Dec 10, 2023

Code Climate has analyzed commit 459021b and detected 0 issues on this pull request.

View more on Code Climate.

@shashkovdanil shashkovdanil mentioned this pull request Dec 10, 2023
Closed
33 tasks
roiLeo
roiLeo approved these changes Dec 10, 2023
View reviewed changes
Copy link
Contributor

@roiLeo roiLeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol we don't even use this one any more

@roiLeo roiLeo added S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked and removed waiting-for-review labels Dec 10, 2023
@roiLeo roiLeo enabled auto-merge December 10, 2023 18:36
@roiLeo roiLeo requested review from daiagi and removed request for yangwao December 13, 2023 07:44
@roiLeo roiLeo added this pull request to the merge queue Dec 14, 2023
Merged via the queue into kodadot:main with commit 68c22ac Dec 14, 2023
18 checks passed
This was referenced Dec 14, 2023
Merged
Merged
Merged
Merged
Merged
Merged
@yangwao yangwao mentioned this pull request Dec 16, 2023
Closed
This was referenced Dec 16, 2023
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daiagi daiagi daiagi approved these changes

@roiLeo roiLeo roiLeo approved these changes

Assignees
No one assigned
Labels
S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked small Pull request is small
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migration UI kit to tailwindcss
4 participants
@shashkovdanil @kodabot @roiLeo @daiagi