Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release update #8628

Merged
merged 4 commits into from
Dec 16, 2023
Merged

release update #8628

merged 4 commits into from
Dec 16, 2023

Conversation

@yangwao yangwao marked this pull request as ready for review December 16, 2023 15:02
@yangwao yangwao requested a review from a team as a code owner December 16, 2023 15:02
@yangwao yangwao requested review from roiLeo and Jarsen136 and removed request for a team December 16, 2023 15:02
@yangwao yangwao merged commit 370a47a into production Dec 16, 2023
8 of 9 checks passed
Copy link
Contributor

reviewpad bot commented Dec 16, 2023

AI-Generated Summary: This pull request resolves an issue where a modal in the collection drop was getting stuck. The fix involves changes in 'AddFundsModal.vue', 'AutoTeleportActionButton.vue', and 'useAutoTeleportTransitionDetails.ts'. It improves the conditional logic used inside computed properties by checking if 'autoteleport' is ready and updates the computation of 'showAddFunds'. Additionally, it includes fetching balances as part of the 'fetched' reference in the 'useAutoTeleportTransitionDetails.ts' file. The patch ensures that balances are fetched at the right times, which should result in less modal stalling.

@reviewpad reviewpad bot added large Pull request is large waiting-for-review labels Dec 16, 2023
Copy link
Contributor

reviewpad bot commented Dec 16, 2023

Reviewpad Report

⚠️ Warnings

  • Please link an issue to the pull request

Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

netlify bot commented Dec 16, 2023

Deploy Preview for koda-beta ready!

Name Link
🔨 Latest commit f9bc63a
🔍 Latest deploy log https://app.netlify.com/sites/koda-beta/deploys/657dbc108779840008b9bb8a
😎 Deploy Preview https://deploy-preview-8628--koda-beta.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants