Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NeoStickyModal to tailwindcss #8540

Merged
merged 4 commits into from
Dec 14, 2023

Conversation

shashkovdanil
Copy link
Contributor

@shashkovdanil shashkovdanil commented Dec 12, 2023

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality

Optional

  • I've tested it at </ksm/collection>
  • I've tested PR on mobile
  • I've written unit tests 🧪
  • I've found edge cases

Did your issue had any of the "$" label on it?

  • Fill up your DOT address: Payout

Community participation

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

Copilot Summary

🤖[deprecated] Generated by Copilot at 7d24412

Refactored the NeoStickyModal component to use Tailwind CSS and the useWindowSize hook. Simplified the SCSS file and updated the Tailwind CSS config file with custom padding values.

🤖[deprecated] Generated by Copilot at 7d24412

NeoStickyModal
Simplified with Tailwind
No more Bulma, ah!

@shashkovdanil shashkovdanil requested a review from a team as a code owner December 12, 2023 19:50
@shashkovdanil shashkovdanil requested review from yangwao and removed request for a team December 12, 2023 19:50
@kodabot
Copy link
Collaborator

kodabot commented Dec 12, 2023

WARNING @shashkovdanil PR for issue #8222 which isn't assigned to you. Please be warned that this PR may get rejected if there's another assignee for issue #8222

Copy link

netlify bot commented Dec 12, 2023

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit d997c1b
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/657b3112db72bb0008457003
😎 Deploy Preview https://deploy-preview-8540--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@shashkovdanil shashkovdanil mentioned this pull request Dec 12, 2023
33 tasks
Copy link
Contributor

reviewpad bot commented Dec 12, 2023

AI-Generated Summary: This pull request introduces several changes to the NeoStickyModal component, including refactoring this component from SCSS to Tailwind CSS. There are substantial reductions in code lines in NeoStickyModal.scss file and NeoStickyModal.vue file. Additionally, there are also modifications in tailwind.config.js file. The changes promote cleaner and more maintainable code structure. The use of Tailwind CSS utility classes helps to achieve the same visual design for the component while simplifying the codebase. It should be noted that an initially existing feature, mobile responsiveness, has been preserved in the refactoring process and a feature to use window size from @vueuse/core has also been added.

@reviewpad reviewpad bot added small Pull request is small waiting-for-review labels Dec 12, 2023
@prury prury requested review from roiLeo and daiagi and removed request for yangwao December 12, 2023 22:04
@daiagi
Copy link
Contributor

daiagi commented Dec 13, 2023

almost identical

image

it is 10px short compare to canary

@shashkovdanil
Copy link
Contributor Author

almost identical

image

it is 10px short compare to canary

It will be fixed after removing bulma

Copy link
Contributor

@daiagi daiagi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will be fixed after removing bulma

how come? please explain

@shashkovdanil
Copy link
Contributor Author

It will be fixed after removing bulma

how come? please explain

Bulma has helpers for padding and these helpers with !important

@prury
Copy link
Member

prury commented Dec 14, 2023

apart from what daiagi pointed looks good

@prury prury added the S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked label Dec 14, 2023
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

codeclimate bot commented Dec 14, 2023

Code Climate has analyzed commit d997c1b and detected 0 issues on this pull request.

View more on Code Climate.

@roiLeo roiLeo added this pull request to the merge queue Dec 14, 2023
Merged via the queue into kodadot:main with commit 7a2d28e Dec 14, 2023
15 of 16 checks passed
This was referenced Dec 15, 2023
This was referenced Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked small Pull request is small waiting-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migration UI kit to tailwindcss
5 participants