Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NeoTabs to tailwindcss #8523

Merged
merged 2 commits into from
Dec 11, 2023
Merged

Conversation

shashkovdanil
Copy link
Contributor

@shashkovdanil shashkovdanil commented Dec 10, 2023

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality

Optional

  • I've tested it at </ksm/collection>
  • I've tested PR on mobile
  • I've written unit tests 🧪
  • I've found edge cases

Did your issue had any of the "$" label on it?

  • Fill up your DOT address: Payout

Community participation

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

Copilot Summary

🤖[deprecated] Generated by Copilot at 185b983

Refactored the NeoTabs component and updated the text color variable to use the new opacity syntax in Tailwind CSS. This improves the code readability and consistency of the UI library.

🤖[deprecated] Generated by Copilot at 185b983

We wanted to make our text fade
So we changed how the text-color was made
We used RGB values
And Tailwind CSS classes
And refactored the NeoTabs with a blade

@shashkovdanil shashkovdanil requested a review from a team as a code owner December 10, 2023 15:59
@shashkovdanil shashkovdanil requested review from yangwao and removed request for a team December 10, 2023 15:59
@kodabot
Copy link
Collaborator

kodabot commented Dec 10, 2023

WARNING @shashkovdanil PR for issue #8222 which isn't assigned to you. Please be warned that this PR may get rejected if there's another assignee for issue #8222

Copy link

netlify bot commented Dec 10, 2023

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 4913904
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/65771a4a380e53000815e381
😎 Deploy Preview https://deploy-preview-8523--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

reviewpad bot commented Dec 10, 2023

AI-Generated Summary: This pull request involves a major refactoring of the NeoTabs component's styling approach, transitioning from a traditional SCSS setup to a TailwindCSS utility-based one. The patch alters three files in total, with a major focus on NeoTabs.scss. In the latter, each individual style declaration has been shifted from a traditional SCSS property-value pair syntax to a corresponding TailwindCSS @apply directive. This includes changes in color, margin, border, padding, and other layout related properties. Additionally, the import statement at the top of NeoTabs.scss file has been modified to remove unnecessary dependencies. In the tailwind.scss and tailwind.config.js files, the color values were changed from variable-based colors to an rgb format. Overall, this change simplifies the source code while maintaining its previous appearance and functionality.

@reviewpad reviewpad bot added small Pull request is small waiting-for-review labels Dec 10, 2023
Copy link

codeclimate bot commented Dec 10, 2023

Code Climate has analyzed commit 185b983 and detected 0 issues on this pull request.

View more on Code Climate.

@shashkovdanil shashkovdanil mentioned this pull request Dec 10, 2023
33 tasks
@roiLeo roiLeo added the S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved label Dec 10, 2023
@prury prury requested a review from Jarsen136 December 11, 2023 13:27
@roiLeo roiLeo added this pull request to the merge queue Dec 11, 2023
Merged via the queue into kodadot:main with commit 089cca6 Dec 11, 2023
12 of 15 checks passed
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved small Pull request is small waiting-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migration UI kit to tailwindcss
4 participants