Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NeoTooltip to tailwindcss #8521

Merged
merged 2 commits into from
Dec 11, 2023
Merged

Conversation

shashkovdanil
Copy link
Contributor

@shashkovdanil shashkovdanil commented Dec 10, 2023

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality

Optional

  • I've tested it at </ksm/collection>
  • I've tested PR on mobile
  • I've written unit tests 🧪
  • I've found edge cases

Did your issue had any of the "$" label on it?

  • Fill up your DOT address: Payout

Community participation

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

Copilot Summary

🤖[deprecated] Generated by Copilot at 58e87f4

Refactored NeoTooltip component to use TailwindCSS instead of custom CSS. This improved the component's performance, style consistency, and code readability.

🤖[deprecated] Generated by Copilot at 58e87f4

Sing, O Muse, of the skillful coder who refined
The NeoTooltip component with a nimble mind.
He cast away the needless import and the CSS vars
And clothed the element in TailwindCSS like a star.

@shashkovdanil shashkovdanil requested a review from a team as a code owner December 10, 2023 15:45
@shashkovdanil shashkovdanil requested review from vikiival and removed request for a team December 10, 2023 15:45
@kodabot
Copy link
Collaborator

kodabot commented Dec 10, 2023

WARNING @shashkovdanil PR for issue #8222 which isn't assigned to you. Please be warned that this PR may get rejected if there's another assignee for issue #8222

Copy link

netlify bot commented Dec 10, 2023

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 742ad66
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/6577342c1c4e5b0008d9e40c
😎 Deploy Preview https://deploy-preview-8521--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

reviewpad bot commented Dec 10, 2023

AI-Generated Summary: This pull request includes changes aimed to convert the styles of the NeoTooltip component in the UI library from a traditional Sass approach to utilizing Tailwind CSS utility classes. The changes mainly touch two files: NeoTooltip.scss and NeoTooltip.vue.

In NeoTooltip.scss, numerous styles and imports have been removed, particularly those related to theming. The overall addon of complex CSS properties has been replaced with the simplified, utility-based @apply directive from Tailwind CSS. This modification brings a more concise and maintainable approach to style definitions.

The changes in NeoTooltip.vue are minimal, updating class names to reflect the Tailwind CSS style.

Overall, this pull request results in significantly less code, hinting at an increase in readability and maintainability of the code.

@reviewpad reviewpad bot added the small Pull request is small label Dec 10, 2023
@shashkovdanil
Copy link
Contributor Author

@prury help me to test tooltips please

Copy link
Contributor

@roiLeo roiLeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use Tooltip sass variable or class Props when we can

@prury prury requested a review from Jarsen136 December 11, 2023 14:29
@prury
Copy link
Member

prury commented Dec 11, 2023

@prury help me to test tooltips please

so many, but it seems that they all work properly

@prury prury added the S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked label Dec 11, 2023
@roiLeo roiLeo enabled auto-merge December 11, 2023 16:09
@roiLeo roiLeo added this pull request to the merge queue Dec 11, 2023
Merged via the queue into kodadot:main with commit 79b4398 Dec 11, 2023
13 of 14 checks passed
Copy link

codeclimate bot commented Dec 11, 2023

Code Climate has analyzed commit 742ad66 and detected 0 issues on this pull request.

View more on Code Climate.

Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

This was referenced Dec 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked small Pull request is small waiting-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migration UI kit to tailwindcss
5 participants