Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NeoRadio to tailwindcss #8543

Merged
merged 2 commits into from
Dec 13, 2023
Merged

Conversation

shashkovdanil
Copy link
Contributor

@shashkovdanil shashkovdanil commented Dec 12, 2023

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality

Optional

  • I've tested it at </ksm/collection>
  • I've tested PR on mobile
  • I've written unit tests 🧪
  • I've found edge cases

Did your issue had any of the "$" label on it?

  • Fill up your DOT address: Payout

Community participation

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

Copilot Summary

🤖[deprecated] Generated by Copilot at e100c60

Refactored the NeoRadioButton component to use Tailwind CSS and added custom padding values to the Tailwind config file. This enhances the component's style and code quality.

🤖[deprecated] Generated by Copilot at e100c60

Sing, O Muse, of the valiant coder who refashioned
The NeoRadioButton with skill and grace, removing
The tangled props and classes that obscured its beauty,
And clothed it with the splendid garments of Tailwind.

@shashkovdanil shashkovdanil requested a review from a team as a code owner December 12, 2023 20:42
@shashkovdanil shashkovdanil requested review from vikiival and removed request for a team December 12, 2023 20:42
@kodabot
Copy link
Collaborator

kodabot commented Dec 12, 2023

WARNING @shashkovdanil PR for issue #8222 which isn't assigned to you. Please be warned that this PR may get rejected if there's another assignee for issue #8222

Copy link

netlify bot commented Dec 12, 2023

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit e703a13
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/65795f1f575b810008d93766
😎 Deploy Preview https://deploy-preview-8543--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@shashkovdanil shashkovdanil mentioned this pull request Dec 12, 2023
33 tasks
Copy link
Contributor

reviewpad bot commented Dec 12, 2023

AI-Generated Summary: This pull request includes a major refactoring of the NeoRadioButton.vue component, from a custom style and element configuration to one compatible with the tailwindcss library. The changes include 26 deletions and 10 insertions across two key files. Specifically, the patch modifies the 'NeoRadio/NeoRadioButton.vue' and the 'tailwind.config.js' file.

Unnecessary class references, properties like 'expanded', and raw style configurations have been removed to streamline the component. It uses the "@apply" directive of Tailwind CSS to utilize classes that the library provides. Some enhancements include adjusting the radio button type to 'hidden', improved scoped styles, and optimized CSS classes.

Additionally, in 'tailwind.config.js', padding styles are added for 'button-x' and 'button-y', signaling a directional adjustment for button elements. Overall, this modification aligns with the company's desired shift towards a more maintainable and modern CSS configuration using tailwindcss.

@reviewpad reviewpad bot added small Pull request is small waiting-for-review labels Dec 12, 2023
@prury prury requested review from Jarsen136 and daiagi and removed request for vikiival December 12, 2023 22:03
@roiLeo roiLeo added this pull request to the merge queue Dec 13, 2023
Merged via the queue into kodadot:main with commit fcfb071 Dec 13, 2023
12 of 15 checks passed
Copy link

codeclimate bot commented Dec 13, 2023

Code Climate has analyzed commit e703a13 and detected 0 issues on this pull request.

View more on Code Climate.

Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

This was referenced Dec 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
small Pull request is small waiting-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migration UI kit to tailwindcss
4 participants