Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🔧 switch to tailwind & fix histoire darkmode #8361

Merged
merged 3 commits into from
Dec 4, 2023
Merged

🔧 switch to tailwind & fix histoire darkmode #8361

merged 3 commits into from
Dec 4, 2023

Conversation

roiLeo
Copy link
Contributor

@roiLeo roiLeo commented Dec 2, 2023 •
edited
Loading

Screenshot 2023-12-02 at 11-43-06 NeoSwitch › NeoSwitch Histoire
Screenshot 2023-12-02 at 11-42-59 NeoSwitch › NeoSwitch Histoire

Screenshot 2023-12-02 at 11-53-48 Create carbonless NFTs
Screenshot 2023-12-02 at 11-54-09 Create carbonless NFTs

@roiLeo roiLeo requested a review from a team as a code owner December 2, 2023 10:46
@roiLeo roiLeo requested review from yangwao and removed request for a team December 2, 2023 10:46
@netlify Netlify
Copy link

netlify bot commented Dec 2, 2023 •
edited
Loading

✅ Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 0d05820
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/656d79c49412c5000826264d
😎 Deploy Preview https://deploy-preview-8361--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@reviewpad reviewpad bot added small Pull request is small waiting-for-review labels Dec 2, 2023
@reviewpad Reviewpad
Copy link
Contributor

reviewpad bot commented Dec 2, 2023

Reviewpad Report

⚠️ Warnings

  • Please link an issue to the pull request

@reviewpad Reviewpad
Copy link
Contributor

reviewpad bot commented Dec 2, 2023

AI-Generated Summary: This pull request involves changes related to implementing Tailwind CSS and making adjustments to the dark mode setting. The changes majorly involve modification of configurations and SCSS-files related to UI components and color-scheming. The patch introduces a slight change in the 'histoire.config.ts' file and modifies various settings in the 'tailwind.scss' and 'NeoSwitch.scss' files. These modifications result in simplification and optimization of the code, changing 3 files and leading to 14 insertions and 62 deletions.

@roiLeo roiLeo requested review from exezbcz, a team, preschian and daiagi and removed request for yangwao and a team December 2, 2023 10:48
@roiLeo roiLeo marked this pull request as draft December 2, 2023 10:49
@roiLeo roiLeo marked this pull request as ready for review December 2, 2023 10:56
@roiLeo
Copy link
Contributor Author

roiLeo commented Dec 2, 2023

@shashkovdanil check please.

@exezbcz
Copy link
Member

exezbcz commented Dec 2, 2023

noticed one small thing

image

  • the outer stroke is not true black - its a shade of grey

@roiLeo
Copy link
Contributor Author

roiLeo commented Dec 2, 2023

the outer stroke is not true black - its a shade of grey

Can't find it on figma

@exezbcz
Copy link
Member

exezbcz commented Dec 2, 2023 •
edited
Loading

@roiLeo
image

ignore the size, the size we are using currently is the correct one

https://www.figma.com/file/JXNtryaNYhY0XJNArzvPQx/Handoff?type=design&node-id=1287-18959&mode=design&t=gzdTNFe3BzKrTp23-11

edit: will add among the components

@roiLeo
Copy link
Contributor Author

roiLeo commented Dec 2, 2023

hmm.. something that I don't understand
Capture d’écran 2023-12-02 à 9 49 20 PM

@exezbcz
Copy link
Member

exezbcz commented Dec 3, 2023

@roiLeo okay once again :D

the component in the histoire preview has different color of the stroke

image

@roiLeo
Copy link
Contributor Author

roiLeo commented Dec 3, 2023

@roiLeo okay once again :D

the component in the histoire preview has different color of the stroke

image

Maybe a screenshots issue? check any Switch in app to see if there IS a different outter strike

@exezbcz
Copy link
Member

exezbcz commented Dec 3, 2023

@roiLeo its ok on canary

@roiLeo roiLeo enabled auto-merge December 4, 2023 07:03
@codeclimate CodeClimate
Copy link

codeclimate bot commented Dec 4, 2023

Code Climate has analyzed commit 0d05820 and detected 0 issues on this pull request.

View more on Code Climate.

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Dec 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.6% 0.6% Duplication

@roiLeo roiLeo added this pull request to the merge queue Dec 4, 2023
Merged via the queue into kodadot:main with commit f457636 Dec 4, 2023
17 checks passed
@roiLeo roiLeo deleted the chore/ui/switch branch December 4, 2023 07:07
This was referenced Dec 7, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@exezbcz exezbcz exezbcz approved these changes

@shashkovdanil shashkovdanil shashkovdanil approved these changes

@preschian preschian preschian approved these changes

@daiagi daiagi Awaiting requested review from daiagi daiagi is a code owner automatically assigned from kodadot/code-review-guild

Assignees
No one assigned
Labels
small Pull request is small waiting-for-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@roiLeo @exezbcz @preschian @shashkovdanil