Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NeoPagination to tailwindcss #8518

Merged
merged 2 commits into from
Dec 13, 2023

Conversation

shashkovdanil
Copy link
Contributor

@shashkovdanil shashkovdanil commented Dec 10, 2023

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality

Optional

  • I've tested it at </ksm/collection>
  • I've tested PR on mobile
  • I've written unit tests 🧪
  • I've found edge cases

Did your issue had any of the "$" label on it?

  • Fill up your DOT address: Payout

Community participation

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

Copilot Summary

🤖[deprecated] Generated by Copilot at 4c4c062

Refactored NeoPagination component to use Tailwind CSS and removed unused import. This enhances the UI component's style and code quality.

🤖[deprecated] Generated by Copilot at 4c4c062

NeoPagination
Refactored with Tailwind CSS
Code is clear as ice

@shashkovdanil shashkovdanil requested a review from a team as a code owner December 10, 2023 15:11
@shashkovdanil shashkovdanil requested review from yangwao and removed request for a team December 10, 2023 15:11
@kodabot
Copy link
Collaborator

kodabot commented Dec 10, 2023

WARNING @shashkovdanil PR for issue #8222 which isn't assigned to you. Please be warned that this PR may get rejected if there's another assignee for issue #8222

Copy link

netlify bot commented Dec 10, 2023

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 0a16bdb
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/65795e4efb56a80008fd1fdb
😎 Deploy Preview https://deploy-preview-8518--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

reviewpad bot commented Dec 10, 2023

AI-Generated Summary: This pull request includes a refactoring of the NeoPagination component's styling dependencies. It removes the SCSS-based theme import and replaces it with Tailwind's utility classes. Additionally, it condenses the background property setting by utilizing Tailwind's '@apply' directive.

@reviewpad reviewpad bot added small Pull request is small waiting-for-review labels Dec 10, 2023
Copy link

codeclimate bot commented Dec 10, 2023

Code Climate has analyzed commit 4c4c062 and detected 0 issues on this pull request.

View more on Code Climate.

@shashkovdanil shashkovdanil mentioned this pull request Dec 10, 2023
33 tasks
Copy link
Contributor

@roiLeo roiLeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

linkCurrentClass

@roiLeo roiLeo added the S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved label Dec 10, 2023
@prury prury requested review from daiagi and removed request for yangwao December 11, 2023 15:33
@prury prury added the S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked label Dec 12, 2023
@roiLeo roiLeo enabled auto-merge December 13, 2023 07:33
@roiLeo roiLeo added this pull request to the merge queue Dec 13, 2023
Merged via the queue into kodadot:main with commit 49437fb Dec 13, 2023
8 of 11 checks passed
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

This was referenced Dec 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked small Pull request is small waiting-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migration UI kit to tailwindcss
5 participants