Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NeoTable and NeoModal to tailwindcss #8473

Merged
merged 3 commits into from
Dec 8, 2023

Conversation

shashkovdanil
Copy link
Contributor

@shashkovdanil shashkovdanil commented Dec 7, 2023

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality

Optional

  • I've tested it at </ksm/collection>
  • I've tested PR on mobile
  • I've written unit tests 🧪
  • I've found edge cases

Did your issue had any of the "$" label on it?

  • Fill up your DOT address: Payout

Community participation

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

Copilot Summary

🤖[deprecated] Generated by Copilot at 735b60e

Refactored NeoModal and NeoTable components to use Tailwind CSS and improved code quality. Fixed a typo in the NeoModal.story.vue title.

🤖[deprecated] Generated by Copilot at 735b60e

Sing, O Muse, of the skillful coder who refines his work
With Tailwind CSS, the swift and powerful framework
That lends its grace to NeoModal, the splendid component
That shows the shining NFTs, the gifts of Hephaestus

@shashkovdanil shashkovdanil requested a review from a team as a code owner December 7, 2023 17:35
@shashkovdanil shashkovdanil requested review from vikiival and removed request for a team December 7, 2023 17:35
@kodabot
Copy link
Collaborator

kodabot commented Dec 7, 2023

WARNING @shashkovdanil PR for issue #8222 which isn't assigned to you. Please be warned that this PR may get rejected if there's another assignee for issue #8222

Copy link

netlify bot commented Dec 7, 2023

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 735b60e
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/65720246f8aaf90008280c5a
😎 Deploy Preview https://deploy-preview-8473--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@reviewpad reviewpad bot added medium Pull request is medium waiting-for-review labels Dec 7, 2023
Copy link
Contributor

reviewpad bot commented Dec 7, 2023

AI-Generated Summary: This pull request contains two patches, with both aiming to refactor components in the UI library to use Tailwind CSS.

The first patch focuses on the NeoModal component and its associated files. It mainly removes old SCSS styling and replaces them with equivalent Tailwind CSS utility classes. This covers various CSS properties, including width, height, color, background, shadow, positioning, and z-index.

The second patch is for the NeoTable component. Similar to the first patch, it removes SCSS styles and replaces them with Tailwind CSS utility classes. This includes changes to font sizes, color, background, padding, margin, and borders. Both patches together contribute to increasing the overall consistency of the codebase, reducing the reliance on SCSS, and utilizing the convenience of Tailwind CSS for styling.

Copy link

sonarqubecloud bot commented Dec 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link

codeclimate bot commented Dec 7, 2023

Code Climate has analyzed commit 735b60e and detected 0 issues on this pull request.

View more on Code Climate.

@prury prury requested review from roiLeo and Jarsen136 December 7, 2023 22:26
@prury
Copy link
Member

prury commented Dec 7, 2023

will check this one on my morning

@prury prury added S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked and removed waiting-for-review labels Dec 8, 2023
@yangwao
Copy link
Member

yangwao commented Dec 8, 2023

Thanks!
pay 30 usd

@yangwao yangwao merged commit f82da99 into kodadot:main Dec 8, 2023
18 checks passed
@yangwao
Copy link
Member

yangwao commented Dec 8, 2023

😍 Perfect, I’ve sent the payout
💵 $30 @ 6.57 USD/DOT ~ 4.566 $DOT
🧗 16SpvdDgKNiQ3c53DxX7refnQcKUD3uRNim3Z1HBJLNGrtSP
🔗 0x32a6b3356889caa59533f44981ad352dedbcf2ca6412f5a7df8bf88186e5d088

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Dec 8, 2023
@roiLeo roiLeo mentioned this pull request Dec 8, 2023
33 tasks
This was referenced Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
medium Pull request is medium paid pull-request has been paid S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migration UI kit to tailwindcss
6 participants