-
-
Notifications
You must be signed in to change notification settings - Fork 364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NeoSkeleton to tailwindcss #8541
Conversation
WARNING @shashkovdanil PR for issue #8222 which isn't assigned to you. Please be warned that this PR may get rejected if there's another assignee for issue #8222 |
✅ Deploy Preview for koda-canary ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
AI-Generated Summary: This pull request transitions the UI from NeoSkeleton SCSS to the tailwind CSS framework. In the process, it removes the skeleton gradient function in the NeoSkeleton SCSS and replaces it with equivalent functionality using tailwind utilities. The color variables in the tailwind configuration file and SCSS file have also been updated to support this transition. Net changes include 12 additions and 27 deletions across 3 files. |
overall they are a bit brighter on deployed than on canary, both on dark/white mode, other than that looks ok |
did you add version for dark mode? |
@exezbcz yes I did |
Code Climate has analyzed commit 5276116 and detected 0 issues on this pull request. View more on Code Climate. |
Quality Gate passedKudos, no new issues were introduced! 0 New issues |
did you change something related to color? |
No, I used the same colors, you can see it in the code |
linear-gradient(90deg, rgb(219, 219, 219) 25%, rgba(219, 219, 219, 0.5) 50%, rgb(219, 219, 219) 75%) it's computed styles in this branch linear-gradient(90deg, rgb(219, 219, 219) 25%, rgba(219, 219, 219, 0.5) 50%, rgb(219, 219, 219) 75%) it's computed styles in main branch It's the same |
Thanks! |
😍 Perfect, I’ve sent the payout 🪅 Let’s grab another issue and get rewarded! |
@prury feel free to make follow up |
Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.
👇 __ Let's make a quick check before the contribution.
PR Type
Context
tailwindcss
#8222Before submitting pull request, please make sure:
Optional
Did your issue had any of the "$" label on it?
Community participation
Screenshot 📸
Copilot Summary
🤖[deprecated] Generated by Copilot at 71d8568
Refactored the NeoSkeleton component to use
tailwind.css
instead of custom SCSS code, and updated thetailwind.config.js
andtailwind.scss
files to support opacity variations and theme compatibility for the skeleton component.🤖[deprecated] Generated by Copilot at 71d8568