feat: Free drops requires activated email #8668

hassnian · 2023-12-19T11:22:56Z

PR Type

Bugfix
Feature
Refactoring

Context

Did your issue had any of the "$" label on it?

Fill up your DOT address: Payout

Community participation

Are you at KodaDot Discord?

Screenshot 📸

My fix has changed something on UI;

Copilot Summary

copilot:summary

copilot:poem

kodabot · 2023-12-19T11:23:01Z

SUCCESS @hassnian PR for issue #8575 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

netlify · 2023-12-19T11:23:01Z

✅ Deploy Preview for koda-canary ready!

Name	Link
🔨 Latest commit	`04e2ceb`
🔍 Latest deploy log	https://app.netlify.com/sites/koda-canary/deploys/65844146fd52fe000957a4c9
😎 Deploy Preview	https://deploy-preview-8668--koda-canary.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

reviewpad · 2023-12-19T11:23:16Z

AI-Generated Summary: This pull request involves updates for handling email confirmation in the application. It has brought changes over six files which include components/collection/drop/Generative.vue, components/collection/drop/modal/ConfirmEmail.vue, components/collection/drop/modal/DropConfirmModal.vue, and locales/en.json. It also created two new files - components/collection/drop/modal/ConfirmEmail.vue and public/email-subscription.svg. There has been a major change in the Generative.vue, implementing functions for email subscription and checking subscription. Also, a new Vue component for ConfirmEmail has been introduced. The changes are oriented towards adding functionality for both subscribing to an email and confirming the subscription. Additionally, this commit has also updated some labels in the locale file and introduced new utility functions in utils/newsletter.ts for subscribing and getting subscription status for an email. Overall, the update improves the email subscription and confirmation feature in the application.

roiLeo

dark-mode svg?

hassnian · 2023-12-20T10:41:36Z

@prury pls test the following scenarios

current user has no email subscription registered -> first will see the enter email step
user has already subscribed -> user could've entered their email here

they will see email confirmation step if the email is not confirmed , if it's , it will start minting
user has already confirmed the email , minting will start immediately

it might be hard to test , but this is how it should work

thanks

exezbcz · 2023-12-20T11:16:38Z

user has already subscribed -> user could've entered their email here

or on a previous drop

vikiival · 2023-12-20T11:34:31Z

Deployed enjoy

https://github.com/kodadot/workers/actions/runs/7274782427

hassnian · 2023-12-20T11:54:35Z

dark-mode svg?

added

roiLeo

smoll, otherwise lgtm

roiLeo · 2023-12-20T13:20:23Z

components/collection/drop/modal/ConfirmEmail.vue

+</template>
+
+<script setup lang="ts">
+import ModalIdentityItem from '@/components/shared/ModalIdentityItem.vue'


auto imported

Suggested change

import ModalIdentityItem from '@/components/shared/ModalIdentityItem.vue'

roiLeo · 2023-12-20T13:21:33Z

components/collection/drop/modal/ConfirmEmail.vue

+
+  <hr class="m-0 mb-2 mt-5" />
+
+  <div class="capitalize is-size-7 has-text-k-grey">


Suggested change

<div class="capitalize is-size-7 has-text-k-grey">

<div class="capitalize text-xs text-k-grey">

roiLeo · 2023-12-20T13:21:58Z

components/collection/drop/Generative.vue

+
+onMounted(() => {
+  if (preferencesStore.getNewsletterSubscription.confirmed) {
+    emailConfirmed.value = true


make this value computed instead?

roiLeo · 2023-12-20T13:23:18Z

utils/newsletter.ts

+
+export async function getSubscription(email: string) {
+  try {
+    return api<SubscriptionByEmailResponse>(`/subscribe/${email}`, {


roiLeo · 2023-12-20T13:23:25Z

utils/newsletter.ts

+
+export async function resendConfirmationEmail(email: string) {
+  try {
+    return api('/subscribe/resend-confirmation', {


yangwao · 2023-12-20T13:53:57Z

Testing at

https://deploy-preview-8668--koda-canary.netlify.app/ahp/drops/chaosflakes

… mount

hassnian · 2023-12-21T09:49:38Z

I've used [email protected] could be possible doesn't handle well?

seems like an issue on beehiiv's end , that endpoint doesn't handle emails with special chars

email is registered

but when you try to get it using their api , 404 is returned

switched to using subscription id -> kodadot/workers#234

yangwao · 2023-12-21T13:34:48Z

let's see if it build oka

yangwao · 2023-12-21T13:35:03Z

newsletter: migrate to using subscription id instate of email workers#234 deployed

locales/en.json

sonarqubecloud · 2023-12-21T13:45:06Z

Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

codeclimate · 2023-12-21T13:45:19Z

Code Climate has analyzed commit 04e2ceb and detected 0 issues on this pull request.

View more on Code Climate.

yangwao · 2023-12-21T13:47:55Z

Thanks!
pay 80 usd

yangwao · 2023-12-21T13:48:08Z

😍 Perfect, I’ve sent the payout
💵 $80 @ 7.63 USD/DOT ~ 10.485 $DOT
🧗 13QUj3pZyFNfYj4AM336hRdyLQbevj5H3sR4PKmLEXLdwZhh
🔗 0x18755e46370f747497078720ac315cea96bfc627078e1a8d50184a030ae49bec

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

yangwao · 2023-12-21T13:48:13Z

green

add: email confirmation working

dc4ac47

reviewpad bot added the medium Pull request is medium label Dec 19, 2023

hassnian and others added 6 commits December 19, 2023 16:31

ref: no empty tags

2f6710a

Merge branch 'main' into issue-8575

2846070

Merge branch 'main' into issue-8575

6163c98

add. preference newsletter subscription

9d66141

add: remeber email subscription on modal

977259e

add: resend confirmation email

36f1664

reviewpad bot added large Pull request is large and removed medium Pull request is medium labels Dec 20, 2023

hassnian marked this pull request as ready for review December 20, 2023 09:48

hassnian requested a review from a team as a code owner December 20, 2023 09:48

hassnian requested review from roiLeo and Jarsen136 and removed request for a team December 20, 2023 09:48

reviewpad bot added the waiting-for-review label Dec 20, 2023

Merge branch 'main' into issue-8575

19ad3c6

Jarsen136 approved these changes Dec 20, 2023

View reviewed changes

Jarsen136 requested a review from prury December 20, 2023 10:37

roiLeo reviewed Dec 20, 2023

View reviewed changes

add: dark mode image

767016c

roiLeo approved these changes Dec 20, 2023

View reviewed changes

prury added the S-changes-requested-🤞 PR is almost good to go, just some fine tunning label Dec 20, 2023

hassnian and others added 10 commits December 21, 2023 07:27

Merge branch 'main' into issue-8575

9687d11

fix: error message typo

fe9e4de

ref: email not confirmed message and added user subscription check on…

a7cf4d2

… mount

fix: added await to newsletter utils

f7d1295

add: send confirmation email is only subscribed

b85bf01

ref: seperate watchers by concern

d341d56

fix: use id for getting subscriptions

2547cd4

fix: clear email settings on failed request

f4fcf17

add: send email on modal open if possible

fabdc39

fix: use new subscription id on email resend

7ea0c64

hassnian mentioned this pull request Dec 21, 2023

newsletter: migrate to using subscription id instate of email kodadot/workers#234

Merged

hassnian and others added 3 commits December 21, 2023 14:51

Merge branch 'main' into issue-8575

17f0f01

fix: check if should send confirmation email on modal open

cb1ccde

Merge branch 'main' into issue-8575

b87004d

yangwao reviewed Dec 21, 2023

View reviewed changes

locales/en.json Outdated Show resolved Hide resolved

Update locales/en.json

04e2ceb

yangwao added the paid pull-request has been paid label Dec 21, 2023

yangwao merged commit e6736bd into kodadot:main Dec 21, 2023
15 checks passed

hassnian deleted the issue-8575 branch December 21, 2023 13:53

This was referenced Dec 21, 2023

beta update #8723

Merged

release update #8724

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Free drops requires activated email #8668

feat: Free drops requires activated email #8668

hassnian commented Dec 19, 2023 •

edited

Loading

kodabot commented Dec 19, 2023

netlify bot commented Dec 19, 2023 •

edited

Loading

reviewpad bot commented Dec 19, 2023

roiLeo left a comment

hassnian commented Dec 20, 2023 •

edited

Loading

exezbcz commented Dec 20, 2023

vikiival commented Dec 20, 2023

hassnian commented Dec 20, 2023

roiLeo left a comment

roiLeo Dec 20, 2023

roiLeo Dec 20, 2023

roiLeo Dec 20, 2023

roiLeo Dec 20, 2023

roiLeo Dec 20, 2023

yangwao commented Dec 20, 2023

hassnian commented Dec 21, 2023 •

edited

Loading

yangwao commented Dec 21, 2023

yangwao commented Dec 21, 2023

sonarqubecloud bot commented Dec 21, 2023

codeclimate bot commented Dec 21, 2023

yangwao commented Dec 21, 2023

yangwao commented Dec 21, 2023

yangwao commented Dec 21, 2023


		<hr class="m-0 mb-2 mt-5" />

		<div class="capitalize is-size-7 has-text-k-grey">

	<div class="capitalize is-size-7 has-text-k-grey">
	<div class="capitalize text-xs text-k-grey">

feat: Free drops requires activated email #8668

feat: Free drops requires activated email #8668

Conversation

hassnian commented Dec 19, 2023 • edited Loading

PR Type

Context

Did your issue had any of the "$" label on it?

Community participation

Screenshot 📸

Copilot Summary

kodabot commented Dec 19, 2023

netlify bot commented Dec 19, 2023 • edited Loading

✅ Deploy Preview for koda-canary ready!

reviewpad bot commented Dec 19, 2023

roiLeo left a comment

Choose a reason for hiding this comment

hassnian commented Dec 20, 2023 • edited Loading

exezbcz commented Dec 20, 2023

vikiival commented Dec 20, 2023

hassnian commented Dec 20, 2023

roiLeo left a comment

Choose a reason for hiding this comment

roiLeo Dec 20, 2023

Choose a reason for hiding this comment

roiLeo Dec 20, 2023

Choose a reason for hiding this comment

roiLeo Dec 20, 2023

Choose a reason for hiding this comment

roiLeo Dec 20, 2023

Choose a reason for hiding this comment

roiLeo Dec 20, 2023

Choose a reason for hiding this comment

yangwao commented Dec 20, 2023

hassnian commented Dec 21, 2023 • edited Loading

yangwao commented Dec 21, 2023

yangwao commented Dec 21, 2023

sonarqubecloud bot commented Dec 21, 2023

Quality Gate passed

codeclimate bot commented Dec 21, 2023

yangwao commented Dec 21, 2023

yangwao commented Dec 21, 2023

yangwao commented Dec 21, 2023

hassnian commented Dec 19, 2023 •

edited

Loading

netlify bot commented Dec 19, 2023 •

edited

Loading

hassnian commented Dec 20, 2023 •

edited

Loading

hassnian commented Dec 21, 2023 •

edited

Loading