Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NeoMessage to tailwindcss #8509

Merged
merged 5 commits into from
Dec 13, 2023
Merged

Conversation

shashkovdanil
Copy link
Contributor

@shashkovdanil shashkovdanil commented Dec 10, 2023

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality

Optional

  • I've tested it at </ksm/collection>
  • I've tested PR on mobile
  • I've written unit tests 🧪
  • I've found edge cases

Did your issue had any of the "$" label on it?

  • Fill up your DOT address: Payout

Community participation

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

Copilot Summary

🤖[deprecated] Generated by Copilot at 1bfa3b4

Created and applied custom styles for the NeoMessage component, which is used to display messages in the UI. The styles are based on Bulma's message component, but use Tailwind's utilities and custom colors. The styles also improve the consistency of the message component's appearance.

🤖[deprecated] Generated by Copilot at 1bfa3b4

Oh, we're the crew of the NeoMessage
We style it with @apply and sass
We make it look nice with border and radius
And we pull the code to the main branch at last

@shashkovdanil shashkovdanil requested review from a team as code owners December 10, 2023 12:30
@shashkovdanil shashkovdanil requested review from yangwao and roiLeo and removed request for a team December 10, 2023 12:30
@kodabot
Copy link
Collaborator

kodabot commented Dec 10, 2023

WARNING @shashkovdanil PR for issue #8222 which isn't assigned to you. Please be warned that this PR may get rejected if there's another assignee for issue #8222

Copy link

netlify bot commented Dec 10, 2023

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit c658441
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/65799c82e77b4f000836c2c2
😎 Deploy Preview https://deploy-preview-8509--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

reviewpad bot commented Dec 10, 2023

AI-Generated Summary: This pull request introduces changes related to NeoMessage and its styling with Tailwind CSS. Multiple modifications have been made to the MessageNotify.vue file, primarily about border styling and radius. Significantly, a new file named NeoMessage.scss is created and added with 192 lines of SCSS classes and utility class application. Thus, the existing styling has been enhanced and customized using Tailwind. Furthermore, the NeoMessage.scss file was imported for use in the NeoMessage.vue component resulting in more efficient and organized CSS management.

@reviewpad reviewpad bot added medium Pull request is medium waiting-for-review labels Dec 10, 2023
@shashkovdanil shashkovdanil mentioned this pull request Dec 10, 2023
33 tasks
@prury prury requested review from Jarsen136 and removed request for yangwao December 12, 2023 19:04
@prury prury added the S-changes-requested-🤞 PR is almost good to go, just some fine tunning label Dec 12, 2023
@prury
Copy link
Member

prury commented Dec 12, 2023

message background white on dark mode:
image

@shashkovdanil
Copy link
Contributor Author

@prury fixed

Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

codeclimate bot commented Dec 13, 2023

Code Climate has analyzed commit c658441 and detected 0 issues on this pull request.

View more on Code Climate.

@prury prury added S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked and removed S-changes-requested-🤞 PR is almost good to go, just some fine tunning labels Dec 13, 2023
@roiLeo roiLeo added this pull request to the merge queue Dec 13, 2023
Merged via the queue into kodadot:main with commit 9b63043 Dec 13, 2023
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
medium Pull request is medium S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked waiting-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migration UI kit to tailwindcss
5 participants