Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NeoModalHead to tailwindcss #8516

Merged
merged 4 commits into from
Dec 14, 2023

Conversation

shashkovdanil
Copy link
Contributor

@shashkovdanil shashkovdanil commented Dec 10, 2023

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality

Optional

  • I've tested it at </ksm/collection>
  • I've tested PR on mobile
  • I've written unit tests 🧪
  • I've found edge cases

Did your issue had any of the "$" label on it?

  • Fill up your DOT address: Payout

Community participation

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

Copilot Summary

🤖[deprecated] Generated by Copilot at 7232e9f

Refactored NeoModalHead component to use Tailwind CSS instead of Bulma and SCSS. Added custom padding classes to tailwind.config.js.

🤖[deprecated] Generated by Copilot at 7232e9f

We're breaking free from the chains of Bulma
We're styling with the power of Tailwind
We're padding our way to the modal doom
We're refactoring the code with no fear

@shashkovdanil shashkovdanil requested a review from a team as a code owner December 10, 2023 14:46
@shashkovdanil shashkovdanil requested review from yangwao and removed request for a team December 10, 2023 14:46
@kodabot
Copy link
Collaborator

kodabot commented Dec 10, 2023

WARNING @shashkovdanil PR for issue #8222 which isn't assigned to you. Please be warned that this PR may get rejected if there's another assignee for issue #8222

Copy link

netlify bot commented Dec 10, 2023

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 68bad26
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/657b3083c3e63e00086506f3
😎 Deploy Preview https://deploy-preview-8516--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

reviewpad bot commented Dec 10, 2023

AI-Generated Summary: This pull request involves the transition of NeoModalHead styling from SCSS to Tailwind CSS. It involves the removal of NeoModalHead.scss file, as well as modifications to .vue file. The old SCSS specific styles are replaced with Tailwind classes. In addition to this, padding shortcuts have been added in the tailwind.config.js file to accommodate for the replaced styles. This contributes to reducing the total amount of code, as 47 deletions are made compared to 16 insertions.

@reviewpad reviewpad bot added small Pull request is small waiting-for-review labels Dec 10, 2023
@shashkovdanil shashkovdanil mentioned this pull request Dec 10, 2023
33 tasks
@prury
Copy link
Member

prury commented Dec 11, 2023

@shashkovdanil test is looking for data-testid="shopping-cart-modal" inside a <NeoModalHead> tag inside shoppingcartmodal.vue file

when i inspect the page, it seems that the dom does not generate this attribute

i'm investigating, if you have any clues let me know

@prury prury requested review from roiLeo and Jarsen136 and removed request for yangwao December 11, 2023 17:54
@shashkovdanil
Copy link
Contributor Author

Ye ye I'll fix test

@shashkovdanil shashkovdanil requested a review from a team as a code owner December 11, 2023 23:27
Copy link

codeclimate bot commented Dec 11, 2023

Code Climate has analyzed commit e97b317 and detected 0 issues on this pull request.

View more on Code Climate.

@prury prury added S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked and removed waiting-for-review labels Dec 12, 2023
@roiLeo roiLeo mentioned this pull request Dec 13, 2023
5 tasks
@roiLeo roiLeo added this pull request to the merge queue Dec 14, 2023
Merged via the queue into kodadot:main with commit ae92eb0 Dec 14, 2023
13 of 15 checks passed
Copy link

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

1 New issue
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@vikiival vikiival mentioned this pull request Dec 15, 2023
This was referenced Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked small Pull request is small
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migration UI kit to tailwindcss
5 participants