fix: Profile colour change

[Jarsen136]

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

• Bugfix

Needs Design check

• @exezbcz please review

Context

• Closes Profile colour change #8513
• Requires deployment <snek/rubick/worker>

Did your issue had any of the "$" label on it?

• My DOT address: Payout

Screenshot 📸

• My fix has changed UI

Copilot Summary

🤖[deprecated] Generated by Copilot at 899e788

Removed theme mixins from NeoModalHead.scss to fix modal header color on dark mode. This was part of a UI bug fix pull request.

🤖[deprecated] Generated by Copilot at 899e788

ktheme blocks gone
Modal header color fixed
Dark mode in winter

[kodabot]

SUCCESS @Jarsen136 PR for issue #8513 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

[netlify]

✅ Deploy Preview for koda-canary ready!

Name	Link
🔨 Latest commit	1e1001f
🔍 Latest deploy log	https://app.netlify.com/sites/koda-canary/deploys/6579ba6833b2a000081b348a
😎 Deploy Preview	https://deploy-preview-8519--koda-canary.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[reviewpad]

AI-Generated Summary: This pull request removes the modifications related to the theme colors from the NeoModalHead component in 'NeoModalHead.scss' file. This includes eliminating a background color switch for different themes and a text color modification. The patch will keep the modal card title's font size and line-height intact.

[exezbcz]

Wait wait, I don't think this one is a bug...

[hassnian]

Wait wait, I don't think this one is a bug...

maybe viewport issue , should only be shown on the mobile version ?

missing color for cross icon

[Jarsen136]

Wait wait, I don't think this one is a bug...

Then what should we do here regarding the color change @exezbcz

[exezbcz]

when navbar is collapsed into burger menu, all the menu items have black top part - following the design in mobile (subsection explore etc.)

[Jarsen136]

when navbar is collapsed into burger menu, all the menu items have black top part - following the design in mobile (subsection explore etc.)

Updated

[daiagi]

isn't this pr redundant?
if the color suppose to change then there is no issue, right?

[roiLeo]

isn't this pr redundant? if the color suppose to change then there is no issue, right?

I don't see diffenrence between canary too, may @Jarsen136 explain what's changing
Plus we will have conflicts with #8516

[Jarsen136]

isn't this pr redundant? if the color suppose to change then there is no issue, right?

I don't see diffenrence between canary too, may @Jarsen136 explain what's changing Plus we will have conflicts with #8516

There is only one thing that changed: the color of close button.

before

after

Plus we will have conflicts with #8516

Yes, no matter which pr is merged first, we should fix the color

[roiLeo]

is it missing here too?

[Jarsen136]

is it missing here too?

I guess not. You can check their difference here:

close button on web

back button on the mobile

[codeclimate]

Code Climate has analyzed commit 1e1001f and detected 0 issues on this pull request.

View more on Code Climate.

[sonarqubecloud]

Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

2 New issues
0 Security Hotspots
No data about Coverage
0.5% Duplication on New Code

See analysis details on SonarCloud

[prury]

but aren't we the only ones that resize the browser for testing purposes? (i don't do it tho, since every screen change needs refreshing to be properly shown). irl people will access koda within their chosen devices and that's it

[exezbcz]

@prury +1

lets not waste so much time here, visual ok, there are more important bugs

[Jarsen136]

but aren't we the only ones that resize the browser for testing purposes? (i don't do it tho, since every screen change needs refreshing to be properly shown). irl people will access koda within their chosen devices and that's it

It makes sense then I guess we could close this issue for now.