-
-
Notifications
You must be signed in to change notification settings - Fork 364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NeoLoading to tailwindcss and added icons to historie #8412
Conversation
WARNING @shashkovdanil PR for issue #8222 which isn't assigned to you. Please be warned that this PR may get rejected if there's another assignee for issue #8222 |
✅ Deploy Preview for koda-canary ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
AI-Generated Summary: This pull request includes updates to the UI libraries, primarily involving changes to the NeoLoading and histoires components. New dependencies were added to the package.json file, namely "@fortawesome/fontawesome-svg-core" and "@fortawesome/vue-fontawesome". The NeoLoading.scss file has been adjusted to fit the tailwind CSS approach. A script for FontAwesome was added in histoire.setup.ts. This PR also involved an overall cleaner import statement structure, and the color of the NeoIcon in the NeoLoading.vue file was switched from "has-text-white" to "text-white". The NeoLoading.story.vue file also had its NeoLoading sub-component adjusted to include an active property. Lastly, minor changes were made to the pnpm-lock.yaml file. |
Code Climate has analyzed commit 681f47c and detected 0 issues on this pull request. View more on Code Climate. |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.
👇 __ Let's make a quick check before the contribution.
PR Type
Context
tailwindcss
#8222Before submitting pull request, please make sure:
Optional
Did your issue had any of the "$" label on it?
Community participation
Screenshot 📸
Copilot Summary
🤖[deprecated] Generated by Copilot at 681f47c
The pull request adds support for Font Awesome icons in the UI library and updates the NeoLoading component to use them. It also fixes some minor issues with the SCSS imports, the overlay color, and the class name for the NeoIcon component. It modifies the
pnpm-lock.yaml
,libs/ui/package.json
,libs/ui/src/components/NeoLoading/NeoLoading.scss
,libs/ui/src/components/NeoLoading/NeoLoading.story.vue
,libs/ui/src/components/NeoLoading/NeoLoading.vue
, andlibs/ui/src/histoire.setup.ts
files.🤖[deprecated] Generated by Copilot at 681f47c