Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NeoLoading to tailwindcss and added icons to historie #8412

Merged
merged 2 commits into from
Dec 5, 2023

Conversation

shashkovdanil
Copy link
Contributor

@shashkovdanil shashkovdanil commented Dec 4, 2023

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality

Optional

  • I've tested it at </ksm/collection>
  • I've tested PR on mobile
  • I've written unit tests 🧪
  • I've found edge cases

Did your issue had any of the "$" label on it?

  • Fill up your DOT address: Payout

Community participation

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

Copilot Summary

🤖[deprecated] Generated by Copilot at 681f47c

The pull request adds support for Font Awesome icons in the UI library and updates the NeoLoading component to use them. It also fixes some minor issues with the SCSS imports, the overlay color, and the class name for the NeoIcon component. It modifies the pnpm-lock.yaml, libs/ui/package.json, libs/ui/src/components/NeoLoading/NeoLoading.scss, libs/ui/src/components/NeoLoading/NeoLoading.story.vue, libs/ui/src/components/NeoLoading/NeoLoading.vue, and libs/ui/src/histoire.setup.ts files.

🤖[deprecated] Generated by Copilot at 681f47c

To use Font Awesome in our UI
We added some deps and a script too
We simplified SCSS
And changed the NeoIcon class
And updated the story for NeoLoading to use active prop, not slot

@shashkovdanil shashkovdanil requested review from a team as code owners December 4, 2023 23:12
@shashkovdanil shashkovdanil requested review from vikiival and preschian and removed request for a team December 4, 2023 23:12
@kodabot
Copy link
Collaborator

kodabot commented Dec 4, 2023

WARNING @shashkovdanil PR for issue #8222 which isn't assigned to you. Please be warned that this PR may get rejected if there's another assignee for issue #8222

Copy link

netlify bot commented Dec 4, 2023

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 5c309ca
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/656f031f9909d00008e67556
😎 Deploy Preview https://deploy-preview-8412--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

reviewpad bot commented Dec 4, 2023

AI-Generated Summary: This pull request includes updates to the UI libraries, primarily involving changes to the NeoLoading and histoires components. New dependencies were added to the package.json file, namely "@fortawesome/fontawesome-svg-core" and "@fortawesome/vue-fontawesome". The NeoLoading.scss file has been adjusted to fit the tailwind CSS approach. A script for FontAwesome was added in histoire.setup.ts. This PR also involved an overall cleaner import statement structure, and the color of the NeoIcon in the NeoLoading.vue file was switched from "has-text-white" to "text-white". The NeoLoading.story.vue file also had its NeoLoading sub-component adjusted to include an active property. Lastly, minor changes were made to the pnpm-lock.yaml file.

@reviewpad reviewpad bot added small Pull request is small waiting-for-review labels Dec 4, 2023
Copy link

codeclimate bot commented Dec 4, 2023

Code Climate has analyzed commit 681f47c and detected 0 issues on this pull request.

View more on Code Climate.

@preschian preschian requested a review from roiLeo December 5, 2023 03:59
libs/ui/src/histoire.setup.ts Show resolved Hide resolved
@roiLeo roiLeo enabled auto-merge December 5, 2023 11:01
@roiLeo roiLeo added this pull request to the merge queue Dec 5, 2023
Merged via the queue into kodadot:main with commit cc532ae Dec 5, 2023
12 of 15 checks passed
Copy link

sonarqubecloud bot commented Dec 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

This was referenced Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
small Pull request is small waiting-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migration UI kit to tailwindcss
4 participants