Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrated NeoSecondaryButton to tailwindcss #8503

Closed

Conversation

shashkovdanil
Copy link
Contributor

@shashkovdanil shashkovdanil commented Dec 9, 2023

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality

Optional

  • I've tested it at </ksm/collection>
  • I've tested PR on mobile
  • I've written unit tests 🧪
  • I've found edge cases

Did your issue had any of the "$" label on it?

  • Fill up your DOT address: Payout

Community participation

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

Copilot Summary

🤖[deprecated] Generated by Copilot at 07d26e6

This pull request optimizes the SCSS and Vue code for the NeoButton and NeoSecondaryButton components, by importing only the needed SCSS files from Oruga UI, and using Tailwind CSS utility classes for styling.

🤖[deprecated] Generated by Copilot at 07d26e6

Oruga imports trimmed
Tailwind classes simplify
NeoButton shines

@shashkovdanil shashkovdanil requested a review from a team as a code owner December 9, 2023 16:42
@shashkovdanil shashkovdanil requested review from yangwao and removed request for a team December 9, 2023 16:42
@kodabot
Copy link
Collaborator

kodabot commented Dec 9, 2023

WARNING @shashkovdanil PR for issue #8222 which isn't assigned to you. Please be warned that this PR may get rejected if there's another assignee for issue #8222

Copy link

netlify bot commented Dec 9, 2023

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 6347d14
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/6575f46ee7be2c00080c0fa6
😎 Deploy Preview https://deploy-preview-8503--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

reviewpad bot commented Dec 9, 2023

AI-Generated Summary: This pull request includes changes related to the migration of the NeoSecondaryButton to tailwindcss. Several SCSS classes have been replaced with their tailwindcss equivalent. Instead of explicit styling through SCSS, tailwindcss utility classes have been used for building the UI. This applies to NeoButton and NeoSecondaryButton components, especially regarding their primary and info variants. The custom SCSS imports have been replaced with specific utility and component imports from oruga-next library.

@reviewpad reviewpad bot added small Pull request is small waiting-for-review labels Dec 9, 2023
@shashkovdanil shashkovdanil mentioned this pull request Dec 10, 2023
33 tasks
Copy link

codeclimate bot commented Dec 10, 2023

Code Climate has analyzed commit 6347d14 and detected 0 issues on this pull request.

View more on Code Climate.

Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Contributor

@roiLeo roiLeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see #8362

@shashkovdanil
Copy link
Contributor Author

see #8362

What exactly?

@roiLeo
Copy link
Contributor

roiLeo commented Dec 11, 2023

see #8362

What exactly?

I'm already working on this one, I think NeoSecondaryButton should be in NeoButton with variant

@prury
Copy link
Member

prury commented Dec 12, 2023

see #8362

What exactly?

I'm already working on this one, I think NeoSecondaryButton should be in NeoButton with variant

close this one or wait?

@shashkovdanil
Copy link
Contributor Author

see #8362

What exactly?

I'm already working on this one, I think NeoSecondaryButton should be in NeoButton with variant

close this one or wait?

cc @roiLeo

@roiLeo
Copy link
Contributor

roiLeo commented Dec 18, 2023

continue in #8362

@roiLeo roiLeo closed this Dec 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
small Pull request is small waiting-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migration UI kit to tailwindcss
4 participants