Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔧 NeoButton final story #8362

Closed
wants to merge 2 commits into from
Closed

Conversation

roiLeo
Copy link
Contributor

@roiLeo roiLeo commented Dec 2, 2023

link #7957
Capture d’écran 2023-12-02 à 2 08 25 PM
Capture d’écran 2023-12-02 à 2 09 39 PM

Copy link

netlify bot commented Dec 2, 2023

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 9a07f4f
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/6581925e12d950000879ed57
😎 Deploy Preview https://deploy-preview-8362--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

reviewpad bot commented Dec 2, 2023

AI-Generated Summary: This pull request contains three separate patches, each detailing different updates to UI components and styles.

  1. The first patch is centered on switching the project to use Tailwind CSS and fixing the 'histoire' dark mode. This includes modifications to 'histoire.config.ts', 'NeoSwitch.scss', and 'tailwind.scss'. Updates include restructuring configurations, replacing Numeric CSS classes with Tailwind's utility classes, and removal of redundant CSS rules which are already covered by the Tailwind.

  2. The second patch adjusts the Dark Mode color variables in 'tailwind.scss'. Class naming or syntax has been adjusted for the application of dark mode styles.

  3. The final patch overhauls the styling and story of the NeoButton component. It modifies three files ('NeoButton.scss', 'NeoButton.story.vue', and 'NeoCheckbox.story.vue'), adding new variations to its stories for different visual states and sizes. It also imports more CSS utilities from Oruga and Tailwind for additional style control.

@reviewpad reviewpad bot added the medium Pull request is medium label Dec 2, 2023
Copy link
Contributor

reviewpad bot commented Dec 2, 2023

Reviewpad Report

⚠️ Warnings

  • Please link an issue to the pull request

@exezbcz
Copy link
Member

exezbcz commented Dec 3, 2023

button story,

is anything needed from me sir? 👀

Copy link

codeclimate bot commented Dec 19, 2023

Code Climate has analyzed commit 9a07f4f and detected 0 issues on this pull request.

View more on Code Climate.

Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.4% Duplication on New Code

See analysis details on SonarCloud

@exezbcz
Copy link
Member

exezbcz commented Jan 12, 2024

what is needed here to be finished?

some styles I see that are not correct:

image
image
image

@roiLeo
Copy link
Contributor Author

roiLeo commented Jan 16, 2024

what is needed here to be finished?

styling, and remove old integration

some styles I see that are not correct:

yup, wip will try to finish as soon as I've got time

@yangwao
Copy link
Member

yangwao commented Mar 12, 2024

Stale, please reopen if there is intent to finish it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
medium Pull request is medium
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants