-
-
Notifications
You must be signed in to change notification settings - Fork 364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Small refactoring NeoModalExtend #8514
Small refactoring NeoModalExtend #8514
Conversation
WARNING @shashkovdanil PR for issue #8222 which isn't assigned to you. Please be warned that this PR may get rejected if there's another assignee for issue #8222 |
✅ Deploy Preview for koda-canary ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Code Climate has analyzed commit c94b8e4 and detected 0 issues on this pull request. View more on Code Climate. |
AI-Generated Summary: This pull request includes a small refactoring of NeoModalExtend. It includes CSS changes, removing explicit styles for classes such as 'o-modal' and its associated classes. These styles have been replaced with equivalent SCSS variables for better maintainability and reusability. Moreover, the order of importing styles from oruga-ui was changed, putting the import statement of '_modal.scss' at the end, after SCSS variables are declared. The changes aim to enhance code readability, maintainability, and style consistency. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code looks ok
hard to tell if it works as it isn't being used anywhere
Quality Gate passedKudos, no new issues were introduced! 0 New issues |
Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.
👇 __ Let's make a quick check before the contribution.
PR Type
Context
tailwindcss
#8222Before submitting pull request, please make sure:
Optional
Did your issue had any of the "$" label on it?
Community participation
Screenshot 📸
Copilot Summary
🤖[deprecated] Generated by Copilot at c94b8e4
Refactored modal component style to use Sass variables. Removed unnecessary theme import.
🤖[deprecated] Generated by Copilot at c94b8e4