Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small refactoring NeoModalExtend #8514

Merged
merged 2 commits into from
Dec 14, 2023

Conversation

shashkovdanil
Copy link
Contributor

@shashkovdanil shashkovdanil commented Dec 10, 2023

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality

Optional

  • I've tested it at </ksm/collection>
  • I've tested PR on mobile
  • I've written unit tests 🧪
  • I've found edge cases

Did your issue had any of the "$" label on it?

  • Fill up your DOT address: Payout

Community participation

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

Copilot Summary

🤖[deprecated] Generated by Copilot at c94b8e4

Refactored modal component style to use Sass variables. Removed unnecessary theme import.

🤖[deprecated] Generated by Copilot at c94b8e4

Sass variables
refine modal component
autumn of hard codes

@shashkovdanil shashkovdanil requested a review from a team as a code owner December 10, 2023 13:54
@shashkovdanil shashkovdanil requested review from vikiival and removed request for a team December 10, 2023 13:54
@kodabot
Copy link
Collaborator

kodabot commented Dec 10, 2023

WARNING @shashkovdanil PR for issue #8222 which isn't assigned to you. Please be warned that this PR may get rejected if there's another assignee for issue #8222

Copy link

netlify bot commented Dec 10, 2023

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit e2cc365
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/657ab0b6b64d6400089ead63
😎 Deploy Preview https://deploy-preview-8514--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@reviewpad reviewpad bot added small Pull request is small waiting-for-review labels Dec 10, 2023
Copy link

codeclimate bot commented Dec 10, 2023

Code Climate has analyzed commit c94b8e4 and detected 0 issues on this pull request.

View more on Code Climate.

Copy link
Contributor

reviewpad bot commented Dec 10, 2023

AI-Generated Summary: This pull request includes a small refactoring of NeoModalExtend. It includes CSS changes, removing explicit styles for classes such as 'o-modal' and its associated classes. These styles have been replaced with equivalent SCSS variables for better maintainability and reusability. Moreover, the order of importing styles from oruga-ui was changed, putting the import statement of '_modal.scss' at the end, after SCSS variables are declared. The changes aim to enhance code readability, maintainability, and style consistency.

@shashkovdanil shashkovdanil mentioned this pull request Dec 10, 2023
33 tasks
@prury prury requested a review from daiagi December 13, 2023 13:28
Copy link
Contributor

@daiagi daiagi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks ok
hard to tell if it works as it isn't being used anywhere

@roiLeo roiLeo added this pull request to the merge queue Dec 14, 2023
Merged via the queue into kodadot:main with commit 10bbda5 Dec 14, 2023
13 of 15 checks passed
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
small Pull request is small waiting-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migration UI kit to tailwindcss
4 participants