-
-
Notifications
You must be signed in to change notification settings - Fork 364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CSS Refactoring step 1 #8071
Comments
This is brave task |
@preschian @roiLeo I want use this variables across project instead of |
We can achieve that while on the go. I think migrating most of the part from I expect to reduce no of lines from |
@preschian do you wanna use tailwindcss not only in UI? If so, I can do it in this task, also get rid of most of the styles in global.scss |
For me, yes. It would be better if we could also use that in our Kodadot app. Are there other reasons we can't use Tailwind in our app? cc @kodadot/internal-dev
|
Ye, tailwindcss is good in terms of performance https://tailwindcss.com/docs/optimizing-for-production |
let's got! Goal is to replace Bulma in I'm just wondering what's the difference with nuxt-tailwind & official tailwind package? only viewer? |
The biggest difference is the presence of viewer, the rest is minor things like writing config not in a separate file, but in nuxt.module.ts, and pre-installed nesting. I'd leave the configuration explicit, to be honest |
Okay guys, scope for this task
@roiLeo @preschian that sounds good? |
Sounds good! I would migrate our UI components first, then migrate all in-app helpers to tailwind. |
looks good 👍
this one is not in the same PR right? this one will be huge |
Task for components |
Isnt it better to use unocss + some custom thingies? |
Nah, tailwindcss is a very well developed tool that has a large community, financial support, lots of handy stuff like code editor extensions. Also good documentation |
@roiLeo assign this task on me please |
Related issue #8556 |
Note that we need to refactor css by:
|
this one is open |
Is your feature request related to a problem?
!important
Discussion is here #8066
Describe the solution you would like
Find all the places where inline styles and !important are used and rewrite them.
Right now scss variables are used mostly for themes, I want to use a bunch of https://color-mode.nuxtjs.org/ + :root selector
сс @preschian @roiLeo
Describe alternatives you have considered
Screenshots
No response
Are there opened related issues?
No response
The text was updated successfully, but these errors were encountered: