Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor inline styles #9528

Closed
wants to merge 9 commits into from
Closed

Refactor inline styles #9528

wants to merge 9 commits into from

Conversation

pbkompasz
Copy link
Contributor

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality

Optional

  • I've tested it at </ksm/collection>
  • I've tested PR on mobile
  • I've written unit tests 🧪
  • I've found edge cases

Did your issue had any of the "$" label on it?

  • Fill up your DOT address: Payout

Community participation

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

Copilot Summary

@kodabot
Copy link
Collaborator

kodabot commented Feb 22, 2024

WARNING @pbkompasz PR for issue #8071 which isn't assigned to you. Please be warned that this PR may get rejected if there's another assignee for issue #8071

@netlify Netlify
Copy link

netlify bot commented Feb 22, 2024 •
edited
Loading

✅ Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 5f123ac
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/65d89baf95149800081c350d
😎 Deploy Preview https://deploy-preview-9528--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@pbkompasz pbkompasz marked this pull request as ready for review February 23, 2024 09:29
@pbkompasz pbkompasz requested a review from a team as a code owner February 23, 2024 09:29
@pbkompasz pbkompasz requested review from yangwao and removed request for a team February 23, 2024 09:29
@Jarsen136
Copy link
Contributor

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.
image image

It causes too much UI breaking so I would close this PR. Feel free to open the PR again once you have fixed and tested most of the cases

@pbkompasz pbkompasz marked this pull request as draft February 23, 2024 12:19
@codeclimate CodeClimate
Copy link

codeclimate bot commented Feb 23, 2024

Code Climate has analyzed commit 5f123ac and detected 0 issues on this pull request.

View more on Code Climate.

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@pbkompasz pbkompasz marked this pull request as ready for review February 23, 2024 13:22
@exezbcz
Copy link
Member

exezbcz commented Mar 5, 2024

draft and no progress

@exezbcz exezbcz closed this Mar 5, 2024
@exezbcz exezbcz mentioned this pull request Mar 5, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yangwao yangwao Awaiting requested review from yangwao yangwao was automatically assigned from kodadot/internal-dev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CSS Refactoring step 1
4 participants
@pbkompasz @kodabot @Jarsen136 @exezbcz