Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration NeoAudioPlayer and NeoNftCard from UI to main project #8286

Closed
shashkovdanil opened this issue Nov 28, 2023 · 10 comments · Fixed by #8550
Closed

Migration NeoAudioPlayer and NeoNftCard from UI to main project #8286

shashkovdanil opened this issue Nov 28, 2023 · 10 comments · Fixed by #8550

Comments

@shashkovdanil
Copy link
Contributor

shashkovdanil commented Nov 28, 2023

Is your feature request related to a problem?

NeoAudioPlayer is in libs/ui but in contains main logic

Describe the solution you would like

NeoAudioPlayer component should be in main project

Describe alternatives you have considered

--

Screenshots

No response

Are there opened related issues?

No response

@roiLeo
Copy link
Contributor

roiLeo commented Nov 29, 2023

Same as NeoNftCard & MediaItem this one should be outside UI package since it has some main logic inside.
Don't waste too much time trying to migrate it.

@shashkovdanil
Copy link
Contributor Author

@roiLeo hmm, could you give me a list of components that should be outside the UI kit, please?

@roiLeo
Copy link
Contributor

roiLeo commented Nov 29, 2023

@roiLeo hmm, could you give me a list of components that should be outside the UI kit, please?

The ones that have logic inside from now I only see MediaItem, NeoNftCard & NeoAudioPlayer

@shashkovdanil shashkovdanil changed the title Migration NeoAudioPlayer to tailwindcss Migration NeoAudioPlayer from UI to main project Dec 1, 2023
@shashkovdanil
Copy link
Contributor Author

👋

@kodabot
Copy link
Collaborator

kodabot commented Dec 1, 2023

ASSIGNED - @shashkovdanil 🔒 LOCKED -> Saturday, December 2nd 2023, 15:22:24 UTC -> 24 hours

@shashkovdanil
Copy link
Contributor Author

@roiLeo hey, we have situation:
NeoAudioPlayer is only used in AudioMedia.vue. AudioMedia.vue is part of libs/ui, what is the best way to do it? Move AudioMedia from libs/ui?

@roiLeo
Copy link
Contributor

roiLeo commented Dec 1, 2023

Let's try to keep them inside or else it will be a bigger refactor.
Note: I can see that NeoAudioPlayer use composable from Kodadot (not libs/ui), same goes for NeoWaveform component that use wavesurfer.js from Kodadot repo and that could be an issue too

@kodabot
Copy link
Collaborator

kodabot commented Dec 2, 2023

ASSIGNMENT EXPIRED - @shashkovdanil has been unassigned.

@shashkovdanil shashkovdanil changed the title Migration NeoAudioPlayer from UI to main project Migration NeoAudioPlayer and NeoNftCard from UI to main project Dec 13, 2023
@shashkovdanil
Copy link
Contributor Author

👋

@kodabot
Copy link
Collaborator

kodabot commented Dec 13, 2023

ALREADY UNASSIGNED - @shashkovdanil, you cannot be assigned twice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants