Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NeoSteps to tailwindcss #8524

Merged
merged 4 commits into from
Dec 18, 2023
Merged

Conversation

shashkovdanil
Copy link
Contributor

@shashkovdanil shashkovdanil commented Dec 10, 2023

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality

Optional

  • I've tested it at </ksm/collection>
  • I've tested PR on mobile
  • I've written unit tests 🧪
  • I've found edge cases

Did your issue had any of the "$" label on it?

  • Fill up your DOT address: Payout

Community participation

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

Copilot Summary

🤖[deprecated] Generated by Copilot at 032c5ed

Refactored the steps component to use Tailwind CSS utilities and custom properties, and updated the Tailwind configuration and scss files accordingly. This improves the UI code quality and design consistency.

🤖[deprecated] Generated by Copilot at 032c5ed

Oh we're the crew of the NeoSteps, and we sail the web with ease
We use Tailwind CSS to style our ship, and custom properties
We heave away on the tailwind.config.js, and we make it nice and clear
We set the colors and the opacities, for the UI we hold dear

@shashkovdanil shashkovdanil requested a review from a team as a code owner December 10, 2023 16:27
@shashkovdanil shashkovdanil requested review from vikiival and removed request for a team December 10, 2023 16:27
Copy link

netlify bot commented Dec 10, 2023

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit f1c85ea
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/657da642182bb30008284b75
😎 Deploy Preview https://deploy-preview-8524--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@kodabot
Copy link
Collaborator

kodabot commented Dec 10, 2023

WARNING @shashkovdanil PR for issue #8222 which isn't assigned to you. Please be warned that this PR may get rejected if there's another assignee for issue #8222

@shashkovdanil shashkovdanil mentioned this pull request Dec 10, 2023
33 tasks
Copy link
Contributor

reviewpad bot commented Dec 10, 2023

AI-Generated Summary: This pull request introduces changes from NeoSteps to tailwindcss. It involves the modification of three files: NeoSteps.scss, tailwind.scss, and tailwind.config.js.

The changes are majorly refactoring the NeoSteps.scss to use tailwind CSS utility classes instead of the previous SCSS variables and functions. New variables are added to the tailwind configuration and some existing ones have changed their values. In the tailwind.scss file, an extra variable "--steps-active-color" is added and the values of "--k-shade" are changed from hex value to RGB format. In the tailwind.config.js, a similar update in 'k-shade' and the addition of 'steps-active-color' were performed.

The aim of these changes is to transition the stylesheet architecture from traditional SCSS to a more modular, scalable and easier to maintain tailwind CSS architecture.

@reviewpad reviewpad bot added small Pull request is small waiting-for-review labels Dec 10, 2023
@prury prury requested review from roiLeo and daiagi December 11, 2023 13:26
Copy link
Contributor

@daiagi daiagi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the color of the line between steps is not same as in canary:
https://canary.kodadot.xyz/ahk/waifu

@prury prury added the S-changes-requested-🤞 PR is almost good to go, just some fine tunning label Dec 13, 2023
@shashkovdanil
Copy link
Contributor Author

the color of the line between steps is not same as in canary: https://canary.kodadot.xyz/ahk/waifu

ye, in the old version gradient didn't work. @exezbcz can you check please

@shashkovdanil
Copy link
Contributor Author

@prury fixed

@prury
Copy link
Member

prury commented Dec 15, 2023

Dark mode:
Deployed:
image

Canary:
image

Copy link

codeclimate bot commented Dec 16, 2023

Code Climate has analyzed commit f1c85ea and detected 0 issues on this pull request.

View more on Code Climate.

Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
1.1% Duplication on New Code

See analysis details on SonarCloud

@roiLeo roiLeo requested a review from daiagi December 18, 2023 11:06
@prury prury added S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked and removed S-changes-requested-🤞 PR is almost good to go, just some fine tunning labels Dec 18, 2023
@yangwao
Copy link
Member

yangwao commented Dec 18, 2023

thanks!
pay 20 usd

@yangwao yangwao merged commit fdc3ed1 into kodadot:main Dec 18, 2023
16 checks passed
@yangwao
Copy link
Member

yangwao commented Dec 18, 2023

😍 Perfect, I’ve sent the payout
💵 $20 @ 6.5 USD/DOT ~ 3.077 $DOT
🧗 16SpvdDgKNiQ3c53DxX7refnQcKUD3uRNim3Z1HBJLNGrtSP
🔗 0xcde718915600e849a3af52353defe3a7da277d7df6f5808e085f1e76b9733b9f

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Dec 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
paid pull-request has been paid S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked small Pull request is small waiting-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migration UI kit to tailwindcss
6 participants