Update inspector in v6.x #8832
Closed
Update inspector in v6.x #8832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Should help with nodejs#8034. PR-URL: nodejs#8528 Reviewed-By: bnoordhuis - Ben Noordhuis <[email protected]>
This test executes a simple debug session over the inspector protocol. PR-URL: nodejs#8429 Reviewed-By: ofrobots - Ali Ijaz Sheikh <[email protected]>
Ctor has to be added as memset to 0 is no longer an option, since the structure now has std::vector member. Attempt at fixing nodejs#8155 (so far I was not able to repro it) PR-URL: nodejs#8536 Reviewed-By: bnoordhuis - Ben Noordhuis <[email protected]>
Fixes: nodejs#8426 PR-URL: nodejs#8502 Reviewed-By: bnoordhuis - Ben Noordhuis <[email protected]>
Removes race condition when test relied on both sides of the socket to be closed on the same UV event loop iteration. Fixes: nodejs#8498 PR-URL: nodejs#8505 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Saúl Ibarra Corretgé <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-by: Fedor Indutny <[email protected]>
Embed the compressed and minified protocol.json from the bundled v8_inspector and make it available through the /json/protocol endpoint. Refs: nodejs/diagnostics#52 PR-URL: nodejs#7491 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
Stress tests uncovered 2 race conditions, when IO events happened during V8 entering event loop on pause or during Node.js shutdown. Fixes: nodejs#8669 PR-URL: nodejs#8672 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Aleksey Kozyatinskiy <[email protected]>
Remove obsolete build file entries. Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ilkka Myller <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> PR-URL: nodejs#8753
MylesBorins
added
v6.x
inspector
nodejs-github-bot
added
build
|
it looks like test inspector is failing on windows |
mscdex
removed
build
|
We will need to include #8835 to stop CI in windows from breaking |
PR-URL: nodejs#8835 Reviewed-By: Eugene Ostroukhov <[email protected]> Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
|
/cc @nodejs/platform-solaris can you take a look at the smartos failures here. |
|
I have relaunched the smartos build here: https://ci.nodejs.org/job/node-test-commit-smartos/4525/ |
|
SmartOS jobs are green on the re-run. |
|
landed in 4d41bd9...83ed508 |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j8 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
inspector
Description of change
This is a backport to v6.x of all outstanding inspector changes that do not rely on a Semver Major change.
/cc @nodejs/v8-inspector