Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

inspector: build file cleanup #8753

Closed
wants to merge 0 commits into from
Closed

inspector: build file cleanup #8753

wants to merge 0 commits into from

Conversation

eugeneo
Copy link
Contributor

@eugeneo eugeneo commented Sep 23, 2016

Checklist
  • make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

inspector: gyp file was updated.

Description of change

Remove obsolete build file entries.

@nodejs-github-bot nodejs-github-bot added the inspector Issues and PRs related to the V8 inspector protocol label Sep 23, 2016
@eugeneo eugeneo mentioned this pull request Sep 23, 2016
Closed
@mscdex mscdex added the build Issues and PRs related to build files or the CI. label Sep 23, 2016
jasnell
jasnell approved these changes Sep 23, 2016
View reviewed changes
Copy link
Member

@jasnell jasnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

imyller
imyller approved these changes Sep 24, 2016
View reviewed changes
Copy link
Member

@imyller imyller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

eugeneo pushed a commit that referenced this pull request Sep 26, 2016
inspector: build file cleanup
292040f 
Remove obsolete build file entries.

Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ilkka Myller <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
PR-URL: #8753
@eugeneo eugeneo closed this Sep 26, 2016
@eugeneo
Copy link
Contributor Author

eugeneo commented Sep 26, 2016

Landed as 292040f

MylesBorins pushed a commit to MylesBorins/node that referenced this pull request Sep 28, 2016
inspector: build file cleanup
7972c04 
Remove obsolete build file entries.

Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ilkka Myller <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
PR-URL: nodejs#8753
jasnell pushed a commit that referenced this pull request Sep 29, 2016
@jasnell
inspector: build file cleanup
c292355 
Remove obsolete build file entries.

Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ilkka Myller <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
PR-URL: #8753
MylesBorins pushed a commit that referenced this pull request Sep 30, 2016
inspector: build file cleanup
f4f9cf7 
Remove obsolete build file entries.

Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ilkka Myller <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
PR-URL: #8753
geek pushed a commit to geek/node that referenced this pull request Sep 30, 2016
@geek
inspector: build file cleanup
f991fb9 
Remove obsolete build file entries.

Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ilkka Myller <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
PR-URL: nodejs#8753
@eugeneo eugeneo deleted the remove_unused branch October 13, 2016 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjihrig cjihrig cjihrig approved these changes

@imyller imyller imyller approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
build Issues and PRs related to build files or the CI. inspector Issues and PRs related to the V8 inspector protocol
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@eugeneo @jasnell @imyller @cjihrig @mscdex @MylesBorins @nodejs-github-bot