Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v8 inspector - Runtime.evaluate doesn't work without a contextId #8426

Closed
roblourens opened this issue Sep 6, 2016 · 2 comments
Closed

v8 inspector - Runtime.evaluate doesn't work without a contextId #8426

roblourens opened this issue Sep 6, 2016 · 2 comments
Labels
inspector Issues and PRs related to the V8 inspector protocol

Comments

@roblourens
Copy link

Writing a client against the new v8 inspector debug protocol, and Node's behavior doesn't match the spec, but this does work in Chrome. Not sure if it should go here or V8.

According to this - https://chromedevtools.github.io/debugger-protocol-viewer/v8/Runtime/#method-evaluate - 'contextID' is optional, and should evaluate in the global context if not present. But if I don't include it, I get the error "Cannot find default execution context".

Request: {"id":4,"method":"Runtime.evaluate","params":{"expression":"123"}}
Response: {"error":{"code":-32000,"message":"Cannot find default execution context"},"id":4}

I'm on OSX, and see this on 6.4.0 and the latest v7 nightly.

@mscdex mscdex added the inspector Issues and PRs related to the V8 inspector protocol label Sep 6, 2016
@mscdex
Copy link
Contributor

mscdex commented Sep 6, 2016

/cc @nodejs/v8-inspector

@eugeneo
Copy link
Contributor

eugeneo commented Sep 8, 2016

I am planning to investigate it. Looks like it might be working in some cases, I will need to dig deeper.

MylesBorins pushed a commit to MylesBorins/node that referenced this issue Sep 28, 2016
Fixes: nodejs#8426
PR-URL: nodejs#8502
Reviewed-By: bnoordhuis - Ben Noordhuis <[email protected]>
MylesBorins pushed a commit that referenced this issue Sep 30, 2016
Fixes: #8426
PR-URL: #8502
Reviewed-By: bnoordhuis - Ben Noordhuis <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
inspector Issues and PRs related to the V8 inspector protocol
Projects
None yet
Development

No branches or pull requests

3 participants