Default context #8502
Closed
Default context #8502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
build
mscdex
removed
build
| function checkHttpResponse(port, path, callback) { | ||
| http.get({port, path}, function(r) { | ||
| let response = ''; | ||
| r. |
There was a problem hiding this comment.
Call r.setEncoding('utf8') first if you want string data in the data event listener. (And maybe rename the variable to res for clarity.)
There was a problem hiding this comment.
This change belongs to #8429 - I updated that PR
|
LGTM with a comment. Can you lowercase the status lines of the commit logs? |
|
Updated the status lines. Thanks for the review! |
|
I updated the CL, should now pass the test on Windows. |
|
CI after rebase: https://ci.nodejs.org/job/node-test-pull-request/4160/. |
|
Landed as efe4d19. |
ofrobots
pushed a commit
that referenced
this pull request
Sep 20, 2016
Fixes: #8426 PR-URL: #8502 Reviewed-By: bnoordhuis - Ben Noordhuis <[email protected]>
MylesBorins
pushed a commit
to MylesBorins/node
that referenced
this pull request
Sep 28, 2016
Fixes: nodejs#8426 PR-URL: nodejs#8502 Reviewed-By: bnoordhuis - Ben Noordhuis <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Sep 30, 2016
Fixes: #8426 PR-URL: #8502 Reviewed-By: bnoordhuis - Ben Noordhuis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
This change touches only the inspector integration.
Description of change
Inspector now returns a proper context when the default context is requested. This makes it possible to omit context ID from some requests.
Note that this PR is built on top of another PR (#8429) and adds a new test. I will roll the test change into that PR if this one is greenlighted first.
CC: @ofrobots