inspector: wait for both sides closing #8505
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
|
LGTM. Can you s/Wait/wait/ in the status line? |
Removes race condition when test relied on both sides of the socket to be closed on the same UV event loop iteration. Fixes: #8498
eugeneo
changed the title
|
Updated the status line. Thank you for the review. |
|
CI seems pretty happy. Infrastructure failure on one of the arm buildbots ("hudson.remoting.ChannelClosedException: channel is already closed".) |
|
LGTM. Tested locally, works! 👍 |
4 tasks
eugeneo
pushed a commit
that referenced
this pull request
Sep 22, 2016
Removes race condition when test relied on both sides of the socket to be closed on the same UV event loop iteration. Fixes: #8498 PR-URL: #8505 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Saúl Ibarra Corretgé <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-by: Fedor Indutny <[email protected]>
|
Landed as a67f11d |
MylesBorins
pushed a commit
to MylesBorins/node
that referenced
this pull request
Sep 28, 2016
Removes race condition when test relied on both sides of the socket to be closed on the same UV event loop iteration. Fixes: nodejs#8498 PR-URL: nodejs#8505 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Saúl Ibarra Corretgé <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-by: Fedor Indutny <[email protected]>
jasnell
pushed a commit
that referenced
this pull request
Sep 29, 2016
Removes race condition when test relied on both sides of the socket to be closed on the same UV event loop iteration. Fixes: #8498 PR-URL: #8505 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Saúl Ibarra Corretgé <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-by: Fedor Indutny <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Sep 30, 2016
Removes race condition when test relied on both sides of the socket to be closed on the same UV event loop iteration. Fixes: #8498 PR-URL: #8505 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Saúl Ibarra Corretgé <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-by: Fedor Indutny <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
Inspector test, no run-time changes.
Description of change
Removes race condition when test relied on both sides of the socket
to be closed on the same UV event loop iteration.
Fixes: #8498