inspector: fix tests on Windows #8528
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
c++
| @@ -154,11 +175,12 @@ static void fail_callback(uv_stream_t* stream, ssize_t nread, | |||
| } | |||
|
|
|||
| static void expect_nothing_on_client() { | |||
| int err = uv_read_start(reinterpret_cast<uv_stream_t *>(&client_socket), | |||
| buffer_alloc_cb, fail_callback); | |||
| uv_stream_t* stream = reinterpret_cast<uv_stream_t *>(&client_socket); | |||
There was a problem hiding this comment.
Can you write it as uv_stream_t* (no space) while you're here?
There was a problem hiding this comment.
Updated this location and several similar ones.
|
LGTM |
Should help with #8034
|
Thank you for the review. Commit was updated. |
|
The AIX build failure looked mysterious; relaunched: https://ci.nodejs.org/job/node-test-commit-aix/861/. |
|
CI is green enough. AIX rebuild was successful and the arm-fanned failure looks like a bot issue. |
|
Landed as 6f9157f. |
ofrobots
pushed a commit
that referenced
this pull request
Sep 16, 2016
Should help with #8034. PR-URL: #8528 Reviewed-By: bnoordhuis - Ben Noordhuis <[email protected]>
MylesBorins
pushed a commit
to MylesBorins/node
that referenced
this pull request
Sep 28, 2016
Should help with nodejs#8034. PR-URL: nodejs#8528 Reviewed-By: bnoordhuis - Ben Noordhuis <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Sep 30, 2016
Should help with #8034. PR-URL: #8528 Reviewed-By: bnoordhuis - Ben Noordhuis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
Inspector protocol implementation & test
Description of change
Should help with #8034