Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2022-05-XX, Version 16.16.0 'Gallium' (LTS) #43268

Closed
wants to merge 311 commits into from

Conversation

juanarbol
Copy link
Member

2022-05-XX, Version 16.16.0 'Gallium' (LTS), @TBD

Notable changes

  • (SEMVER-MINOR) crypto: make authTagLength optional for CC20P1305 (Tobias Nießen) #42427
  • (SEMVER-MINOR) esm: add chaining to loaders (Jacob Smith) #42623
  • (SEMVER-MINOR) fs: make params in writing methods optional (LiviaMedeiros) #42601
  • (SEMVER-MINOR) fs: add read(buffer[, options]) versions (LiviaMedeiros) #42768
  • (SEMVER-MINOR) perf_hooks: add PerformanceResourceTiming (RafaelGSS) #42725
  • (SEMVER-MINOR) src: add --openssl-legacy-provider option (Daniel Bevenius) #40478
  • (SEMVER-MINOR) stream: add writableAborted (Robert Nagy) #40802
  • (SEMVER-MINOR) tools: disable trap handler for Windows cross-compiler (Michaël Zasso) #40488
  • (SEMVER-MINOR) tools: update V8 gypfiles for 9.6 (Michaël Zasso) #40488
  • (SEMVER-MINOR) worker: add hasRef() to MessagePort (Darshan Sen) #42849

Commits

  • [d5f8b9e1dc] - assert: fix CallTracker wraps the function causes the length to be lost (OneNail) #42909
  • [c6a814c412] - assert: make assert.fail less affected by prototype tampering (Antoine du Hamel) #42918
  • [a408f87dfe] - async_hooks: avoid decrementing iterator after erase (Gabriel Bota) #42749
  • [4018c8d159] - async_hooks: remove destroyed symbol on Promises (Gerhard Stöbich) #42402
  • [9b75c7b39e] - benchmark: fix misc/startup failure (Antoine du Hamel) #42746
  • [3022fa22e9] - bootstrap: use the isolate snapshot in workers (Joyee Cheung) #42702
  • [27bed94deb] - bootstrap: move embedded snapshot to SnapshotBuilder (Joyee Cheung) #42702
  • [5315dd25e0] - bootstrap: reset process._exit and process.exitCode in pre-execution (Joyee Cheung) #42466
  • [cb5ccb0cfc] - bootstrap: run inspector and event loop in snapshot builder (Joyee Cheung) #42466
  • [542f5e7fe6] - bootstrap: make I/O streams work with user-land snapshot (Joyee Cheung) #42466
  • [89701675b8] - bootstrap: refresh options in pre-execution (Joyee Cheung) #42466
  • [a12c4070e2] - bootstrap: use SnapshotData to pass snapshot data around (Joyee Cheung) #42360
  • [c6d85034e1] - buffer: fix atob input validation (Austin Kelleher) #42662
  • [e9f3e63bce] - buffer: improve Blob constructor error message when passing a string (Xuguang Mei) #42338
  • [7b77944557] - buffer: fix atob input validation (Antoine du Hamel) #42539
  • [b7d5869eff] - build: set ASAN workaround (Richard Lau) #43085
  • [6e59651e0a] - build: disable windows-2022 temporarily (Jiawen Geng) #43093
  • [afbcc79739] - build: fix various shared library build issues (William Marlow) #41850
  • [e18041358c] - build: fix indeterminacy of icu_locales value (Sergey Nazaryev) #42865
  • [c3fc44bd86] - build: improve reliability of find_python.cmd script (Luigi Pinca) #42810
  • [6190552be7] - build: fix format-cpp (Darshan Sen) #42764
  • [4353b7a881] - build: improve the format-cpp error message (Darshan Sen) #42765
  • [1d5d18ae11] - build: run clang-format on CI (Darshan Sen) #42681
  • [512dba6cdf] - build: remove precompiled header and debug information for host builds (Niyas Sait) #42538
  • [59edb3e785] - build: windows/arm64 native compilation support (Niyas Sait) #42408
  • [007db8bd12] - build: consolidate JS and md linting GitHub Actions (Rich Trott) #42572
  • [5fe11b7809] - build: set stale action back to running nightly (Michael Dawson) #42549
  • [ce5e48439b] - build: add --node-snapshot-main configure option (Joyee Cheung) #42466
  • [fe9f758453] - build: bump actions/checkout (Eliaz Bobadilla) #42460
  • [687b853806] - child_process: add env contents types in JSDoc (Rich Trott) #42494
  • [c4ff510ede] - console: fix console.dir crash on a revoked proxy (Daeyeon Jeong) #43100
  • [6a479d8221] - crypto: adjust minimum length in generateKey('hmac', ...) (LiviaMedeiros) #42944
  • [d2e6701726] - crypto: clean up parameter validation in HKDF (Tobias Nießen) #42924
  • [1884f526cd] - crypto: validate this in all webcrypto methods and getters (Filip Skokan) #42815
  • [fd3a8bfe8b] - crypto: do not add undefined hash in webcrypto normalizeAlgorithm (Filip Skokan) #42559
  • [5e6b8decc8] - crypto: cleanup webcrypto jwk code (Filip Skokan) #42562
  • [15e0688583] - crypto: fix webcrypto derive key lengths (Filip Skokan) #42542
  • [b863a27da7] - (SEMVER-MINOR) crypto: make authTagLength optional for CC20P1305 (Tobias Nießen) #42427
  • [b298291af8] - crypto: improve prime size argument validation (Tobias Nießen) #42234
  • [1702a80737] - debugger: throw a more useful error when the frame is missing (Kohei Ueno) #42776
  • [1247809c57] - debugger: fix inconsistent inspector output of exec new Map() (Kohei Ueno) #42423
  • [1c8fa4dbbf] - deps: V8: cherry-pick 3ebf2052a1b2 (Liu Yu) #43147
  • [b714b5d59b] - deps: upgrade npm to 8.11.0 (npm team) #43210
  • [e69fc6f599] - deps: upgrade npm to 8.10.0 (npm team) #43061
  • [46d9308872] - deps: update undici to 5.2.0 (Node.js GitHub Bot) #43059
  • [973cd67e3b] - deps: fix llhttp version number (Michael Dawson) #43029
  • [d9156c9124] - deps: upgrade npm to 8.9.0 (npm team) #42968
  • [0fd9371c18] - deps: update undici to 5.1.1 (Michaël Zasso) #42939
  • [319f62bacd] - deps: update Acorn to v8.7.0 (Michaël Zasso) #42667
  • [41303d74c1] - deps: update ICU to 71.1 (Michaël Zasso) #42655
  • [1d1ca205b1] - deps: V8: cherry-pick cc9a8a37445e (Gus Caplan) #41823
  • [768e1a2315] - doc: use serial comma in process docs (Tobias Nießen) #43179
  • [026ae9dba2] - doc: improved parallel specification (mawaregetsuka) #42679
  • [d40733d256] - doc: improve callback params for fs.mkdir (Daeyeon Jeong) #43016
  • [d575229bb6] - doc: add release key for RafaelGSS (Rafael Gonzaga) #43131
  • [66cb8180e4] - doc: use serial comma in assert docs (Tobias Nießen) #43154
  • [3f799c4a29] - doc: fix errors in Performance hooks doc (OneNail) #43152
  • [ef037f3db6] - doc: use serial comma in dns docs (Tobias Nießen) #43145
  • [84b698d2ab] - doc: use ASCII apostrophes consistently (Tobias Nießen) #43114
  • [745d9a2428] - doc: add strategic initiative for shadow realm (Chengzhong Wu) #43037
  • [ac9cbba86b] - doc: use serial comma in fs docs (Tobias Nießen) #43104
  • [ec10ae7f39] - doc: use serial comma in events docs (Tobias Nießen) #43113
  • [d876088b9f] - doc: use serial comma in modules docs (Tobias Nießen) #43103
  • [084a7606e7] - doc: use serial comma in util docs (Tobias Nießen) #43063
  • [06fdbcd721] - doc: remove git:// protocol, adjust nits in onboarding.md (LiviaMedeiros) #43045
  • [1d973f0806] - doc: add maintaining info for shared libary option (Michael Dawson) #42517
  • [671f85eaa9] - doc: add detail for how to update llhttp (Michael Dawson) #43028
  • [549bce1807] - doc: use serial comma in buffer docs (Tobias Nießen) #43048
  • [615ad8c0bf] - doc: use consistent method symbol (Paolo Insogna) #42974
  • [5356d2b452] - doc: add Rafael to the security steward for NearForm (Matteo Collina) #42966
  • [ccfa88cbda] - doc: mark some node-api functions as experimental (NickNaso) #42987
  • [4509fda932] - doc: add LiviaMedeiros to collaborators (LiviaMedeiros) #43039
  • [5f0006a87f] - doc: use serial comma in http docs (Tobias Nießen) #43026
  • [53364e9091] - doc: add the preferred name for @himself65 (Himself65) #43024
  • [b3b68823c0] - doc: add release key for Juan Arboleda (Juan José) #42961
  • [991a949af6] - doc: rename N-API to Node-API in test/README.md (Daeyeon Jeong) #42946
  • [0bc73da41d] - doc: use serial comma in tls docs (Tobias Nießen) #43001
  • [54e4f05cf8] - doc: improve commit message example for releases (Juan José) #42954
  • [23452bc75d] - doc: use serial comma in cluster docs (Tobias Nießen) #42989
  • [16df0388c2] - doc: fix errors in Web Streams doc (OneNail) #42862
  • [6328b2bfc5] - doc: fix examples in cluster.md (OneNail) #42889
  • [f00f18393f] - doc: add additional step to security release process (Michael Dawson) #42916
  • [f120658047] - doc: add section regarding property definition in primordials.md (Antoine du Hamel) #42921
  • [10f296f50d] - doc: clarify some default values in fs.md (LiviaMedeiros) #42892
  • [374c278716] - doc: reword "test directory" (LiviaMedeiros) #42817
  • [7d8f1438e0] - doc: remove legacy -J test.py option from BUILDING.md (LiviaMedeiros) #42817
  • [56670f0b32] - doc: http2.createServer options as optional (Daeyeon Jeong) #42832
  • [9af67af460] - doc: record March 2022 security release steward (Richard Lau) #42876
  • [e78bcb7d1b] - doc: initial version of security-model-strategy.md (Michael Dawson) #42709
  • [20acb4819f] - doc: clarify guide on testing internal errors (LiviaMedeiros) #42813
  • [bc0d8a37cc] - doc: fix markdown formatting in primordials.md (Tobias Nießen) #42877
  • [6376618f07] - doc: add primordials guidelines (Antoine du Hamel) #38635
  • [2444d5cadb] - doc: elevate node-clinic diagnostic tier (RafaelGSS) #42802
  • [67610231ac] - doc: update WebAssembly strategy with Wasm Web API (Tobias Nießen) #42836
  • [0958df9dcd] - doc: order vm.Module linker arguments correctly (Simen Bekkhus) #42797
  • [c02f0446e6] - doc: add @kuriyosh to collaborators (Yoshiki Kurihara) #42824
  • [1b908ad14c] - doc: add maintaining-webassembly.md (Michael Dawson) #42660
  • [ef23564250] - doc: delete heapdump from diagnostic tooling support tiers (Tony Gorez) #42783
  • [e53a9252bd] - doc: fix example in assert.md (LiviaMedeiros) #42786
  • [3591ec758b] - doc: fix version history for Loaders API (Antoine du Hamel) #42778
  • [0cb1bca3ab] - doc: add node: prefix for all core modules (Antoine du Hamel) #42752
  • [e63827124d] - doc: clarify core modules that can be loaded without a prefix (Antoine du Hamel) #42753
  • [9e20318a57] - doc: consolidate use of multiple-byte units (Antoine du Hamel) #42587
  • [cc90d1161d] - doc: add documentation for inherited methods (Luigi Pinca) #42691
  • [2d8dbe8f32] - doc: close tag in n-api.md (LiviaMedeiros) #42751
  • [b5d6dd5e1a] - doc: copyedit http.OutgoingMessage documentation (Luigi Pinca) #42733
  • [3cd3a6af8b] - doc: improve fragment (:target) anchors behavior on HTML version (Antoine du Hamel) #42739
  • [a8d16eb05c] - doc: fix added: info for outgoingMessage.writable* (Luigi Pinca) #42737
  • [eb6e140f9f] - doc: delete mdb_v8 from diagnostic tooling support tiers (Tony Gorez) #42626
  • [02d8c3bc9c] - doc: document the 'close' and 'finish' events (Luigi Pinca) #42704
  • [8ae240ec92] - doc: fix added: info for outgoingMessage.{,un}cork() (Luigi Pinca) #42711
  • [0c64093dc4] - doc: revise data imports and node: imports sections (Rich Trott) #42734
  • [7c700eb2f7] - doc: fix ESM JSON/data URL import example (Rich Trott) #42728
  • [444754bbaa] - doc: improve doc for http.ServerResponse inheritance (Luigi Pinca) #42693
  • [0654d3feee] - doc: add RafaelGSS to collaborators (RafaelGSS) #42718
  • [58d737ccb9] - doc: add NodeEdKeyGenParams to CryptoKey.algorithm (Tobias Nießen) #42629
  • [d4bec32ea3] - doc: fix the example for embedders (Momtchil Momtchev) #42671
  • [32a87dfa7e] - doc: change AES-GCM IV recommendation in WebCrypto (Tobias Nießen) #42611
  • [ab1939bf5c] - doc: fix added: info for some methods (Luigi Pinca) #42661
  • [1878a25694] - doc: remove unneeded new in Buffer example (Niklas Mischkulnig) #42682
  • [c810ff2631] - doc: mark worker.id as integer in cluster docs (Tobias Nießen) #42684
  • [3614d450cb] - doc: recommend fh.createWriteStream for fsPromises methods (Antoine du Hamel) #42653
  • [a47092f138] - doc: fix outgoingMessage.removeHeader() signature (Luigi Pinca) #42652
  • [5530d3fb7d] - doc: mark tlsSocket.authorized as boolean property (Tobias Nießen) #42647
  • [9e39a84f88] - doc: add missing punctuation in Web Streams doc (Tobias Nießen) #42672
  • [9caffa16f7] - doc: add missing article in session ticket section (Tobias Nießen) #42632
  • [802d088834] - doc: link to dynamic import function (Tobias Nießen) #42634
  • [77d6bfdbc6] - doc: add note about header values encoding (Paolo Insogna) #42624
  • [5bc7d7fd36] - doc: add missing word in rootCertificates section (Tobias Nießen) #42633
  • [d6e3056e86] - doc: add history entries for DEP0162 on fs.md (Antoine du Hamel) #42608
  • [5aa46a2d2f] - doc: fix brackets position (LiviaMedeiros) #42649
  • [7ed40dcbbf] - doc: copyedit corepack.md (Rich Trott) #42620
  • [e2a0954c94] - doc: delete chakra tt from diagnostic tooling support tiers (Tony Gorez) #42627
  • [3e156af5af] - doc: simplify Http2Stream encoding text (Rich Trott) #42597
  • [071d34af6a] - doc: remove obsolete stream API selection text (Rich Trott) #42586
  • [55567cf3c3] - doc: remove faulty justification for 128-bit AES (Tobias Nießen) #42578
  • [6d2d2b5550] - doc: fix documentation of FileHandle.prototype.appendFile (Antoine du Hamel) #42588
  • [0704e3b1b5] - doc: change "OCSP Request" to "OCSP request" (Tobias Nießen) #42582
  • [1b8cc7bb04] - doc: aes webcrypto unwrap is not a node-specific extensions (Filip Skokan) #42561
  • [6dd07726b9] - doc: simplify recommendations in process.md (Rich Trott) #42556
  • [5a15cb81b2] - doc: clarify recommendations in stream.md (Rich Trott) #42555
  • [91a11775f6] - doc: simplify recommendation in webcrypto.md (Rich Trott) #42554
  • [84be8dff8d] - doc: update DEP0102 text (Rich Trott) #42553
  • [61ea408ce0] - doc: add introduction sentence for CJS (Antoine du Hamel) #42491
  • [124cb46b84] - doc: add @meixg to collaborators (Xuguang Mei) #42576
  • [073ad0271b] - doc: consolidate CI sections (Rich Trott) #42534
  • [f2dc7c84d6] - doc: document breaking change in http.IncomingMessage 'close' event (Paolo Insogna) #42521
  • [f83fc62be1] - doc: remove extraneous comma (Rich Trott) #42548
  • [868842fe15] - doc: guide towards x509.fingerprint256 (Tobias Nießen) #42516
  • [2c70f14910] - doc: fix internal link in collaborator-guide.md (Daeyeon Jeong) #42551
  • [7517c6eb25] - doc: add suggestion for OpenSSL only sec releases (Michael Dawson) #42456
  • [0684a065d6] - doc: fix comment text in async_hooks example (Rich Trott) #42499
  • [b9eee7306c] - doc: add stability class to legacy status description (Daniel Roe) #42525
  • [54fc810af2] - doc: suggest checkHost in checkServerIdentity docs (Tobias Nießen) #42495
  • [ec5443cb7b] - doc: update security release onboarding (Joe Sepi) #42333
  • [1aff9fa9fa] - doc: remove comma splice in events.md (Rich Trott) #42484
  • [aecc77baf3] - doc: clarify napi_finalize behavior (Alba Mendez) #42461
  • [a45f088d28] - doc: expand history for conditional exports changes in v12 (Greg Poole) #42339
  • [80a387b81d] - doc: change comma-splice to two sentences (Rich Trott) #42455
  • [67c7ceacf2] - doc: add link to section (Rich Trott) #42428
  • [5b241ee5f7] - doc: fix typo in async_context.md (Anupama Codippily) #42444
  • [9b71043e90] - doc: add trace_gc to diagnostic tooling support document (Tony Gorez) #42346
  • [54720f59ce] - doc: make header smaller and dropdown click-driven when JS is on (Paolo Insogna) #42165
  • [2ce6e70128] - doc: standardize typography for _semantic versioning_ (Rich Trott) #42401
  • [ad81dad567] - doc: unify import order in CCM example (Tobias Nießen) #42394
  • [a197ad9d06] - doc: update property name (Rich Trott) #42398
  • [b3ea8f1192] - doc,readline: add missing node protocol in example (Mestery) #41560
  • [2b807543ce] - doc,test: clarify ChaCha20-Poly1305 usage (Tobias Nießen) #42323
  • [56ffc07ffb] - errors,console: refactor to use ES2021 syntax (小菜) #42872
  • [9e815c56fb] - errors,vm: update error and use cause (Gus Caplan) #42820
  • [3abaf4dc4d] - (SEMVER-MINOR) esm: add chaining to loaders (Jacob Smith) #42623
  • [c6f4a6f2f8] - esm: fix imports from non-file module (Antoine du Hamel) #42881
  • [c7fb9cbc09] - esm: graduate top-level-await to stable (Antoine du Hamel) #42875
  • [89eac9772a] - esm: emit experimental warnings in common place (Jacob Smith) #42314
  • [b8f102c363] - fs: add trailing commas (LiviaMedeiros) #43127
  • [c3ae514980] - (SEMVER-MINOR) fs: make params in writing methods optional (LiviaMedeiros) #42601
  • [cdda73576e] - fs: remove unnecessary ?? operator (Morgan Roderick) #43073
  • [17c5ede56e] - (SEMVER-MINOR) fs: add read(buffer[, options]) versions (LiviaMedeiros) #42768
  • [c4b16101a5] - fs: fix mkdirSync so ENOSPC is correctly reported (Santiago Gimeno) #42811
  • [a45aabebb2] - fs: fix write methods param validation and docs (LiviaMedeiros) #41677
  • [9c821c3dff] - http: document that ClientRequest inherits from OutgoingMessage (K.C.Ashish Kumar) #42642
  • [5eb75871e4] - http2: compat support for array headers (OneNail) #42901
  • [27bcf3378e] - lib: refactor validateInt32 and validateUint32 (mawaregetsuka) #43071
  • [8f96d73706] - lib: prepare files for no-var lint rule (Rich Trott) #42573
  • [e2a9374d19] - lib: source maps filter null prefix (Fabian Cook) #42522
  • [7127c3c0f4] - lib: improve the coverage of the validator (mawaregetsuka) #42443
  • [21cf1ddee8] - lib: update JSDoc for linting (Rich Trott) #42489
  • [1f2d23c574] - meta: add mailmap entry for legendecas (Chengzhong Wu) #43156
  • [4b76af14e8] - meta: add mailmap entry for npm team (Luigi Pinca) #43143
  • [236d1391fc] - meta: add mailmap entry for Morgan Roderick (Luigi Pinca) #43144
  • [b56a91ae89] - meta: add mailmap entry for ShogunPanda (Paolo Insogna) #43094
  • [6b56ec7c67] - meta: update .mailmap for recent README name change (Rich Trott) #43027
  • [0aeccc258b] - meta: update AUTHORS (Node.js GitHub Bot) #43004
  • [eaf705283d] - meta: move one or more collaborators to emeritus (Node.js GitHub Bot) #42937
  • [d9ed13a75a] - meta: update AUTHORS (Node.js GitHub Bot) #42848
  • [e20811d054] - meta: move one or more collaborators to emeritus (Node.js GitHub Bot) #42769
  • [2ddfa0e80b] - meta: update AUTHORS (Node.js GitHub Bot) #42760
  • [077bebc370] - meta: move mmarchini to emeritus (mary marchini) #42750
  • [c3b3ee4178] - meta: update AUTHORS (Node.js GitHub Bot) #42677
  • [47eb8f0f95] - meta: move one or more collaborators to emeritus (Node.js GitHub Bot) #42599
  • [ab01eaf0f0] - meta: update .mailmap and AUTHORS (Rich Trott) #42602
  • [eaae319e4a] - meta: move one or more collaborators to emeritus (Node.js GitHub Bot) #42500
  • [eb33629b04] - meta: update AUTHORS (Node.js GitHub Bot) #42585
  • [3684fd1b39] - meta: update AUTHORS (Node.js GitHub Bot) #42488
  • [404208777d] - net,dns: trace tcp connection and dns by perf_hooks (theanarkh) #42390
  • [e6ab565e80] - node-api: fix napi_get_all_property_names (Vladimir Morozov) #42463
  • [c07200ce7f] - node-api: format Node-API related code (Vladimir Morozov) #42396
  • [2cf6a0540a] - os: avoid unnecessary usage of var (Mohammed Keyvanzadeh) #42563
  • [d2d0f6f143] - (SEMVER-MINOR) perf_hooks: add PerformanceResourceTiming (RafaelGSS) #42725
  • [8a29296652] - perf_hooks: return different functions in timerify (Himself65) #42854
  • [55bbdd7e98] - (SEMVER-MINOR) src: add --openssl-legacy-provider option (Daniel Bevenius) #40478
  • [115a04ff87] - src: reuse GetServerName (Tobias Nießen) #43168
  • [4823c5e42b] - src: fix static analysis warning and use smart ptr (Tobias Nießen) #43117
  • [c4833ff652] - src: remove SecureContext::operator* (Tobias Nießen) #43121
  • [758c02ec5d] - src: replace TraceEventScope with sync events (Chengzhong Wu) #42977
  • [8593a336d6] - src: delete AllocatedBuffer (Darshan Sen) #43008
  • [eecf820e39] - src: remove unnecessary comment (Kohei Ueno) #42952
  • [e3a4d40c2a] - src: always signal V8 for intercepted properties (Michaël Zasso) #42963
  • [3c1d169839] - src: fix memory leak for v8.serialize (liuxingbaoyu) #42695
  • [a6bceaec4d] - src: turn SSL_CTX_new CHECK/segfault into JS exception (Anna Henningsen) #42799
  • [1dcbf73552] - src: define fs.constants.S_IWUSR & S_IRUSR for Win (Liviu Ionescu) #42757
  • [f41ea761ca] - src: use node: prefix in example (Antoine du Hamel) #42794
  • [45f7bd09eb] - src: large page attributing an id on Linux (David CARLIER) #42644
  • [189270d97d] - src: fix coverity report (Michael Dawson) #42663
  • [d5a7787f73] - src: fix alphabetically sorted binding list (Tobias Nießen) #42687
  • [b3016c7dd0] - src: add proper mutexes for accessing FIPS state (Anna Henningsen) #42278
  • [824a1917a0] - src: fix typo in InspectorIoDelegate constructor (Kohei Ueno) #42520
  • [81ef4cca89] - src: remove unnecessary static qualifier in crypto_dh.cc (Darshan Sen) #42492
  • [592aec3279] - src: address 3 useless call coverity warnings (Michael Dawson) #42426
  • [4f186a5d94] - src: properly report exceptions from AddressToJS() (Darshan Sen) #42054
  • [67ea8e2d5d] - src: suppress false coverity warning (Michael Dawson) #42284
  • [0cd6bfae74] - src: refactor IsSupportedAuthenticatedMode (Tobias Nießen) #42368
  • [70c4f39129] - src,crypto: remove uses of AllocatedBuffer from crypto_rsa.cc (Darshan Sen) #42852
  • [91e804f7e2] - src,crypto: remove uses of AllocatedBuffer from crypto_ec.cc (Darshan Sen) #42766
  • [2e3a21f2db] - src,crypto: remove uses of AllocatedBuffer from crypto_tls.cc (Darshan Sen) #42589
  • [139a8eb177] - src,crypto: handle empty maybe correctly in crypto_dh.cc (Darshan Sen) #42492
  • [6ee9587e6e] - src,crypto: remove uses of AllocatedBuffer from crypto_dh.cc (Darshan Sen) #42492
  • [542744bb6e] - src,inspector: fix empty MaybeLocal crash (Darshan Sen) #42409
  • [f6b10cf4bc] - src,inspector: fix empty MaybeLocal crash (Darshan Sen) #42409
  • [1808572414] - (SEMVER-MINOR) stream: add writableAborted (Robert Nagy) #40802
  • [4c4cd31846] - test: improve readline/emitKeypressEvents.js coverage (OneNail) #42908
  • [80df97c126] - test: fix dangerous .map in test/parallel/test-http-set-trailers.js (LiviaMedeiros) #43087
  • [5e3c72adb5] - test: reduce flakiness of test-fs-read-position-validation.mjs (LiviaMedeiros) #42999
  • [aaa247cc83] - test: rename handlewrap.hasref tests (Daeyeon Jeong) #42754
  • [38a1060e66] - test: improve observable ICU behaviour coverage (LiviaMedeiros) #42683
  • [abafda8e95] - test: validate webstream encoder/decoder inspector (Yoshiki Kurihara) #42747
  • [db1d714689] - test: usemustSucceed instead of mustCall with assert.ifError (MURAKAMI Masahiko) #42806
  • [8bb7f565cf] - test: improve lib/internal/webstreams/readablestream.js coverage (MURAKAMI Masahiko) #42823
  • [51a6afafdc] - test: add test for position validation in fs.read() and fs.readSync() (LiviaMedeiros) #42837
  • [fb8a23a69a] - test: add tests for extracting function name (Kohei Ueno) #42399
  • [4e8c58cd49] - test: simplify test-gc-{http-client,net}-* (Luigi Pinca) #42782
  • [eca030d32a] - test: check ecdsa psychic signature (Filip Skokan) #42863
  • [6f0edeb657] - test: fix port in net-perf_hooks (LiviaMedeiros) #42761
  • [98db2e7643] - test: skip test that cannot pass under --node-builtin-modules-path (Geoffrey Booth) #42834
  • [f302bc13db] - test: fix flaky HTTP server tests (Tobias Nießen) #42846
  • [30a93db72f] - test: fix calculations in test-worker-resource-limits (Joyee Cheung) #42702
  • [9730482960] - test: remove the legacy url parser function (Kohei Ueno) #42656
  • [0ef18fe189] - test: improve test coverage of internal/blob (Yoshiki Kurihara) #41513
  • [35b1f79083] - test: delete test/pummel/test-repl-empty-maybelocal-crash.js (Darshan Sen) #42720
  • [abb15f5be9] - test: improve internal/url.js coverage (Yoshiki Kurihara) #42650
  • [8a19abcb0b] - test: only skip slow tests on Raspberry Pi devices (Richard Lau) #42645
  • [567b96a9c7] - test: allow numeric string for lookupService test (Daeyeon Jeong) #42596
  • [09052f319e] - test: remove an unnecessary undefined in wpt (Khaidi Chu) #41470
  • [50e701defb] - test: simplify test-http-write-callbacks.js (Tobias Nießen) #42628
  • [0ad7f4b4b1] - test: remove hack for atob and btoa WPT tests (Antoine du Hamel) #42540
  • [1fd13403e4] - test: pass data into napi_create_external (Joyee Cheung) #42532
  • [7bf8117ee5] - test: improve FileHandle.prototype.write coverage (Antoine du Hamel) #42541
  • [846acac5a2] - test: add test for exception handlings in debugger (Kohei Ueno) #42327
  • [dc69ce482e] - test: fix typo in common/wpt.js (Ikko Ashimine) #42567
  • [dbb865fbc8] - test: fix typos in test/parallel (Daeyeon Jeong) #42502
  • [90ecc9baa2] - test: add trace-gc flag test (Tony Gorez) #42471
  • [b96cfde1ef] - test: improve worker_threads coverage (Erick Wendel) #41818
  • [a195b4f92e] - test,fs: add fs.rm() tests for .git directories (Darshan Sen) #42410
  • [520e5d9eeb] - (SEMVER-MINOR) tools: disable trap handler for Windows cross-compiler (Michaël Zasso) #40488
  • [776d11a536] - (SEMVER-MINOR) tools: update V8 gypfiles for 9.6 (Michaël Zasso) #40488
  • [27b646ea8e] - tools: refactor build-addons.js to ESM (Feng Yu) #43099
  • [c3f0e6dffe] - tools: update lint-md-dependencies to [email protected] (Node.js GitHub Bot) #43172
  • [63045bff26] - tools: update eslint to 8.16.0 (Node.js GitHub Bot) #43174
  • [bc8118d976] - tools: refactor update-authors.js to ESM (Feng Yu) #43098
  • [43cde0185f] - tools: update lint-md-dependencies to [email protected] (Node.js GitHub Bot) #43107
  • [bc35640158] - tools: update eslint to 8.15.0 (Node.js GitHub Bot) #43005
  • [e810ae02a0] - tools: refactor lint-sh.js to esm module (Feng Yu) #42942
  • [362035f3dd] - tools: update lint-md-dependencies (Node.js GitHub Bot) #43003
  • [1612c35a35] - tools: update lint-md-dependencies (Node.js GitHub Bot) #42932
  • [ecb4d0bf46] - tools: bump jsdoccomment from 0.22.1 to 0.29.0 (Rich Trott) #42857
  • [ff9b688e20] - tools: update eslint to 8.14.0 (Node.js GitHub Bot) #42845
  • [9cebb09f29] - tools: update doc to [email protected] (Node.js GitHub Bot) #42758
  • [cab329b380] - tools: update lint-md-dependencies (Node.js GitHub Bot) #42759
  • [2307371f4c] - tools: lint osx shell scripts (LiviaMedeiros) #42712
  • [a7a59acb72] - tools: update clang-format 1.6.0 to 1.7.0 (Rich Trott) #42724
  • [f269e15266] - tools: update clang-format from 1.2.3 to 1.6.0 (Rich Trott) #42685
  • [2a50964f12] - tools: update eslint to 8.13.0 (Node.js GitHub Bot) #42678
  • [93c94020cd] - tools: update gyp-next to v0.12.1 (Michaël Zasso) #42625
  • [7fab8012f8] - tools: update lint-md-dependencies to @rollup/[email protected] (Node.js GitHub Bot) #42584
  • [a2e858fdfd] - tools: enable no-var ESLint rule for lib (Rich Trott) #42573
  • [321539c507] - tools: fixed bug causing JSON format to be broken (mawaregetsuka) #41565
  • [b238396d17] - tools: update GHA actions version (Antoine du Hamel) #42498
  • [bd2d437b28] - tools: update eslint to 8.12.0 (Node.js GitHub Bot) #42489
  • [3c152363b5] - tools: update lint-md-dependencies to [email protected] (Node.js GitHub Bot) #42487
  • [ad7f3bc979] - tools: refloat 7 Node.js patches to cpplint.py (Rich Trott) #42416
  • [1f850c0a2f] - tools: bump cpplint to 1.6.0 (Rich Trott) #42416
  • [4122a8dd18] - tools: fix skip PR if CI is still running (Xuguang Mei) #42377
  • [208a5eada4] - tools: make update-undici script executable (Michaël Zasso) #42406
  • [6de289b917] - typings: fix os.cpus invalid return type (Himself65) #43006
  • [8b92e59eee] - v8: export more fields in getHeapStatistics (theanarkh) #42784
  • [626fcb223b] - wasi: remove unecessary null check (Michael Dawson) #42819
  • [835f0a5610] - worker: fix heap snapshot crash on exit (Chengzhong Wu) #43123
  • [e62d8e6f31] - worker: fix stream racing with terminate (Keyhan Vakil) #42874
  • [e0807fd371] - (SEMVER-MINOR) worker: add hasRef() to MessagePort (Darshan Sen) #42849
  • [2fe8a79ea0] - worker: add hasRef() to the handle object (Darshan Sen) #42756

eltociear and others added 30 commits May 30, 2022 19:54
thw -> the

PR-URL: nodejs#42567
Reviewed-By: Zeyu Yang <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Akhil Marsonya <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
PR-URL: nodejs#42576
Fixes: nodejs#42419
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Qingyu Deng <[email protected]>
PR-URL: nodejs#42542
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
PR-URL: nodejs#42491
Reviewed-By: Geoffrey Booth <[email protected]>
Reviewed-By: Akhil Marsonya <[email protected]>
Fixes: nodejs#42530

PR-URL: nodejs#42539
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Akhil Marsonya <[email protected]>
PR-URL: nodejs#42327
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Since v8 10.1 v8::External::New DCHECKs that the data passed
into it cannot be a nullptr because that's not serializable
as external references. This updates the test to pass a
dummy data pointer to the call - which does not matter for the
test since we only care about whether the finalizer is
called.

Refs: https://chromium-review.googlesource.com/c/v8/v8/+/3513234

PR-URL: nodejs#42532
Refs: nodejs#42115
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
PR-URL: nodejs#42443
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: James M Snell <[email protected]>
PR-URL: nodejs#42553
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Tierney Cyren <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Akhil Marsonya <[email protected]>
PR-URL: nodejs#42554
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Tierney Cyren <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Akhil Marsonya <[email protected]>
PR-URL: nodejs#42555
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Tierney Cyren <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Akhil Marsonya <[email protected]>
PR-URL: nodejs#42585
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Remove recommendation that has no explanation. Make the other
recommendation less wordy.

PR-URL: nodejs#42556
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Akhil Marsonya <[email protected]>
PR-URL: nodejs#42540
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Khaidi Chu <[email protected]>
Reviewed-By: Mestery <[email protected]>
PR-URL: nodejs#42562
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Zeyu Yang <[email protected]>
Reviewed-By: Akhil Marsonya <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
The FIPS state handling and OpenSSL initialization code makes
accesses to global OpenSSL state without any protection against
parallel modifications from multiple threads.

This commit adds such protections.

PR-URL: nodejs#42278
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
PR-URL: nodejs#42582
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Mestery <[email protected]>
I manually ran over  the last number of weeks so that
we did not mark all of the stale isssues all at once.
We are not caught up so we can go to running daily.

Signed-off-by: Michael Dawson <[email protected]>

PR-URL: nodejs#42549
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Tierney Cyren <[email protected]>
Reviewed-By: James M Snell <[email protected]>
PR-URL: nodejs#42500
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
The `var` keyword is known to be problematic and is not needed here,
so better to use the `let` keyword for variable declarations.

PR-URL: nodejs#42563
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Akhil Marsonya <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Fixes: nodejs#42417

PR-URL: nodejs#42522
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: James M Snell <[email protected]>
PR-URL: nodejs#42588
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Mestery <[email protected]>
This sentence implies that AES-128 is preferred over AES-256 because
of a related-key attack from 2009. However, that attack by Alex
Biryukov, Orr Dunkelman, Nathan Keller, Dmitry Khovratovich, and Adi
Shamir, while impressive, is only effective against variants of
AES-256 with a reduced number of rounds and it requires related keys.
This means that the attack is not effective against AES-256 as it is
used within TLS.

(AES-128 is still often preferred over AES-256 simply because it is
believed to be sufficiently secure and because it is faster.)

PR-URL: nodejs#42578
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Linting markdown runs the JavaScript linting job, so consolidate them to
conserve time and resources. Run JavaScript separately, but then run
markdown linting so it can use the cached results of the JavaScript
linting.

PR-URL: nodejs#42572
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Mestery <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
PR-URL: nodejs#42573
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Akhil Marsonya <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
PR-URL: nodejs#42573
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Akhil Marsonya <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
The FS docs wrongfully indicated support for passing object with an own
`toString` function property to `FileHandle.prototype.appendFile`,
`FileHandle.prototype.writeFile`, `FileHandle.prototype.write`,
`fsPromises.writeFile`, and `fs.writeSync`. This commit fixes that, and
adds some test to ensure the actual behavior is aligned with the docs.
It also fixes a bug that makes the process crash if a non-buffer object
was passed to `FileHandle.prototype.write`.

Refs: nodejs#34993
PR-URL: nodejs#41677
Refs: nodejs#41666
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: James M Snell <[email protected]>
legendecas and others added 20 commits May 31, 2022 02:29
PR-URL: nodejs#43156
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
PR-URL: nodejs#43168
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
PR-URL: nodejs#42908
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
PR-URL: nodejs#43174
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Fixes: nodejs#43095

Signed-off-by: Daeyeon Jeong [email protected]

PR-URL: nodejs#43100
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
PR-URL: nodejs#43172
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
fixes: nodejs#43015

Signed-off-by: Daeyeon Jeong [email protected]

PR-URL: nodejs#43016
Fixes: nodejs#43015
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Akhil Marsonya <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Zeyu "Alex" Yang <[email protected]>
PR-URL: nodejs#42679
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
PR-URL: nodejs#43099
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
PR-URL: nodejs#43071
Reviewed-By: Paolo Insogna <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Refs: nodejs#11321
Refs: nodejs#17384

PR-URL: nodejs#43179
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
PR-URL: nodejs#43210
Reviewed-By: Ruy Adorno <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
This commit adds an option to Node.js named --openssl-legacy-provider
and if specified will load OpenSSL 3.0 Legacy provider.

$ ./node --help
...
--openssl-legacy-provider  enable OpenSSL 3.0 legacy provider

Example usage:

$ ./node --openssl-legacy-provider  -p 'crypto.createHash("md4")'
Hash {
  _options: undefined,
  [Symbol(kHandle)]: Hash {},
  [Symbol(kState)]: { [Symbol(kFinalized)]: false }
}

Co-authored-by: Richard Lau <[email protected]>

Refs: nodejs#40455
PR-URL: nodejs#40478
Backport-PR-URL: nodejs#42972
Refs: nodejs#40455
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Return early when the Inspector StringView to V8 String conversion fails
and returns an empty MaybeLocal instead of running the invalid
ToLocalChecked() assertion.

Fixes: nodejs#42407
Signed-off-by: Darshan Sen <[email protected]>

PR-URL: nodejs#42409
Backport--PR-URL: nodejs#42967
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: James M Snell <[email protected]>
PR-URL: nodejs#40488
Backport-PR-URL: nodejs#43247
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: James M Snell <[email protected]>
`handler-outside-simulator.cc` uses inline assembly, which is not
supported by MSVC.

PR-URL: nodejs#40488
Backport-PR-URL: nodejs#43247
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: James M Snell <[email protected]>
  Original commit message:

    [mips64] Remove a useless declaration of Operand.

    Change-Id: I5144d8315b5c1aca751d138e4d87240b703dc9e3
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3650359
    Commit-Queue: Zhao Jiazhong <[email protected]>
    Auto-Submit: Yu Liu <[email protected]>
    Reviewed-by: Zhao Jiazhong <[email protected]>
    Cr-Commit-Position: refs/heads/main@{#80585}

Refs: v8/v8@3ebf205
PR-URL: nodejs#43147
Reviewed-By: Beth Griggs <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
Notable changes

* crypto: make authTagLength optional for CC20P1305 (Tobias Nießen)
* esm: add chaining to loaders (Jacob Smith)
* fs: make params in writing methods optional (LiviaMedeiros)
* fs: add `read(buffer[, options])` versions (LiviaMedeiros)
* perf_hooks: add PerformanceResourceTiming (RafaelGSS)
* src: add --openssl-legacy-provider option (Daniel Bevenius)
* stream: add writableAborted (Robert Nagy)
* tools: disable trap handler for Windows cross-compiler (Michaël Zasso)
* tools: update V8 gypfiles for 9.6 (Michaël Zasso)
* worker: add hasRef() to MessagePort (Darshan Sen)

PR-UR: TDB
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/modules

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. v16.x labels May 31, 2022
@juanarbol
Copy link
Member Author

cc @nodejs/releasers

### Notable changes

* **(SEMVER-MINOR)** **crypto**: make authTagLength optional for CC20P1305 (Tobias Nießen) [#42427](https://github.com/nodejs/node/pull/42427)
* **(SEMVER-MINOR)** **esm**: add chaining to loaders (Jacob Smith) [#42623](https://github.com/nodejs/node/pull/42623)
Copy link
Contributor

@aduh95 aduh95 May 31, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has not landed yet on a Current release line, I don't think it should be in a LTS release yet.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, please back it out if it’s been included. It has the “backport blocked” label, because we want to release a few breaking-changes PRs together.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will!

@VoltrexKeyva VoltrexKeyva added the release Issues and PRs related to Node.js releases. label May 31, 2022
@juanarbol juanarbol closed this Jun 1, 2022
@juanarbol juanarbol deleted the v16.16.0-proposal branch June 1, 2022 02:59
@juanarbol
Copy link
Member Author

Transferred to #43272; this is complicated to review and seems to have some landing issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-ci PRs that need a full CI run. release Issues and PRs related to Node.js releases.
Projects
None yet
Development

Successfully merging this pull request may close these issues.