doc: clarify some default values in fs.md #42892
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
doc
aduh95
approved these changes
Apr 29, 2022
aduh95
added
typings
author ready
marsonya
approved these changes
May 1, 2022
marsonya
added
commit-queue
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/42892 ✔ Done loading data for nodejs/node/pull/42892 ----------------------------------- PR info ------------------------------------ Title doc: clarify some default values in fs.md (#42892) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch LiviaMedeiros:doc-fs-defaults -> nodejs:master Labels doc, fs, author ready, typings, commit-queue-squash Commits 3 - doc: clarify some default values in fs.md - squash: declare some values as nullable in fs.js - squash: document position in fs.readSync as optional Committers 1 - LiviaMedeiros PR-URL: https://github.com/nodejs/node/pull/42892 Reviewed-By: Antoine du Hamel Reviewed-By: Akhil Marsonya ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/42892 Reviewed-By: Antoine du Hamel Reviewed-By: Akhil Marsonya -------------------------------------------------------------------------------- ℹ This PR was created on Thu, 28 Apr 2022 08:25:40 GMT ✔ Approvals: 2 ✔ - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/42892#pullrequestreview-957570326 ✔ - Akhil Marsonya (@marsonya): https://github.com/nodejs/node/pull/42892#pullrequestreview-958618021 ✖ Last GitHub CI failed ✖ No Jenkins CI runs detected -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/2254451151 |
|
Landed in 73a8a0e |
RafaelGSS
pushed a commit
that referenced
this pull request
May 10, 2022
PR-URL: #42892 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Akhil Marsonya <[email protected]>
Merged
juanarbol
pushed a commit
that referenced
this pull request
May 31, 2022
PR-URL: #42892 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Akhil Marsonya <[email protected]>
danielleadams
pushed a commit
that referenced
this pull request
Jun 27, 2022
PR-URL: #42892 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Akhil Marsonya <[email protected]>
targos
pushed a commit
that referenced
this pull request
Jul 12, 2022
PR-URL: #42892 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Akhil Marsonya <[email protected]>
targos
pushed a commit
that referenced
this pull request
Jul 31, 2022
PR-URL: #42892 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Akhil Marsonya <[email protected]>
guangwong
pushed a commit
to noslate-project/node
that referenced
this pull request
Oct 10, 2022
PR-URL: nodejs/node#42892 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Akhil Marsonya <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR touches File system API docs:
nullas allowed "type" fortypeinfs.symlink()andpositionfs.symlink()description to allow autodetection whentypeis set