assert: make assert.fail less affected by prototype tampering

PR-URL: #42918 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
nodejs · May 31, 2022 · c6a814c · c6a814c
1 parent f120658
commit c6a814c
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/lib/internal/assert/assertion_error.js b/lib/internal/assert/assertion_error.js
@@ -441,6 +441,7 @@ class AssertionError extends Error {
 
     this.generatedMessage = !message;
     ObjectDefineProperty(this, 'name', {
+      __proto__: null,
       value: 'AssertionError [ERR_ASSERTION]',
       enumerable: false,
       writable: true,

diff --git a/test/parallel/test-assert-fail.js b/test/parallel/test-assert-fail.js
@@ -1,6 +1,6 @@
 'use strict';
 
-require('../common');
+const common = require('../common');
 const assert = require('assert');
 
 // No args
@@ -38,3 +38,7 @@ assert.throws(() => {
   name: 'TypeError',
   message: 'custom message'
 });
+
+Object.prototype.get = common.mustNotCall();
+assert.throws(() => assert.fail(''), { code: 'ERR_ASSERTION' });
+delete Object.prototype.get;