chore(doc): add trace_gc to diagnostic tooling support document
#42346
Conversation
|
Review requested:
|
tony-go
force-pushed
the
add_trace_gc_to_diag_tools
branch
from
debfe39 to
645657d
Compare
|
I don't know our convention around pro: it provides a unique diagnostic information, leading to solve a unique problem having said that, I am indecisive on this at this point, and will listen to someone's opinion. |
|
Thanks a lot for the detailed feedback @gireeshpunathil. I fully understand now, why it wasn't on the list. That's being said, I thought about something else: Even if it's integral part of v8 code base, what about the integration with node? Maybe could we test that is integrated properly? or maybe it's not worth it, let me know WDYT. |
definitely worth discussing in diagnostics wg, adding labels. |
gireeshpunathil
added
the
diag-agenda
Neat 🙌 ! |
|
discussed in the WG today. We have consensus on adding this to the list. (A governing principle being: tools that are greatly useful and heavily used in the field) |
Mesteery
added
the
author ready
|
s/tratce/trace in commit message. |
Didn't get you on this 😅. |
|
Landed in aea4e1f |
PR-URL: #42346 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>
PR-URL: nodejs#42346 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>
PR-URL: #42346 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>
PR-URL: nodejs#42346 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>
PR-URL: #42346 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>
PR-URL: #42346 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>
PR-URL: #42346 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>
PR-URL: #42346 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>
PR-URL: nodejs/node#42346 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>
Hey node family 👋
Context
A tiny PR that follows the initiative started by @gireeshpunathil here, in the diagnostic WG repo. The goal of this initiative is to re-assess diagnostic tooling and examine how could we improve the current status.
Added
While I read the current diagnostic-tooling-support document, I didn't see the same old
trace_gctool, so I added it to the list 🎉Let me know what do you think.
... for further
If it seems ok for the community, we could have a discussion about the documentation: how we could make adoption easier for newcomers, and the regular testing in Node.js CI.
📄 Regarding the documentation, I found these two links: