test: improve lib/internal/webstreams/readablestream.js coverage

PR-URL: #42823 Refs: https://coverage.nodejs.org/coverage-3a6b975981092213/lib/internal/webstreams/readablestream.js.html#L421 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
nodejs · May 31, 2022 · 8bb7f56 · 8bb7f56
1 parent d9156c9
commit 8bb7f56
Show file tree

Hide file tree

Showing 2 changed files with 38 additions and 0 deletions.
diff --git a/test/parallel/test-whatwg-readablebytestream.js b/test/parallel/test-whatwg-readablebytestream.js
@@ -65,6 +65,9 @@ const {
   defaultReader.releaseLock();
   const byobReader = r.getReader({ mode: 'byob' });
   assert(byobReader instanceof ReadableStreamBYOBReader);
+  assert.match(
+    inspect(byobReader, { depth: 0 }),
+    /ReadableStreamBYOBReader/);
 }
 
 class Source {
@@ -233,6 +236,19 @@ class Source {
   });
 }
 
+{
+  let controller;
+  new ReadableStream({
+    type: 'bytes',
+    start(c) { controller = c; }
+  });
+  controller.enqueue(new Uint8Array(10));
+  controller.close();
+  assert.throws(() => controller.enqueue(new Uint8Array(10)), {
+    code: 'ERR_INVALID_STATE',
+  });
+}
+
 {
   const stream = new ReadableStream({
     type: 'bytes',

diff --git a/test/parallel/test-whatwg-readablestream.js b/test/parallel/test-whatwg-readablestream.js
@@ -32,6 +32,7 @@ const {
   readableStreamDefaultControllerCanCloseOrEnqueue,
   readableByteStreamControllerClose,
   readableByteStreamControllerRespond,
+  readableStreamReaderGenericRelease,
 } = require('internal/webstreams/readablestream');
 
 const {
@@ -371,6 +372,24 @@ assert.throws(() => {
   });
 }
 
+{
+  const stream = new ReadableStream();
+  const iterable = stream.values();
+  readableStreamReaderGenericRelease(stream[kState].reader);
+  assert.rejects(iterable.next(), {
+    code: 'ERR_INVALID_STATE',
+  }).then(common.mustCall());
+}
+
+{
+  const stream = new ReadableStream();
+  const iterable = stream.values();
+  readableStreamReaderGenericRelease(stream[kState].reader);
+  assert.rejects(iterable.return(), {
+    code: 'ERR_INVALID_STATE',
+  }).then(common.mustCall());
+}
+
 {
   const stream = new ReadableStream({
     start(controller) {
@@ -1357,6 +1376,9 @@ class Source {
   assert.throws(() => ReadableStream.prototype.tee.call({}), {
     code: 'ERR_INVALID_THIS',
   });
+  assert.throws(() => ReadableStream.prototype.values.call({}), {
+    code: 'ERR_INVALID_THIS',
+  });
   assert.throws(() => ReadableStream.prototype[kTransfer].call({}), {
     code: 'ERR_INVALID_THIS',
   });