Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: update eslint to 8.12.0 #42489

Merged
merged 0 commits into from
Mar 27, 2022
Merged

tools: update eslint to 8.12.0 #42489

merged 0 commits into from
Mar 27, 2022

Conversation

nodejs-github-bot
Copy link
Collaborator

This is an automated update of eslint to 8.12.0.

@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Mar 27, 2022
@Trott Trott force-pushed the actions/tools-update-eslint branch from 684ea20 to 5bb9102 Compare March 27, 2022 03:49
@Trott Trott added commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. request-ci Add this label to start a Jenkins CI on a PR. fast-track PRs that do not need to wait for 48 hours to land. labels Mar 27, 2022
@github-actions
Copy link
Contributor

Fast-track has been requested by @Trott. Please 👍 to approve.

@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 27, 2022
@nodejs-github-bot
Copy link
Collaborator Author

CI: https://ci.nodejs.org/job/node-test-pull-request/43195/

aduh95
aduh95 reviewed Mar 27, 2022
View reviewed changes
lib/child_process.js Outdated
@@ -98,7 +98,7 @@ const MAX_BUFFER = 1024 * 1024;
* @param {{
* cwd?: string;
* detached?: boolean;
* env?: Object;
* env?: object;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The object type represents all non-primitive values in TS, should we use a more precise type? (Or maybe that’s JSDoc syntax and not TypeScript and object means something else?)

Suggested change
* env?: object;
* env?: Record<string, string>;

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Subsequent PR? This is just about getting our current entries to pass linting.

@Trott Trott added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Mar 27, 2022
@Trott
Copy link
Member

Trott commented Mar 27, 2022

Landed in a7697c5...d143094

Trott added a commit to Trott/io.js that referenced this pull request Mar 27, 2022
@Trott
lib: update JSDoc for linting
3c97583 
Fix issue that will be flagged when we update ESLint and dependencies.

PR-URL: nodejs#42489
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@Trott Trott closed this Mar 27, 2022
@Trott Trott force-pushed the actions/tools-update-eslint branch from 5bb9102 to d143094 Compare March 27, 2022 15:36
@Trott Trott merged commit d143094 into master Mar 27, 2022
@Trott Trott deleted the actions/tools-update-eslint branch March 27, 2022 15:36
Trott added a commit to Trott/io.js that referenced this pull request Mar 27, 2022
@Trott
child_process: add env contents types in JSDoc
a0a1641 
Use JSDoc to indicate that the `env` object keys and values must be
strings.

Refs: nodejs#42489 (comment)
@Trott Trott mentioned this pull request Mar 27, 2022
Merged
Trott added a commit to Trott/io.js that referenced this pull request Mar 28, 2022
@Trott
child_process: add env contents types in JSDoc
69ae2cc 
Use JSDoc to indicate that the `env` object keys and values must be
strings.

Refs: nodejs#42489 (comment)
nodejs-github-bot pushed a commit that referenced this pull request Mar 30, 2022
@Trott
child_process: add env contents types in JSDoc
f8ca5df 
Use JSDoc to indicate that the `env` object keys and values must be
strings.

Refs: #42489 (comment)

PR-URL: #42494
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
juanarbol pushed a commit that referenced this pull request Apr 4, 2022
@Trott @juanarbol
lib: update JSDoc for linting
5b841f7 
Fix issue that will be flagged when we update ESLint and dependencies.

PR-URL: #42489
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
juanarbol pushed a commit that referenced this pull request Apr 4, 2022
@nodejs-github-bot @juanarbol
tools: update eslint to 8.12.0
ce0ebf9 
PR-URL: #42489
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
juanarbol pushed a commit that referenced this pull request Apr 4, 2022
@Trott @juanarbol
child_process: add env contents types in JSDoc
47a0b97 
Use JSDoc to indicate that the `env` object keys and values must be
strings.

Refs: #42489 (comment)

PR-URL: #42494
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
juanarbol pushed a commit to juanarbol/node that referenced this pull request Apr 5, 2022
@Trott @juanarbol
lib: update JSDoc for linting
86a05ca 
Fix issue that will be flagged when we update ESLint and dependencies.

PR-URL: nodejs#42489
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
juanarbol pushed a commit to juanarbol/node that referenced this pull request Apr 5, 2022
@nodejs-github-bot @juanarbol
tools: update eslint to 8.12.0
f4decbd 
PR-URL: nodejs#42489
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
juanarbol pushed a commit to juanarbol/node that referenced this pull request Apr 5, 2022
@Trott @juanarbol
child_process: add env contents types in JSDoc
7105f8b 
Use JSDoc to indicate that the `env` object keys and values must be
strings.

Refs: nodejs#42489 (comment)

PR-URL: nodejs#42494
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
This was referenced Apr 5, 2022
Closed
Merged
juanarbol pushed a commit that referenced this pull request Apr 6, 2022
@Trott @juanarbol
lib: update JSDoc for linting
b74de21 
Fix issue that will be flagged when we update ESLint and dependencies.

PR-URL: #42489
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
juanarbol pushed a commit that referenced this pull request Apr 6, 2022
@nodejs-github-bot @juanarbol
tools: update eslint to 8.12.0
c6bfb22 
PR-URL: #42489
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
juanarbol pushed a commit that referenced this pull request Apr 6, 2022
@Trott @juanarbol
child_process: add env contents types in JSDoc
9a54acb 
Use JSDoc to indicate that the `env` object keys and values must be
strings.

Refs: #42489 (comment)

PR-URL: #42494
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
xtx1130 pushed a commit to xtx1130/node that referenced this pull request Apr 25, 2022
@Trott @xtx1130
lib: update JSDoc for linting
06d78ac 
Fix issue that will be flagged when we update ESLint and dependencies.

PR-URL: nodejs#42489
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
xtx1130 pushed a commit to xtx1130/node that referenced this pull request Apr 25, 2022
@nodejs-github-bot @xtx1130
tools: update eslint to 8.12.0
256ec9c 
PR-URL: nodejs#42489
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
xtx1130 pushed a commit to xtx1130/node that referenced this pull request Apr 25, 2022
@Trott @xtx1130
child_process: add env contents types in JSDoc
a925f31 
Use JSDoc to indicate that the `env` object keys and values must be
strings.

Refs: nodejs#42489 (comment)

PR-URL: nodejs#42494
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
juanarbol pushed a commit that referenced this pull request May 31, 2022
@Trott @juanarbol
lib: update JSDoc for linting
21cf1dd 
Fix issue that will be flagged when we update ESLint and dependencies.

PR-URL: #42489
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
juanarbol pushed a commit that referenced this pull request May 31, 2022
@nodejs-github-bot @juanarbol
tools: update eslint to 8.12.0
bd2d437 
PR-URL: #42489
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
juanarbol pushed a commit that referenced this pull request May 31, 2022
@Trott @juanarbol
child_process: add env contents types in JSDoc
687b853 
Use JSDoc to indicate that the `env` object keys and values must be
strings.

Refs: #42489 (comment)

PR-URL: #42494
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
@juanarbol juanarbol mentioned this pull request May 31, 2022
Closed
danielleadams pushed a commit that referenced this pull request Jun 27, 2022
@Trott @danielleadams
lib: update JSDoc for linting
6bb74dd 
Fix issue that will be flagged when we update ESLint and dependencies.

PR-URL: #42489
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
danielleadams pushed a commit that referenced this pull request Jun 27, 2022
@nodejs-github-bot @danielleadams
tools: update eslint to 8.12.0
0582a2e 
PR-URL: #42489
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
danielleadams pushed a commit that referenced this pull request Jun 27, 2022
@Trott @danielleadams
child_process: add env contents types in JSDoc
7821df2 
Use JSDoc to indicate that the `env` object keys and values must be
strings.

Refs: #42489 (comment)

PR-URL: #42494
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
targos pushed a commit that referenced this pull request Jul 11, 2022
@Trott @targos
lib: update JSDoc for linting
576ecf7 
Fix issue that will be flagged when we update ESLint and dependencies.

PR-URL: #42489
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
targos pushed a commit that referenced this pull request Jul 11, 2022
@nodejs-github-bot @targos
tools: update eslint to 8.12.0
03ad75c 
PR-URL: #42489
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
targos pushed a commit that referenced this pull request Jul 11, 2022
@Trott @targos
child_process: add env contents types in JSDoc
976636f 
Use JSDoc to indicate that the `env` object keys and values must be
strings.

Refs: #42489 (comment)

PR-URL: #42494
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
targos pushed a commit that referenced this pull request Jul 11, 2022
@Trott @targos
child_process: add env contents types in JSDoc
52a96c7 
Use JSDoc to indicate that the `env` object keys and values must be
strings.

Refs: #42489 (comment)

PR-URL: #42494
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
targos pushed a commit that referenced this pull request Jul 31, 2022
@Trott @targos
lib: update JSDoc for linting
e48ccf5 
Fix issue that will be flagged when we update ESLint and dependencies.

PR-URL: #42489
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
targos pushed a commit that referenced this pull request Jul 31, 2022
@nodejs-github-bot @targos
tools: update eslint to 8.12.0
a176b81 
PR-URL: #42489
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
targos pushed a commit that referenced this pull request Jul 31, 2022
@Trott @targos
child_process: add env contents types in JSDoc
72400b7 
Use JSDoc to indicate that the `env` object keys and values must be
strings.

Refs: #42489 (comment)

PR-URL: #42494
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
@targos targos mentioned this pull request Aug 3, 2022
Merged
guangwong pushed a commit to noslate-project/node that referenced this pull request Oct 10, 2022
@Trott @guangwong
lib: update JSDoc for linting
0aebe83 
Fix issue that will be flagged when we update ESLint and dependencies.

PR-URL: nodejs/node#42489
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
guangwong pushed a commit to noslate-project/node that referenced this pull request Oct 10, 2022
@nodejs-github-bot @guangwong
tools: update eslint to 8.12.0
6608761 
PR-URL: nodejs/node#42489
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
guangwong pushed a commit to noslate-project/node that referenced this pull request Oct 10, 2022
@Trott @guangwong
child_process: add env contents types in JSDoc
2914878 
Use JSDoc to indicate that the `env` object keys and values must be
strings.

Refs: nodejs/node#42489 (comment)

PR-URL: nodejs/node#42494
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aduh95 aduh95 aduh95 left review comments

@Trott Trott Trott approved these changes

@Mesteery Mesteery Mesteery approved these changes

@RaisinTen RaisinTen RaisinTen approved these changes

@trivikr trivikr trivikr approved these changes

@tniessen tniessen tniessen approved these changes

@cjihrig cjihrig cjihrig approved these changes

Assignees
No one assigned
Labels
commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. fast-track PRs that do not need to wait for 48 hours to land. tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@nodejs-github-bot @Trott @cjihrig @tniessen @aduh95 @trivikr @RaisinTen @Mesteery