Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v12.16.2 proposal #32313

Merged
merged 389 commits into from
Apr 8, 2020
Merged

v12.16.2 proposal #32313

merged 389 commits into from
Apr 8, 2020

Conversation

codebytere
Copy link
Member

@codebytere codebytere commented Mar 17, 2020

2020-04-08, Version 12.16.2 'Erbium' (LTS), @codebytere

Notable Changes

  • doc:
    • add ronag to collaborators (Robert Nagy) #31498
    • add GeoffreyBooth to collaborators (Geoffrey Booth) #31306
  • deps:
    • upgrade npm to 6.13.6 (Ruy Adorno) #31304
    • update openssl to 1.1.1e (Hassaan Pasha) #32328

Commits

  • [f756c809e0] - assert: align character indicators properly (Ruben Bridgewater) #31429
  • [597431b1f2] - async_hooks: remove internal only error checking (Anatoli Papirovski) #30967
  • [35f107da53] - benchmark: remove problematic tls params (Brian White) #31816
  • [0b7579022c] - benchmark: use let instead of var (Daniele Belardi) #31592
  • [7173b285e7] - benchmark: swap var for let in benchmarks (Alex Ramirez) #28958
  • [c18cec7593] - benchmark: remove special test entries (Ruben Bridgewater) #31396
  • [19fbe55451] - benchmark: refactor helper into a class (Ruben Bridgewater) #31396
  • [a305ae2308] - benchmark: check for and fix multiple end() (Brian White) #31624
  • [7f828a4dd0] - benchmark: clean up config resolution in multiple benchmarks (Denys Otrishko) #31581
  • [4e40c77dc7] - benchmark: add MessagePort benchmark (Anna Henningsen) #31568
  • [2973c1fabf] - benchmark: use let and const instead of var (Daniele Belardi) #31518
  • [393b48e744] - benchmark: fix getStringWidth() benchmark (Rich Trott) #31476
  • [267a01f4eb] - benchmark: add default type in getstringwidth.js (Rich Trott) #31377
  • [4f9d57d01e] - benchmark: benchmarking impacts of async hooks on promises (legendecas) #31188
  • [06bc2ded77] - buffer: improve from() performance (Brian White) #31615
  • [22a37d6847] - buffer: improve concat() performance (Brian White) #31522
  • [1849c2cc99] - buffer: improve fill(number) performance (Brian White) #31489
  • [45d05e1cf6] - build: add mjs extension to lint-js (Nick Schonning) #32145
  • [fae680f740] - build: drop Travis in favor of Actions (Christian Clauss) #32450
  • [a50648975d] - build: annotate markdown lint failures in pull requests (Richard Lau) #32391
  • [c42cb79bb7] - build: build docs in GitHub Actions CI workflow (Richard Lau) #31504
  • [46f83df2fd] - build: do not use setup-node in build workflows (Richard Lau) #31349
  • [ad12c82e37] - build: fix macos runner type in GitHub Action (扩散性百万甜面包) #31327
  • [df701f3b12] - build: fix step name in GitHub Actions workflow (Richard Lau) #31323
  • [d190ee06b4] - build: add GitHub actions to run linters (Richard Lau) #31323
  • [7d3910d078] - build: macOS package notarization (Rod Vagg) #31459
  • [36ae81a52a] - build: allow use of system-installed brotli (André Draszik) #32046
  • [6605bba0b8] - build: allow passing multiple libs to pkg_config (André Draszik) #32046
  • [8a0b0a76c0] - build: enable backtrace when V8 is built for PPC and S390x (Michaël Zasso) #32113
  • [4dddb56178] - build: only lint markdown files that have changed (POSIX-only) (Rich Trott) #31923
  • [4f36bf78ea] - build: add configure option to debug only Node.js part of the binary (Anna Henningsen) #31644
  • [a53500e26b] - build: ignore all the "Debug","Release" folders (ConorDavenport) #31565
  • [038fd25ef8] - build: fix zlib tarball generation (Shelley Vohr) #32094
  • [e79f368783] - build: remove enable_vtune from vcbuild.bat (Richard Lau) #31338
  • [8296224e41] - build: add vs2019 to vcbuild.bat help (Richard Lau) #31338
  • [93a7f91b52] - build: silence OpenSSL Windows compiler warnings (Richard Lau) #31311
  • [a89893f3df] - build: silence c-ares Windows compiler warnings (Richard Lau) #31311
  • [f6a6638d0c] - build: test Python 3 using GitHub Actions-based CI (Christian Clauss) #29474
  • [aec22268af] - cli: allow --jitless V8 flag in NODE_OPTIONS (Andrew Neitsch) #32100
  • [70dc1cefea] - cli: --perf-prof only works on Linux (Shelley Vohr) #31892
  • [f9113fd7c2] - crypto: turn impossible DH errors into assertions (Tobias Nießen) #31934
  • [c6bbae44a9] - crypto: fix ieee-p1363 for createVerify (Tobias Nießen) #31876
  • [b84fd947d2] - crypto: fix performance regression (Robert Nagy) #31742
  • [9a3760d2fa] - crypto: improve randomBytes() performance (Brian White) #31519
  • [a1be32752c] - deps: V8: backport 07ee86a5a28b (Milad Farazmand) #32619
  • [a83fc49717] - deps: V8: cherry-pick cb1c2b0fbfe7 (Gerhard Stoebich) #31939
  • [784df12494] - deps: revert whitespace changes on V8 (Matheus Marchini) #32605
  • [6db190bb1c] - deps: upgrade npm to 6.14.4 (Ruy Adorno) #32495
  • [652ffa5470] - deps: update term-size with signed version (Rod Vagg) #31459
  • [f55d071bfd] - deps: remove *.pyc files from deps/npm (Ben Noordhuis) #32387
  • [c419cd21e3] - deps: update npm to 6.14.3 (Myles Borins) #32368
  • [17217a5275] - deps: upgrade npm to 6.14.1 (Isaac Z. Schlueter) #31977
  • [260bd810e9] - deps: update archs files for OpenSSL-1.1.1e (Hassaan Pasha) #32328
  • [e96e8afead] - deps: adjust openssl configuration for 1.1.1e (Hassaan Pasha) #32328
  • [4de1afd32d] - deps: upgrade openssl sources to 1.1.1e (Hassaan Pasha) #32328
  • [e2c40ccb78] - deps: V8: backport f7771e5b0cc4 (Matheus Marchini) #31957
  • [78d9a50c83] - deps: openssl: cherry-pick 4dcb150ea30f (Adam Majer) #32002
  • [ff1e5e01f4] - deps: upgrade npm to 6.13.7 (Michael Perrotte) #31558
  • [48e4d45cca] - deps: uvwasi: cherry-pick 7b5b6f9 (Colin Ihrig) #31495
  • [604ce0aa5a] - deps: upgrade to libuv 1.34.2 (Colin Ihrig) #31477
  • [3fb3079337] - deps: uvwasi: cherry-pick eea4508 (Colin Ihrig) #31432
  • [3bd1c02941] - deps: uvwasi: cherry-pick c3bef8e (Colin Ihrig) #31432
  • [12949019de] - deps: uvwasi: cherry-pick ea73af5 (Colin Ihrig) #31432
  • [ada070eed4] - deps: update to uvwasi 0.0.5 (Colin Ihrig) #31432
  • [8cf2666248] - deps: uvwasi: cherry-pick 941bedf (Colin Ihrig) #31363
  • [ef5517aa0c] - deps: port uvwasi@676ba9a to gyp (Colin Ihrig) #31363
  • [bbb8ae7bd0] - deps: upgrade to libuv 1.34.1 (Colin Ihrig) #31332
  • [7a8963bc75] - deps: upgrade npm to 6.13.6 (Ruy Adorno) #31304
  • [676e3c3c38] - deps,test: update to uvwasi 0.0.4 (Colin Ihrig) #31363
  • [e88960d1f4] - doc: esm spec bug (Myles Borins) #32610
  • [155a6c397d] - doc: update conditional exports recommendations (Guy Bedford) #32098
  • [7e56e3dee3] - doc: remove unnecessary "obvious(ly)" modifiers in esm.md (Rich Trott) #32457
  • [61f44c94ae] - doc: fix lint warning in doc/api/esm.md (Richard Lau) #32462
  • [d8e17bf12a] - doc: improve wording in esm.md (Rich Trott) #32427
  • [8b961347fe] - doc: import clarifications with links to MDN (Eric Dobbertin) #31479
  • [f58594b8ec] - doc: update releaser list in README.md (Myles Borins) #32577
  • [885c88ee5b] - doc: official macOS builds now on 10.15 + Xcode 11 (Rod Vagg) #31459
  • [efd20f08e8] - doc: link setRawMode() from signal docs (Anna Henningsen) #32088
  • [3f1b9162f6] - doc: document self-referencing a package name (Gil Tayar) #31680
  • [f820ce6e50] - doc: add AsyncResource + Worker pool example (Anna Henningsen) #31601
  • [df8d51b411] - doc: document fs.watchFile() bigint option (Colin Ihrig) #32128
  • [eaf615709f] - doc: fix broken links in benchmark README (Rich Trott) #32121
  • [047bd9d38e] - doc: update email address in authors (Yael Hermon) #32026
  • [c20f2cd41d] - doc: update maintaining-V8.md (kenzo-spaulding) #31503
  • [05fbc80f45] - doc: visibility of Worker threads cli options (Harshitha KP) #31380
  • [224a17e202] - doc: improve doc/markdown file organization coherence (ConorDavenport) #31792
  • [df54a1932a] - doc: revise --zero-fill-buffers text in buffer.md (Rich Trott) #32019
  • [9161b7e5c3] - doc: add link to sem-ver info (unknown) #31985
  • [1630320781] - doc: update zlib doc (James M Snell) #31665
  • [a1c0d467ef] - doc: clarify http2.connect authority details (James M Snell) #31828
  • [ed86854025] - doc: updated YAML version representation in readline.md (Rich Trott) #31924
  • [370653f1a0] - doc: update releases guide re pushing tags (Myles Borins) #31855
  • [ab735d0144] - doc: update assert.rejects() docs with a validation function example (Eric Eastwood) #31271
  • [911dfc5099] - doc: add note about ssh key to releases (Shelley Vohr) #31856
  • [e83af20b70] - doc: add note in BUILDING.md about running make distclean (Swagat Konchada) #31542
  • [17882ac83d] - doc: reword possessive form of Node.js in adding-new-napi-api.md (Rich Trott) #31748
  • [648f83135e] - doc: reword possessive form of Node.js in http.md (Rich Trott) #31748
  • [d034eb41f2] - doc: reword possessive form of Node.js in process.md (Rich Trott) #31748
  • [b8d2997950] - doc: reword possessive form of Node.js in debugger.md (Rich Trott) #31748
  • [aebaeadf05] - doc: move gireeshpunathil to TSC emeritus (Gireesh Punathil) #31770
  • [88a6d9b077] - doc: pronouns for @Fishrock123 (Jeremiah Senkpiel) #31725
  • [b3d0795a4a] - doc: move @Fishrock123 to TSC Emeriti (Jeremiah Senkpiel) #31725
  • [e65c1c25fc] - doc: move @Fishrock123 to a previous releaser (Jeremiah Senkpiel) #31725
  • [38d3f56ea3] - doc: fix typos in doc/api/https.md (Jeff) #31793
  • [de275d0e0b] - doc: guide - using valgrind to debug memory leaks (Michael Dawson) #31501
  • [82defc0d15] - doc: add glossary.md (gengjiawen) #27517
  • [01ec7221e6] - doc: add prerequisites information for Arch (Ujjwal Sharma) #31669
  • [a7a6261fa4] - doc: fix typo on fs docs (Juan José Arboleda) #31620
  • [d4c1a8cc7b] - doc: update contact email for @ryzokuken (Ujjwal Sharma) #31670
  • [86686ccbab] - doc: fix default server timeout description for https (Andrey Pechkurov) #31692
  • [448fe39c35] - doc: add directions to mark a release line as lts (Danielle Adams) #31724
  • [dbe2da65c9] - doc: expand C++ README with information about exception handling (Anna Henningsen) #31720
  • [236943ac5b] - doc: update foundation name in onboarding (Tobias Nießen) #31719
  • [165047a787] - doc: reword possessive form of Node.js in zlib.md (Rich Trott) #31713
  • [d3201d7933] - doc: reword possessive form of Node.js in modules.md (Rich Trott) #31713
  • [4c65d0a3d3] - doc: reword possessive form of Node.js in repl.md (Rich Trott) #31713
  • [4c5c340d28] - doc: reword section title in addons.md (Rich Trott) #31713
  • [1db85aa71c] - doc: revise deepEqual() legacy assertion mode text (Rich Trott) #31704
  • [aadd8cac4b] - doc: improve strict assertion mode color text (Rich Trott) #31703
  • [708aff953a] - doc: consolidate introductory text (Rich Trott) #31667
  • [959fa8ff9d] - doc: simplify async_hooks overview (Rich Trott) #31660
  • [28657cc614] - doc: clarify Worker exit/message event ordering (Anna Henningsen) #31642
  • [cb75ca1a51] - doc: update TSC name in "Release Process" (Tobias Nießen) #31652
  • [76b500218b] - doc: remove .github/ISSUE_TEMPLATE.md in favor of the template folder (Joyee Cheung) #31656
  • [55c7b9f94a] - doc: correct getting an ArrayBuffer's length (tsabolov) #31632
  • [afeaec7d6f] - doc: ask more questions in the bug report template (Joyee Cheung) #31611
  • [06d5a9c0a0] - doc: add example to fs.promises.readdir (Conor ONeill) #31552
  • [351c86310b] - doc: fix numbering (Steffen) #31575
  • [356e505ab0] - doc: clarify socket.setNoDelay() explanation (Rusty Conover) #31541
  • [b2e571ea65] - doc: clarify require() OS independence (Denys Otrishko) #31571
  • [1759f0ab52] - doc: add protocol option in http2.connect() (Michael Lumish) #31560
  • [f5663d92b8] - doc: clarify that v8.serialize() is not deterministic (Anna Henningsen) #31548
  • [af61c5d1b2] - doc: update job reference in COLLABORATOR_GUIDE.md (Richard Lau) #31557
  • [f4bdcf86ce] - doc: simultaneous blog and email of sec announce (Sam Roberts) #31483
  • [5286ccc1dc] - doc: update collaborator guide citgm instructions (Robert Nagy) #31549
  • [1cf450c51f] - doc: change error message testing policy (Tobias Nießen) #31421
  • [d978bb56dd] - doc: remove redundant properties from headers (XhmikosR) #31492
  • [e48f874afd] - doc: enable visual code indication in headers (Rich Trott) #31493
  • [8c78b87d97] - doc: clean up and streamline vm.md examples (Denys Otrishko) #31474
  • [821b9ac007] - doc: further fix async iterator example (Robert Nagy) #31367
  • [f0b5f9fb94] - doc: add ronag to collaborators (Robert Nagy) #31498
  • [37754bab2d] - doc: fix code display in header glitch (Rich Trott) #31460
  • [40480e0c0d] - doc: fix syntax in N-API documentation (Tobias Nießen) #31466
  • [11dbdcb839] - doc: add explanatory to path.resolve description (Yakov Litvin) #31430
  • [5e8f8b8320] - doc: document process.std*.fd (Harshitha KP) #31395
  • [c7f03ad8ca] - doc: fix several child_process doc typos (Colin Ihrig) #31393
  • [2d9f111011] - doc: correct added version for --abort-on-uncaught-exception (Anna Henningsen) #31360
  • [d944fa71dd] - doc: explain hex encoding in Buffer API (Harshitha KP) #31352
  • [ff8f0bc3cc] - doc: explain _writev() API (Harshitha KP) #31356
  • [b4d15a9adc] - doc: document missing properties in child_process (Harshitha KP) #31342
  • [9aa4fcc052] - doc: standardize on "host name" in deprecations.md (Rich Trott) #31326
  • [175a5ec795] - doc: standardize on "host name" in url.md (Rich Trott) #31326
  • [5f45eaf390] - doc: standardize on "host name" in tls.md (Rich Trott) #31326
  • [54b5346392] - doc: standardize on "host name" in os.md (Rich Trott) #31326
  • [ac3d0c90f5] - doc: standardize on "host name" in net.md (Rich Trott) #31326
  • [9217b7a639] - doc: standardize on "host name" in https.md (Rich Trott) #31326
  • [9bca4514bf] - doc: standardize on "host name" in http2.md (Rich Trott) #31326
  • [a419698b18] - doc: standardize on "host name" in fs.md (Rich Trott) #31326
  • [d4a0300424] - doc: standardize on "host name" in errors.md (Rich Trott) #31326
  • [ad701329d6] - doc: standardize on "host name" in dgram.md (Rich Trott) #31326
  • [0eba07b267] - doc: standardize on "host name" in async_hooks.md (Rich Trott) #31326
  • [52a4a44b76] - doc: fix a code example in crypto.md (himself65) #31313
  • [6598a08308] - doc: add an example for util.types.isExternal (Harshitha KP) #31173
  • [760bedee44] - doc: fix example of parsing request.url (Egor Pavlov) #31302
  • [fa0762d663] - doc: improve doc v8.getHeapSpaceStatistics() 'GetHeapSpaceStatistics' (dev-313) #31274
  • [cb40a1a90f] - doc: update README to make Node.js description clearer (carterbancroft) #31266
  • [dd9a6c6c22] - doc: fix a code example in zlib.md (Alexander Wang) #31264
  • [97c12f120e] - doc: add GeoffreyBooth to collaborators (Geoffrey Booth) #31306
  • [63af1ab60f] - doc: update description of External (Anna Henningsen) #31255
  • [e398137020] - doc: rename iterator to iterable in examples (Robert Nagy) #31252
  • [4922184310] - doc: fix stream async iterator sample (Robert Nagy) #31252
  • [623e1118a0] - doc: correct filehandle.[read|write|append]File() (Bryan English) #31235
  • [60e35d454c] - doc: prefer server vs srv and client vs clt (Andrew Hughes) #31224
  • [6cfc4dcfb4] - doc: explain native external types (Harshitha KP) #31214
  • [ebc47f8b52] - doc: remove em dashes (Rich Trott) #32146
  • [db125c5618] - doc: fix missing changelog corrections (Myles Borins) #31854
  • [8f75c7497e] - doc,assert: rename "mode" to "assertion mode" (Rich Trott) #31635
  • [fd5aa41178] - doc,crypto: re-document oaepLabel option (Ben Noordhuis) #31825
  • [8f9f92fb33] - doc,net: reword Unix domain path paragraph in net.md (Rich Trott) #31684
  • [073b4f2750] - doc,src: clarify that one napi_env is per-module (legendecas) #31102
  • [844f893e4e] - doc,util: revise util.md introductory paragraph (Rich Trott) #31685
  • [b1517a4f6c] - errors: make use of "cannot" consistent (Tobias Nießen) #31420
  • [7231090a5d] - errors: remove dead code in ERR_INVALID_ARG_TYPE (Gerhard Stoebich) #31322
  • [0e513b2ae7] - esm: remove unused parameter on module.instantiate (himself65) #32147
  • [05091d48e3] - esm: import.meta.resolve with nodejs: builtins (Guy Bedford) #31032
  • [400083b9f5] - events: fix removeListener for Symbols (zfx) #31847
  • [de5d162c60] - fs: fix valid id range on chown, lchown, fchown (himself65) #31694
  • [d36699662f] - fs: set path when mkdir recursive called on file (Benjamin Coe) #31607
  • [3d8e850d31] - fs: bail on permission error in recursive directory creation (Benjamin Coe) #31505
  • [fc9c6c3227] - fs: do not emit 'close' twice if emitClose enabled (Robert Nagy) #31383
  • [ca951e182e] - fs: unset FileHandle fd after close (Anna Henningsen) #31389
  • [1fe0065a51] - fs: add missing HandleScope to FileHandle.close (Anna Henningsen) #31276
  • [73c4729652] - fs: use async writeFile in FileHandle#appendFile (Bryan English) #31235
  • [4745ac4fd7] - http2: use custom BaseObject smart pointers (Anna Henningsen) #30374
  • [76a0ba689a] - http2: make compat finished match http/1 (Robert Nagy) #24347
  • [f910f645b9] - http2: skip creating native ShutdownWrap (Anna Henningsen) #31283
  • [d00a1b9ad2] - lib: replace BigInt64Array global by the primordials (Sebastien Ahkrin) #31193
  • [2147c29de0] - lib: add Uint16Array primordials (Sebastien Ahkrin) #31210
  • [bc4cbe3f50] - lib: add RegExp primordials (Sebastien Ahkrin) #31208
  • [41f0fa742e] - lib: replace Float32Array global by the primordials (Sebastien Ahkrin) #31195
  • [68d48fead3] - lib: replace BigUInt64Array global by the primordials (Sebastien Ahkrin) #31194
  • [a0ad12bd7d] - lib,tools,test: remove custom number-isnan rule (Colin Ihrig) #31211
  • [a6f56bb11e] - meta: move thefourtheye to TSC Emeritus (Rich Trott) #32059
  • [ae9f58cbdd] - meta: move not-an-aardvark to emeritus (Rich Trott) #31928
  • [553d62c26d] - meta: move aqrln to emeritus (Rich Trott) #31997
  • [a44fb3fabf] - meta: move jbergstroem to emeritus (Rich Trott) #31996
  • [a75aa93b2d] - meta: move maclover7 to Emeritus (Rich Trott) #31994
  • [fd5c3a749a] - meta: move Glen Keane to Collaborator Emeritus (Rich Trott) #31993
  • [9251307570] - meta: move julianduque to emeritus (Rich Trott) #31863
  • [2a4d31ae23] - meta: move eljefedelrodeodeljefe to emeritus (Rich Trott) #31735
  • [c222d561c6] - meta: move princejwesley to emeritus (Rich Trott) #31730
  • [3e7e9fdca9] - meta: move vkurchatkin to emeritus (Rich Trott) #31729
  • [ca52b5b1e3] - meta: move calvinmetcalf to emeritus (Rich Trott) #31736
  • [c892d410bb] - meta: fix collaborator list errors in README.md (James M Snell) #31655
  • [62b5bd4ca0] - module: add hook for global preload code (Jan Krems) #32068
  • [c537afb18c] - module: package "exports" error refinements (Guy Bedford) #31625
  • [4ee41c572c] - module: drop support for extensionless main entry points in esm (Geoffrey Booth) #31415
  • [08e09eca34] - n-api: free instance data as reference (Gabriel Schulhof) #31638
  • [16c690373a] - n-api: rename 'promise' parameter to 'value' (Tobias Nießen) #31544
  • [3a84634cc1] - n-api: return napi_invalid_arg on napi_create_bigint_words (legendecas) #31312
  • [0d30546329] - net: track state of setNoDelay() and prevent unnecessary system calls (Rusty Conover) #31543
  • [87cfbb2da1] - report: add support for Workers (Anna Henningsen) #31386
  • [782f5dbddd] - src: add build Github Action (gengjiawen) #31153
  • [fbd5be6734] - src: delete BaseObjectWeakPtr data when pointee is gone (Anna Henningsen) #32393
  • [56a45095b7] - src: harden running native SetImmediate()s slightly (Anna Henningsen) #31468
  • [cb16aabd15] - src: simplify native immediate queue running (Anna Henningsen) #31502
  • [c2176e15ea] - src: move MemoryInfo() for worker code to .cc files (Anna Henningsen) #31386
  • [22bf867149] - src: add interrupts to Environments/Workers (Anna Henningsen) #31386
  • [7c2c068aeb] - src: remove AsyncRequest (Anna Henningsen) #31386
  • [748a530046] - src: add a threadsafe variant of SetImmediate() (Anna Henningsen) #31386
  • [aafb224147] - src: exclude C++ SetImmediate() from count (Anna Henningsen) #31386
  • [5df969826d] - src: better encapsulate native immediate list (Anna Henningsen) #31386
  • [2625244111] - src: run native immediates during Environment cleanup (Anna Henningsen) #30666
  • [5b65348fed] - src: no SetImmediate from destructor in stream_pipe code (Anna Henningsen) #30666
  • [51230f71ff] - src: add more can\_call\_into\_js() guards (Anna Henningsen) #30666
  • [7647bfe3fc] - src: keep object alive in stream_pipe code (Anna Henningsen) #30666
  • [5f95e69f4d] - src: remove HandleWrap instances from list once closed (Anna Henningsen) #30374
  • [e17d314a21] - src: remove keep alive option from SetImmediate() (Anna Henningsen) #30374
  • [6db84d3e50] - src: use BaseObjectPtr for keeping channel alive in dns bindings (Anna Henningsen) #30374
  • [c60780ff52] - src: introduce custom smart pointers for BaseObjects (Anna Henningsen) #30374
  • [17e10dd3cb] - src: use C++ style for struct with initializers (Sam Roberts) #32134
  • [b5c6230258] - src: implement per-process native Debug() printer (Joyee Cheung) #31884
  • [b95e8eafa5] - src: refactor debug category parsing (Joyee Cheung) #31884
  • [19f3c0adc2] - src: make aliased_buffer.h self-contained (Joyee Cheung) #31884
  • [908f634110] - src: discard tasks posted to platform TaskRunner during shutdown (Anna Henningsen) #31853
  • [808379c379] - src: Handle bad callback in asyc_wrap (Harshitha KP) #31946
  • [a6a41f4c77] - src: add node_crypto_common and refactor (James M Snell) #32016
  • [0b327bd81d] - src: enable StreamPipe for generic StreamBases (Anna Henningsen) #31869
  • [bd92243ddf] - src: elevate v8 namespaces (Harshitha KP) #31901
  • [3b2bbbdeca] - src: allow unique_ptrs with custom deleter in memory tracker (Anna Henningsen) #31870
  • [9ab4a7e5ce] - src: move BaseObject subclass dtors/ctors out of node_crypto.h (Anna Henningsen) #31872
  • [041408d513] - src: don't run bootstrapper in CreateEnvironment (Shelley Vohr) #31910
  • [e6debf5c25] - src: prefer 3-argument Array::New() (Anna Henningsen) #31775
  • [98640f7a6d] - src: use hex not decimal in IsArrayIndex (Shelley Vohr) #31758
  • [75971009d0] - src: wrap HostPort in ExclusiveAccess (Ben Noordhuis) #31717
  • [01da65644e] - src: add ExclusiveAccess class (Ben Noordhuis) #31717
  • [28289eaeb8] - src: allow to reuse env options handling (Denys Otrishko) #31711
  • [249a0fe61d] - src: fix compile warnings in node_url.cc (Anna Henningsen) #31689
  • [bf729d02b7] - src: modernized unique_ptr construction (Yuhanun Citgez) #31654
  • [6e3e158f51] - src: remove dead code in InternalMakeCallback (Gerhard Stoebich) #31622
  • [c34672a3b0] - src: remove fixed-size GetHumanReadableProcessName (Ben Noordhuis) #31633
  • [57d1d73b47] - src: fix OOB reads in process.title getter (Ben Noordhuis) #31633
  • [5e68a13d53] - src: various minor improvements to node_url (James M Snell) #31651
  • [2cdd57ab67] - src: fix inspecting MessagePort from init async hook (Anna Henningsen) #31600
  • [753db6aee2] - src: remove unused Worker::child\_port\_ member (Anna Henningsen) #31599
  • [7e52e39385] - src: change Fill() to use ParseArrayIndex() (ConorDavenport) #31591
  • [79a6872809] - src: remove duplicate field env in CryptoJob class (ConorDavenport) #31554
  • [5e19c4a9d4] - src: fix console debug output on Windows (Denys Otrishko) #31580
  • [9c9dc4b184] - src: remove preview for heap dump utilities (Anna Henningsen) #31570
  • [91dd1018ac] - src: fix debug crash handling null strings (Rusty Conover) #31523
  • [fb32043e6a] - src: define noreturn attribute for windows (Alexander Smarus) #31467
  • [ce6b9d15d2] - src: reduce code duplication in BootstrapNode (Denys Otrishko) #31465
  • [a309af0f52] - src: use custom fprintf alike to write errors to stderr (Anna Henningsen) #31446
  • [7bdd29fa21] - src: add C++-style sprintf utility (Anna Henningsen) #31446
  • [8f88d62a31] - src: reduce large pages code duplication (Gabriel Schulhof) #31385
  • [de6d5523a1] - src: fix ignore GCC -Wcast-function-type for older compilers (Denys Otrishko) #31524
  • [a8d9c0f8b6] - src: ignore GCC -Wcast-function-type for v8.h (Daniel Bevenius) #31475
  • [a2f1825cb5] - src: fix performance regression in node_file.cc (Ben Noordhuis) #31343
  • [1d075cfd7f] - src: use uv_guess_handle() to detect TTYs (Colin Ihrig) #31333
  • [21bcc96f92] - src: include uv.h in node_binding header (Shelley Vohr) #31265
  • [d77a1b088f] - src: remove node::InitializeV8Platform() (Ben Noordhuis) #31245
  • [fe1ac496f7] - src: remove uses of node::InitializeV8Platform() (Ben Noordhuis) #31245
  • [8aa7bf2d23] - src: clean up large_pages code (Denys Otrishko) #31196
  • [12253f8c74] - stream: sync stream unpipe resume (Robert Nagy) #31191
  • [6e76752a7b] - stream: simplify push (Robert Nagy) #31150
  • [8973209ad0] - stream: clean up definition using defineProperties (antsmartian) #31236
  • [a987972bde] - stream: replace Function.prototype with primordial (Sebastien Ahkrin) #31204
  • [e685f12ee6] - test: restore --jitless test on AIX (Richard Lau) #32619
  • [eee587b847] - test: fix test-http2-reset-flood flakiness (Anna Henningsen) #32607
  • [d568efcd22] - test: refactor common.expectsError (Ruben Bridgewater) #31092
  • [e4f9360287] - test: mark test-http2-reset-flood flaky on bsd (Myles Borins) #32595
  • [6f50b60018] - test: add test-worker-prof to the SLOW list for debug (Myles Borins) #32589
  • [7123c0f042] - test: always skip vm-timeout-escape-queuemicrotask (Denys Otrishko) #31980
  • [bb947ce3c2] - test: improve test-debug-usage (Rich Trott) #32141
  • [7c8a7b4c7d] - test: end tls connection with some data (Sam Roberts) #32328
  • [f4bd01c816] - test: discard data received by client (Hassaan Pasha) #32328
  • [7a14ddf104] - test: increase test timeout to prevent flakiness (Ruben Bridgewater) #31716
  • [147045716b] - test: use index.js if package.json "main" is empty (Ben Noordhuis) #32040
  • [03aa2e1b7b] - test: changed function to arrow function (ProdipRoy89) #32045
  • [b4c407fecc] - test: allow EAI_FAIL in test-net-dns-error.js (Vita Batrla) #31780
  • [2582083f63] - test: remove superfluous checks in test-net-reconnect-error (Rich Trott) #32120
  • [f365e5c262] - test: apply camelCase in test-net-reconnect-error (Rich Trott) #32120
  • [256bc4412c] - test: update tests for larger Buffers (Jakob Kummerow) #32114
  • [96c7226897] - test: remove common.port from test-tls-securepair-client (Rich Trott) #32024
  • [1318662ff7] - test: add WASI test for path_link() (Colin Ihrig) #32132
  • [55214628af] - test: move test-inspector-module to parallel (Rich Trott) #32025
  • [3574116887] - test: fix flaky test-dns-any.js (Rich Trott) #32017
  • [d62538404e] - test: fix flaky test-gc-net-timeout (Robert Nagy) #31918
  • [2bf9a2d84c] - test: change test to not be sensitive to buffer send size (Rusty Conover) #31499
  • [b1cf56f5db] - test: remove sequential/test-https-keep-alive-large-write.js (Rusty Conover) #31499
  • [67c3a95f7d] - test: validate common property usage (Denys Otrishko) #31933
  • [26d9f4c160] - test: fix usage of invalid common properties (Denys Otrishko) #31933
  • [086e14d251] - test: increase timeout in vm-timeout-escape-queuemicrotask (Denys Otrishko) #31966
  • [c2ffef8678] - test: add documentation for common.enoughTestCpu (Rich Trott) #31931
  • [0c6fdfc4ac] - test: fix typo in common/index.js (Rich Trott) #31931
  • [3deee057b3] - test: remove common.PORT from assorted pummel tests (Rich Trott) #31897
  • [bde5a9bda8] - test: remove flaky designation for test-net-connect-options-port (Rich Trott) #31841
  • [c386f7568c] - test: remove common.PORT from test-net-write-callbacks.js (Rich Trott) #31839
  • [709256346c] - test: remove common.PORT from test-net-pause (Rich Trott) #31749
  • [61de609ac8] - test: remove common.PORT from test-tls-server-large-request (Rich Trott) #31749
  • [33d3cccb98] - test: remove common.PORT from test-net-throttle (Rich Trott) #31749
  • [d172cc1474] - test: remove common.PORT from test-net-timeout (Rich Trott) #31749
  • [1109124313] - test: add known issue test for sync writable callback (James M Snell) #31756
  • [aa5afd013b] - test: mark test-fs-stat-bigint flaky on FreeBSD (Rich Trott) #31728
  • [3f43c5f508] - test: improve test-fs-stat-bigint (Rich Trott) #31726
  • [3f6805f0e7] - test: remove flaky designation for test-fs-stat-bigint (Rich Trott) #30437
  • [7d71465194] - test: fix flaky test-fs-stat-bigint (Duncan Healy) #30437
  • [ca6fce0cbb] - test: add debugging output to test-net-listen-after-destroy-stdin (Rich Trott) #31698
  • [59eba1177b] - test: improve assertion message in test-dns-any (Rich Trott) #31697
  • [61e534baa0] - test: stricter assert color test (Ruben Bridgewater) #31429
  • [bdd1133451] - test: fix test-benchmark-http (Rich Trott) #31686
  • [795a21d53a] - test: fix flaky test-inspector-connect-main-thread (Anna Henningsen) #31637
  • [297fb67304] - test: add test-dns-promises-lookupService (Rich Trott) #31640
  • [02c2396976] - test: fix flaky test-http2-stream-destroy-event-order (Anna Henningsen) #31610
  • [d2fbe80a4a] - test: unset NODE_OPTIONS for cctest (Anna Henningsen) #31594
  • [944f1a345a] - test: simplify test-https-simple.js (Sam Roberts) #31584
  • [0eb2dbb24e] - test: mark additional tests as flaky on Windows (Anna Henningsen) #31606
  • [0bc3bd7c11] - test: remove --experimental-worker flag comment (Harshitha KP) #31563
  • [baa14c9e39] - test: make test-http2-buffersize more correct (Anna Henningsen) #31502
  • [e3e056d5cd] - test: fix test-heapdump-worker (Anna Henningsen) #31494
  • [48f4212286] - test: add tests for main() argument handling (Colin Ihrig) #31426
  • [dbe2d85f66] - test: add wasi test for freopen() (Colin Ihrig) #31432
  • [a8e2f405f2] - test: remove bluebird remnants from test fixture (Rich Trott) #31435
  • [8438d1498d] - test: improve wasi stat test (Colin Ihrig) #31413
  • [596920dbf4] - test: add wasi test for symlink() and readlink() (Colin Ihrig) #31403
  • [2750e65f5c] - test: update postmortem test with v12 constants (Matheus Marchini) #31391
  • [642f8c0eb9] - test: export public symbols in addons tests (Ben Noordhuis) #28717
  • [20167fec5f] - test: stricten readline keypress failure test condition (Ruben Bridgewater) #31300
  • [c719f7ab36] - test: allow disabling crypto tests (Shelley Vohr) #31268
  • [31a13dc3a4] - test: fix recursive rm test to actually use tmpdir (Denys Otrishko) #31250
  • [320ac13452] - test: remove unused symlink loop (Colin Ihrig) #31267
  • [f3af68ea80] - test: prefer server over srv (Andrew Hughes) #31224
  • [04e2f41783] - test: fix unit test logging with python3 (Adam Majer) #31156
  • [5a537babe1] - test: mark empty udp tests flaky on OS X (Sam Roberts) #32146
  • [99cfab2594] - test,dns: add coverage for dns exception (Rich Trott) #31678
  • [54395c60eb] - tls: reduce memory copying and number of BIO buffer allocations (Rusty Conover) #31499
  • [4f177c4f63] - tls: simplify errors using ThrowCryptoError (Tobias Nießen) #31436
  • [c0e6e60cb1] - tools: update [email protected] (Rich Trott) #32274
  • [dca3d298dd] - tools: update icu to 65.1 (Albert Wang) #30232
  • [d57719098c] - tools: only fetch previous versions when necessary (Richard Lau) #32518
  • [61d54e7716] - tools: use per-process native Debug() printer in mkcodecache (Joyee Cheung) #31884
  • [1060a2bba9] - tools: add NODE_TEST_NO_INTERNET to the doc builder (Joyee Cheung) #31849
  • [aa8a435e17] - tools: sync gyp code base with node-gyp repo (Michaël Zasso) #30563
  • [6b1a5518e0] - tools: update lint-md task to lint for possessives of Node.js (Rich Trott) #31862
  • [b657df4759] - tools: update Markdown linter to be cross-platform (Derek Lewis) #31239
  • [289f3dc538] - tools: replace deprecated iteritems() for items() (Giovanny Andres Gongora Granada (Gioyik)) #31528
  • [77e6700b03] - tools: remove obsolete dependencies (Rich Trott) #31359
  • [c7b1f1df3b] - tools: update remark-preset-lint-node to 1.12.0 (Rich Trott) #31359
  • [20f857fa01] - tools: update JSON header parsing for backticks (Rich Trott) #31294
  • [0f4a9e26ef] - tools: ensure consistent perms of signed release files (Rod Vagg) #29350
  • [6f71efa0ed] - tools: add clang-tidy rule in src (gengjiawen) #26840
  • [3a1566a267] - tools: unify make-v8.sh for ppc64le and s390x (Richard Lau) #31628
  • [fbc0bd95ec] - tty: do not end in an infinite warning recursion (Ruben Bridgewater) #31429
  • [32c0449141] - (SEMVER-MINOR) util: use a global symbol for util.promisify.custom (ExE Boss) #31672
  • [f4e5404b5d] - util: throw if unreachable TypedArray checking code is reached (Rich Trott) #31737
  • [785417aeda] - util: add coverage for util.inspect.colors alias setter (Rich Trott) #31743
  • [c9fa2d1fbf] - util: throw if unreachable code is reached (Rich Trott) #31712
  • [51d8fbf31f] - util: fix inspection of typed arrays with unusual length (Ruben Bridgewater) #31458
  • [f068788f59] - util: add colors to debuglog() (Ruben Bridgewater) #30930
  • [a91a824108] - wasi: improve use of primordials (Colin Ihrig) #31212
  • [2029c10196] - win: change to use Python in install tool (gengjiawen) #31221
  • [c5de212039] - worker: move JoinThread() back into exit callback (Anna Henningsen) #31468
  • [65729f966e] - worker: emit runtime error on loop creation failure (Harshitha KP) #31621
  • [ea989e160e] - worker: unroll file extension regexp (Anna Henningsen) #31779
  • [9f8d315a09] - worker: add support for .cjs extension (Antoine du HAMEL) #31662
  • [30dbc84642] - worker: properly handle env and NODE_OPTIONS in workers (Denys Otrishko) #31711
  • [0697f65f70] - worker: reset Isolate stack limit after entering Locker (Anna Henningsen) #31593
  • [5500521804] - worker: remove redundant closing of child port (aaccttrr) #31555

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations. meta Issues and PRs related to the general management of the project. tools Issues and PRs related to the tools directory. v12.x labels Mar 17, 2020
@codebytere
Copy link
Member Author

Note that there are 2-3 manual backports needing rebase that i'll try to get in here as well.

@mmarchini
Copy link
Contributor

Can #32053 be included as well? It fixes a steep performance regression (and potentially straight up undefined behavior) on V8.

@codebytere codebytere force-pushed the v12.16.2-proposal branch 2 times, most recently from 932a3e1 to 37306be Compare March 17, 2020 15:56
@nodejs-github-bot
Copy link
Collaborator

@nodejs nodejs deleted a comment from nodejs-github-bot Mar 17, 2020
@haggholm
Copy link

Please, please, please include/backport 625d8f7007 (fixes #31752). It’s a hard crash of the whole Node process and makes dynamic worker pools unusable for us with the current LTS/12.

@ex1st
Copy link

ex1st commented Mar 19, 2020

Hello, do you planning to include #31433? Thank you.

@nodejs-github-bot
Copy link
Collaborator

@nodejs nodejs deleted a comment from nodejs-github-bot Mar 23, 2020
@nodejs-github-bot
Copy link
Collaborator

@MylesBorins
Copy link
Contributor

given that #32328 hasn't landed yet and we will likely want to include it in this release should we consider delaying by a week?

@nodejs-github-bot
Copy link
Collaborator

@codebytere
Copy link
Member Author

The ASAN build seems to be failing but that was itself added in this release so i'm not sure if it's something worth blocking on.

@richardlau
Copy link
Member

The ASAN build seems to be failing but that was itself added in this release so i'm not sure if it's something worth blocking on.

@codebytere we've reverted it in master (#32324) as it seems too demanding for the current GitHub Actions runners.

@codebytere
Copy link
Member Author

@richardlau ah ok i'll back it out today then!

@addaleax
Copy link
Member

@codebytere Can you remove #31201 from this PR? #32553 was just reported as a bug that was most likely introduced by it.

addaleax and others added 3 commits March 30, 2020 10:59
Add a raw `MessagePort` benchmark that does not ping back and forth
between different threads, unlike the `echo.js` benchmark, as there
are some performance differences between single-threaded and multi-
threaded operation, and a single-threaded Environment can be somewhat
easier to work with when profiling.

PR-URL: #31568
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Denys Otrishko <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Change the description of socket.setNoDelay() to make it clear
that sockets have Nagle's algorithm enabled by default.

Better document the tradeoff of having the algorithm enabled.

Explain the behavior of the function based on the passed arguments.

PR-URL: #31541
Reviewed-By: Denys Otrishko <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
PR-URL: #31575
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@nodejs-github-bot
Copy link
Collaborator

@breisig
Copy link

breisig commented Apr 7, 2020

Wasn't this supposed to be released today?

@codebytere
Copy link
Member Author

@breisig that's correct, but we're experiencing failures being tracked here: nodejs/build#2271, and so will likely need to delay by a short time.

@codebytere
Copy link
Member Author

codebytere commented Apr 8, 2020

@rvagg still seeing a bunch of failures in the latest above linked RC it seems - on macOS but also on CentOS

In several of them i can see:

Could not find Node.js version in this workspace

which is perhaps a symptom of the issue, but i could be reading the console output incorrectly 🤔

@rvagg
Copy link
Member

rvagg commented Apr 8, 2020

@codebytere:

21:13:44 Please update REPLACEME in Added: tags in doc/api/*.md (See doc/guides/releases.md)

It's passing on Windows because vcbuild.bat doesn't include this check. All the other platforms are checking your docs. Some doc needs to be updated. Did you use your new release tool for this? It's supposed to be doing this automatically isn't it?

@codebytere
Copy link
Member Author

codebytere commented Apr 8, 2020

@rvagg a bunch of new commits were added after i used it initially (you're correct, it does do this automatically), which is likely how they snuck through. I'll update that, thanks for the catch!

Notable changes:

doc:
  * add ronag to collaborators (Robert Nagy) [#31498](#31498)
  * add GeoffreyBooth to collaborators (Geoffrey Booth) [#31306](#31306)
deps:
  * upgrade npm to 6.13.6 (Ruy Adorno) [#31304](#31304)
  * update openssl to 1.1.1e (Hassaan Pasha) [#32328](#32328)
@nodejs nodejs deleted a comment from nodejs-github-bot Apr 8, 2020
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Apr 8, 2020

@nodejs-github-bot
Copy link
Collaborator

@codebytere codebytere merged commit 3443e3a into v12.x Apr 8, 2020
codebytere added a commit that referenced this pull request Apr 8, 2020
@targos
Copy link
Member

targos commented Apr 8, 2020

@codebytere are you having issues with the final steps of the release?

codebytere added a commit to nodejs/nodejs.org that referenced this pull request Apr 8, 2020
codebytere added a commit to nodejs/nodejs.org that referenced this pull request Apr 8, 2020
@rvagg
Copy link
Member

rvagg commented Apr 9, 2020

@codebytere would you mind updating the release blog post with the macos notice please (included in the 13.x previously and the 10.x today):

macOS package notarization and a change in builder configuration

The macOS binaries for this release, and future 12.x releases, are now being compiled on macOS 10.15 (Catalina) with Xcode 11 to support package notarization, a requirement for installing .pkg files on macOS 10.15 and later. Previous builds of Node.js 12.x were compiled on macOS 10.11 (El Capitan) with a minimum deployment target of macOS 10.10 (Yosemite). As binaries are still being compiled to support a minimum of macOS 10.10 (Yosemite) we do not anticipate this having a negative impact on Node.js 12.x users with older versions of macOS.

@rvagg rvagg deleted the v12.16.2-proposal branch April 9, 2020 06:56
@targos targos added release Issues and PRs related to Node.js releases. and removed build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations. meta Issues and PRs related to the general management of the project. tools Issues and PRs related to the tools directory. labels Jun 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release Issues and PRs related to Node.js releases.
Projects
None yet
Development

Successfully merging this pull request may close these issues.