tools: unify make-v8.sh for ppc64le and s390x #31628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
tools
|
V8-CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/2844/ |
richardlau
added
ppc
addaleax
approved these changes
Feb 4, 2020
sam-github
approved these changes
Feb 5, 2020
richardlau
added
author ready
Refactor `tools/make-v8.sh` to minimise differences between the `ppc64le` and `s390x` paths to allow us to enable `ccache` on the `ppc64le` machines in the CI. PR-URL: nodejs#31628 Refs: nodejs/build#1927 Refs: nodejs/build#1940 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Sam Roberts <[email protected]>
|
Landed in d213f21. |
@nodejs/releasers Any objections to me cherry-picking the commit across to the staging branches? |
codebytere
pushed a commit
that referenced
this pull request
Feb 17, 2020
Refactor `tools/make-v8.sh` to minimise differences between the `ppc64le` and `s390x` paths to allow us to enable `ccache` on the `ppc64le` machines in the CI. PR-URL: #31628 Refs: nodejs/build#1927 Refs: nodejs/build#1940 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Sam Roberts <[email protected]>
Merged
BethGriggs
pushed a commit
that referenced
this pull request
Feb 26, 2020
Refactor `tools/make-v8.sh` to minimise differences between the `ppc64le` and `s390x` paths to allow us to enable `ccache` on the `ppc64le` machines in the CI. PR-URL: #31628 Refs: nodejs/build#1927 Refs: nodejs/build#1940 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Sam Roberts <[email protected]>
|
@richardlau, the commit is now on v13.x and v12.x-staging, but it didn't land cleanly on v10.x. I'll add the backport-requested label for now. |
|
@BethGriggs d213f21 lands cleanly on |
BethGriggs
pushed a commit
that referenced
this pull request
Mar 2, 2020
Refactor `tools/make-v8.sh` to minimise differences between the `ppc64le` and `s390x` paths to allow us to enable `ccache` on the `ppc64le` machines in the CI. PR-URL: #31628 Refs: nodejs/build#1927 Refs: nodejs/build#1940 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Sam Roberts <[email protected]>
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor
tools/make-v8.shto minimise differences between theppc64leands390xpaths to allow us to enableccacheon theppc64lemachines in the CI.This needs to land in all supported release lines tested on before
we can reenable ccache on the
centos7-ppclemachines (i.e.reland nodejs/build#1927 which was backed out because the
divergent
ppc64leands390xpaths through this scriptbroke
node-test-commit-v8-linux(nodejs/build#1940)).Refs: nodejs/build#1927
Refs: nodejs/build#1940
cc @nodejs/platform-ppc @nodejs/platform-s390
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes