Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stream: simplify Readable.push #31150

Closed
wants to merge 2 commits into from
Closed

stream: simplify Readable.push #31150

wants to merge 2 commits into from

Conversation

ronag
Copy link
Member

@ronag ronag commented Jan 1, 2020 •
edited
Loading

Slightly simplifies Readable.push.

Note, a lot easier to review if ignoring whitespace.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the stream Issues and PRs related to the stream subsystem. label Jan 1, 2020
BridgeAR
BridgeAR approved these changes Jan 1, 2020
View reviewed changes
Copy link
Member

@BridgeAR BridgeAR left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a green CI

lib/_stream_readable.js Outdated Show resolved Hide resolved
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 2, 2020
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/28094/

@ronag ronag changed the title stream: simplify push stream: simplify Readable.push Jan 2, 2020
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jan 3, 2020 •
edited by Trott
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/28133/ ✅

Trott
Trott approved these changes Jan 3, 2020
View reviewed changes
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but would feel a whole lot better with some @nodejs/streams reviews. I'll also kick off a CITGM out of extra caution.

@Trott
Copy link
Member

Trott commented Jan 3, 2020

CITGM: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/2184/

@Trott

This comment has been minimized.

Sign in to view
@Trott
Copy link
Member

Trott commented Jan 4, 2020

And CITGM against this PR again: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/2186/

@Trott
Copy link
Member

Trott commented Jan 4, 2020

CITGM looks good.

BridgeAR pushed a commit that referenced this pull request Jan 13, 2020
@ronag @BridgeAR
stream: simplify push
94549be 
PR-URL: #31150
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
@BridgeAR
Copy link
Member

Landed in 94549be 🎉

@BridgeAR BridgeAR closed this Jan 13, 2020
MylesBorins pushed a commit that referenced this pull request Jan 16, 2020
@ronag @MylesBorins
stream: simplify push
d04118f 
PR-URL: #31150
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
@codebytere codebytere mentioned this pull request Jan 16, 2020
Merged
codebytere pushed a commit that referenced this pull request Mar 14, 2020
@ronag @codebytere
stream: simplify push
476e919 
PR-URL: #31150
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
codebytere pushed a commit that referenced this pull request Mar 17, 2020
@ronag @codebytere
stream: simplify push
6e76752 
PR-URL: #31150
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
@codebytere codebytere mentioned this pull request Mar 17, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BridgeAR BridgeAR BridgeAR approved these changes

@addaleax addaleax addaleax approved these changes

@Trott Trott Trott approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. stream Issues and PRs related to the stream subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ronag @nodejs-github-bot @Trott @BridgeAR @addaleax