fixup: typeof before instanceof

nodejs · Jan 1, 2020 · c0112cf · c0112cf
1 parent 55dbada
commit c0112cf
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/lib/_stream_readable.js b/lib/_stream_readable.js
@@ -277,9 +277,7 @@ function readableAddChunk(stream, chunk, encoding, addToFront) {
 
   let err;
   if (!state.objectMode) {
-    if (chunk instanceof Buffer) {
-      encoding = '';
-    } else if (typeof chunk === 'string') {
+    if (typeof chunk === 'string') {
       encoding = encoding || state.defaultEncoding;
       if (addToFront && state.encoding && state.encoding !== encoding) {
         // When unshifting, if state.encoding is set, we have to save
@@ -289,6 +287,8 @@ function readableAddChunk(stream, chunk, encoding, addToFront) {
         chunk = Buffer.from(chunk, encoding);
         encoding = '';
       }
+    } else if (chunk instanceof Buffer) {
+      encoding = '';
     } else if (Stream._isUint8Array(chunk)) {
       chunk = Stream._uint8ArrayToBuffer(chunk);
       encoding = '';