Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: update [email protected] #32274

Closed
wants to merge 0 commits into from
Closed

tools: update [email protected] #32274

wants to merge 0 commits into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Mar 14, 2020

Update minimist used by lint-md.js to 1.2.5.

Refs: https://app.snyk.io/vuln/SNYK-JS-MINIMIST-559764

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Mar 14, 2020
@Trott Trott force-pushed the update-minimist branch from eaf6c4b to cf28449 Compare March 14, 2020 23:36
@Trott
Copy link
Member Author

Trott commented Mar 14, 2020

Collaborators, 👍 here to approve fast-tracking.

@Trott Trott added the fast-track PRs that do not need to wait for 48 hours to land. label Mar 14, 2020
@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 15, 2020
@Trott Trott mentioned this pull request Mar 15, 2020
Closed
tniessen
tniessen reviewed Mar 16, 2020
View reviewed changes
tools/lint-md.js Outdated
if (next === '-') {
setArg(letters[j], next, arg);
continue;
}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume that these style issues are external?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. Rollup leaves the spaces, but git or GitHub removes them again, I think. This seems to happen every time we update lint-md.js.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’m pretty sure it’s git node land that does that by passing --whitespace=fix to git am.

Trott added a commit to Trott/io.js that referenced this pull request Mar 17, 2020
@Trott
tools: update [email protected]
40b559a 
Update minimist used by lint-md.js to 1.2.5.

Refs: https://app.snyk.io/vuln/SNYK-JS-MINIMIST-559764
Signed-off-by: Rich Trott <[email protected]>

PR-URL: nodejs#32274
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@Trott Trott closed this Mar 17, 2020
@Trott Trott force-pushed the update-minimist branch from cf28449 to 40b559a Compare March 17, 2020 02:02
@Trott
Copy link
Member Author

Trott commented Mar 17, 2020

Landed in 40b559a

@Trott Trott deleted the update-minimist branch March 17, 2020 02:02
MylesBorins pushed a commit that referenced this pull request Mar 19, 2020
@Trott @MylesBorins
tools: update [email protected]
1e58c8b 
Update minimist used by lint-md.js to 1.2.5.

Refs: https://app.snyk.io/vuln/SNYK-JS-MINIMIST-559764
Signed-off-by: Rich Trott <[email protected]>

PR-URL: #32274
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Mar 19, 2020
Merged
MylesBorins pushed a commit that referenced this pull request Mar 24, 2020
@Trott @MylesBorins
tools: update [email protected]
5adaf10 
Update minimist used by lint-md.js to 1.2.5.

Refs: https://app.snyk.io/vuln/SNYK-JS-MINIMIST-559764
Signed-off-by: Rich Trott <[email protected]>

PR-URL: #32274
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit to MylesBorins/node that referenced this pull request Apr 2, 2020
@Trott @MylesBorins
tools: update [email protected]
c0e6e60 
Update minimist used by lint-md.js to 1.2.5.

Refs: https://app.snyk.io/vuln/SNYK-JS-MINIMIST-559764
Signed-off-by: Rich Trott <[email protected]>

PR-URL: nodejs#32274
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@codebytere codebytere mentioned this pull request Apr 3, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tniessen tniessen tniessen approved these changes

@addaleax addaleax addaleax left review comments

@targos targos targos approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Trott @jasnell @addaleax @targos @tniessen @nodejs-github-bot