Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix flaky test-dns-any.js #32017

Merged
merged 1 commit into from
Mar 2, 2020
Merged

test: fix flaky test-dns-any.js #32017

merged 1 commit into from
Mar 2, 2020

Conversation

Trott
Copy link
Member

@Trott Trott commented Feb 29, 2020

Remove google.com from domains tested with ANY queries.

Fixes: #31721

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Feb 29, 2020
@Trott
Copy link
Member Author

Trott commented Feb 29, 2020 •
edited
Loading

Custom internet CI: https://ci.nodejs.org/job/node-test-commit-custom-suites-freestyle/12505/ ✅

@Trott
Copy link
Member Author

Trott commented Feb 29, 2020

Custom internet CI against master to make sure this test is still failing there without this change: https://ci.nodejs.org/job/node-test-commit-custom-suites-freestyle/12506/

@Trott
Copy link
Member Author

Trott commented Feb 29, 2020

Custom internet CI against master to make sure this test is still failing there without this change: https://ci.nodejs.org/job/node-test-commit-custom-suites-freestyle/12506/

That one had the test here passing, but it was on a different host than the recent failures. Here's a run that (like the one that passed with the changes in this PR) is on the host that has been failing this test recently: https://ci.nodejs.org/job/node-test-commit-custom-suites-freestyle/12507/

@Trott
Copy link
Member Author

Trott commented Feb 29, 2020

That one had the test here passing, but it was on a different host than the recent failures. Here's a run that (like the one that passed with the changes in this PR) is on the host that has been failing this test recently: https://ci.nodejs.org/job/node-test-commit-custom-suites-freestyle/12507/

And that one failed! So it looks like this makes the test pass. Fast-track, anyone? Please 👍 here. This will unbreak nightly CI.

@Trott Trott added dns Issues and PRs related to the dns subsystem. flaky-test Issues and PRs related to the tests with unstable failures on the CI. fast-track PRs that do not need to wait for 48 hours to land. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Feb 29, 2020
@Trott
test: fix flaky test-dns-any.js
fb74e98 
Remove google.com from domains tested with ANY queries.

Fixes: nodejs#31721

PR-URL: nodejs#32017
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@Trott
Copy link
Member Author

Trott commented Mar 2, 2020

Landed in fb74e98

@Trott Trott merged commit fb74e98 into nodejs:master Mar 2, 2020
@Trott Trott deleted the fix-dns branch March 2, 2020 15:03
@codebytere codebytere mentioned this pull request Mar 3, 2020
Merged
codebytere pushed a commit that referenced this pull request Mar 3, 2020
@Trott @codebytere
test: fix flaky test-dns-any.js
49864d1 
Remove google.com from domains tested with ANY queries.

Fixes: #31721

PR-URL: #32017
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
codebytere pushed a commit that referenced this pull request Mar 15, 2020
@Trott @codebytere
test: fix flaky test-dns-any.js
563a21a 
Remove google.com from domains tested with ANY queries.

Fixes: #31721

PR-URL: #32017
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
codebytere pushed a commit that referenced this pull request Mar 17, 2020
@Trott @codebytere
test: fix flaky test-dns-any.js
2d3926c 
Remove google.com from domains tested with ANY queries.

Fixes: #31721

PR-URL: #32017
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@codebytere codebytere mentioned this pull request Mar 17, 2020
Merged
codebytere pushed a commit that referenced this pull request Mar 30, 2020
@Trott @codebytere
test: fix flaky test-dns-any.js
3574116 
Remove google.com from domains tested with ANY queries.

Fixes: #31721

PR-URL: #32017
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tniessen tniessen tniessen approved these changes

@lpinca lpinca lpinca approved these changes

@addaleax addaleax addaleax approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. dns Issues and PRs related to the dns subsystem. fast-track PRs that do not need to wait for 48 hours to land. flaky-test Issues and PRs related to the tests with unstable failures on the CI. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

investigate unreliability in test-dns-any
5 participants
@Trott @addaleax @lpinca @tniessen @nodejs-github-bot