cli: --perf-prof only works on Linux

PR-URL: #31892 Reviewed-By: Matheus Marchini <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>
nodejs · Mar 30, 2020 · 70dc1ce · 70dc1ce
1 parent 3deee05
commit 70dc1ce
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 6 deletions.
diff --git a/doc/api/cli.md b/doc/api/cli.md
@@ -1155,6 +1155,9 @@ V8 options that are allowed are:
 * `--stack-trace-limit`
 <!-- node-options-v8 end -->
 
+`--perf-basic-prof-only-functions`, `--perf-basic-prof`,
+`--perf-prof-unwinding-info`, and `--perf-prof` are only available on Linux.
+
 ### `NODE_PATH=path[:…]`
 <!-- YAML
 added: v0.1.32

diff --git a/test/parallel/test-cli-node-options.js b/test/parallel/test-cli-node-options.js
@@ -48,15 +48,14 @@ expectNoWorker('--trace-event-file-pattern {pid}-${rotation}.trace_events ' +
        '--trace-event-categories node.async_hooks', 'B\n');
 expect('--unhandled-rejections=none', 'B\n');
 
-if (!common.isWindows) {
+if (common.isLinux) {
   expect('--perf-basic-prof', 'B\n');
   expect('--perf-basic-prof-only-functions', 'B\n');
-}
 
-if (common.isLinux && ['arm', 'x64'].includes(process.arch)) {
-  // PerfJitLogger is only implemented in Linux.
-  expect('--perf-prof', 'B\n');
-  expect('--perf-prof-unwinding-info', 'B\n');
+  if (['arm', 'x64'].includes(process.arch)) {
+    expect('--perf-prof', 'B\n');
+    expect('--perf-prof-unwinding-info', 'B\n');
+  }
 }
 
 if (common.hasCrypto) {