Add public IP support

[rchenzheng]

• include examples
• dynamic and static address
• update readme

[rchenzheng]

Solves #80

[wkharold]

Please merge, this will allow ephemeral external IPs as well.

[mehdicopter]

When this is going to be merged ?

[bharathkkb]

Thanks for the PR @rchenzheng

• Can we get tests passing for this? You can do make docker_test_lint to see what is failing for the lint check. I see that some docs also need to be regenerated. Please run make build. Additional details here.

• The simple example that was modified is also used in our integration tests here. Since two variables was added to that example (nat_ip and network_tier) we will need to make adequate changes. Can we set some defaults, like null for nat_ip and PREMIUM for network_tier so that the example can get an ephemeral ip by default?

[bharathkkb]

@morgante wanted to confirm that we do want to add support for this in compute_instance module. The solution in #84 only works if the instance_template module is also used in conjunction.

[rchenzheng]

Thanks for the PR @rchenzheng

• Can we get tests passing for this? You can do make docker_test_lint to see what is failing for the lint check. I see that some docs also need to be regenerated. Please run make build. Additional details here.
• The simple example that was modified is also used in our integration tests here. Since two variables was added to that example (nat_ip and network_tier) we will need to make adequate changes. Can we set some defaults, like null for nat_ip and PREMIUM for network_tier so that the example can get an ephemeral ip by default?

It's been quite hectic around here, I'll update the PR shortly

[morgante]

@rchenzheng Can you clarify if your use case is specifically to attach an external IP on the VM when the template doesn't have one? I'm not sure I fully follow the scenario where that's necessary.

[rchenzheng]

@rchenzheng Can you clarify if your use case is specifically to attach an external IP on the VM when the template doesn't have one? I'm not sure I fully follow the scenario where that's necessary.

Yes attaching a static ip as indicated in #80

[morgante]

Got it. Assuming tests pass, LGTM. Thanks!

[morgante]

FYI this is the error in the test logs:

       Error: Error creating instance: googleapi: Error 400: Invalid value for field 'resource.networkInterfaces[0].accessConfigs[0].natIP': 'null'. The specified external IP address 'null' was not found in region 'us-central1'., invalid
       
         on ../../../../modules/compute_instance/main.tf line 41, in resource "google_compute_instance_from_template" "compute_instance":
         41: resource "google_compute_instance_from_template" "compute_instance" {
       
       
       
       Error: Error creating instance: googleapi: Error 400: Invalid value for field 'resource.networkInterfaces[0].accessConfigs[0].natIP': 'null'. The specified external IP address 'null' was not found in region 'us-central1'., invalid
       
         on ../../../../modules/compute_instance/main.tf line 41, in resource "google_compute_instance_from_template" "compute_instance":
         41: resource "google_compute_instance_from_template" "compute_instance" {
       
       
       
       Error: Error creating instance: googleapi: Error 400: Invalid value for field 'resource.networkInterfaces[0].accessConfigs[0].natIP': 'null'. The specified external IP address 'null' was not found in region 'us-central1'., invalid
       
         on ../../../../modules/compute_instance/main.tf line 41, in resource "google_compute_instance_from_template" "compute_instance":
         41: resource "google_compute_instance_from_template" "compute_instance" {
       
       
       
       Error: Error creating instance: googleapi: Error 400: Invalid value for field 'resource.networkInterfaces[0].accessConfigs[0].natIP': 'null'. The specified external IP address 'null' was not found in region 'us-central1'., invalid
       
         on ../../../../modules/compute_instance/main.tf line 41, in resource "google_compute_instance_from_template" "compute_instance":
         41: resource "google_compute_instance_from_template" "compute_instance" {

[rchenzheng]

FYI this is the error in the test logs:

       Error: Error creating instance: googleapi: Error 400: Invalid value for field 'resource.networkInterfaces[0].accessConfigs[0].natIP': 'null'. The specified external IP address 'null' was not found in region 'us-central1'., invalid
       
         on ../../../../modules/compute_instance/main.tf line 41, in resource "google_compute_instance_from_template" "compute_instance":
         41: resource "google_compute_instance_from_template" "compute_instance" {
       
       
       
       Error: Error creating instance: googleapi: Error 400: Invalid value for field 'resource.networkInterfaces[0].accessConfigs[0].natIP': 'null'. The specified external IP address 'null' was not found in region 'us-central1'., invalid
       
         on ../../../../modules/compute_instance/main.tf line 41, in resource "google_compute_instance_from_template" "compute_instance":
         41: resource "google_compute_instance_from_template" "compute_instance" {
       
       
       
       Error: Error creating instance: googleapi: Error 400: Invalid value for field 'resource.networkInterfaces[0].accessConfigs[0].natIP': 'null'. The specified external IP address 'null' was not found in region 'us-central1'., invalid
       
         on ../../../../modules/compute_instance/main.tf line 41, in resource "google_compute_instance_from_template" "compute_instance":
         41: resource "google_compute_instance_from_template" "compute_instance" {
       
       
       
       Error: Error creating instance: googleapi: Error 400: Invalid value for field 'resource.networkInterfaces[0].accessConfigs[0].natIP': 'null'. The specified external IP address 'null' was not found in region 'us-central1'., invalid
       
         on ../../../../modules/compute_instance/main.tf line 41, in resource "google_compute_instance_from_template" "compute_instance":
         41: resource "google_compute_instance_from_template" "compute_instance" {

It's been fixed, thanks