DEVOPS-1842 Merge master into branch "instance-template/disk-variables" for TF v0.13 support #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…module (terraform-google-modules#81) BREAKING CHANGE: The preemptible_and_regular_instance_templates modules have had name_prefixes renamed, forcing instances to be recreated.
* updated CHANGELOG.md [ci skip] * updated README.md Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
* Added: stateful configuration * Added: var udpate * Added: var udpate * Updated: stateful_disk variable, autogen docs
…terraform-google-modules#96) BREAKING CHANGE: instance_redistribution_type must now be specified for update policies.
…orm-google-modules#112) * Update README.md * Update README.md
…#111) BREAKING CHANGE: var.access_config has been changed to a 2D array, with a separate element for each VM.
…-modules/release-v5.0.0 chore: release 5.0.0
* add instance_group_manager output needed to create a stateful MIG in conjunction with https://www.terraform.io/docs/providers/google/r/compute_region_per_instance_config.html * fix: autogen/outputs.tf.tmpl use {{ module_name }} in instance_group_manager output Co-authored-by: Morgante Pell <[email protected]>
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
…y load balancer resources outside this module (terraform-google-modules#119) * feat: adds an output for the health check self_links to be consumed by load balancer resources outside this module * chore: docs generation * moved change up to autogen * aligning CI and makefile image for docs generation
…-modules#128) BREAKING CHANGE: Minimum Terraform version increased to 0.13.
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
rchenzheng
reviewed
Feb 24, 2021
| @@ -15,5 +15,5 @@ | |||
| */ | |||
|
|
|||
| terraform { | |||
| required_version = "~> 0.12.6" | |||
| required_version = ">=0.12.6" | |||
There was a problem hiding this comment.
How come are tests still in 0.12.6? Is this what's in upstream?
There was a problem hiding this comment.
Yes this is what we have in the master branch. It was changed to support 0.12.6 or higher.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are using
instance-template/disk-variablesbranch when declaring TF source forinstance-template/betworks-postgresql/terragrunt.hcl. That branch is tagged to use TF v0.12.6.Requesting merge master branch into
instance-template/disk-variablesfor terraform v0.13 support.This branch was created by Rinaldi to support extra variables for our environment.