Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: relax version constraints to enable terraform 0.13.x compatibility #108

Merged
merged 2 commits into from
Aug 26, 2020
Merged

fix: relax version constraints to enable terraform 0.13.x compatibility #108

merged 2 commits into from
Aug 26, 2020

Conversation

brandonjbjelland
Copy link
Contributor

What is this change?

This change relaxes terraform version requirements, enabling terraform 0.13.x to use this module again.

Why make this change?

This is a stopgap change intended to bridge the transition between terraform 0.12.x and 0.13.y.

Potential gotcha

I haven't tested all the submodules and one difference I've seen between 0.12 and 0.13 are the values of depends_on blocks which now drop the third field - the resource attribute. Specifically, mig_with_percent has a depends_on meta-arg in the old style (docs link on the new style). I'm not entirely sure that the old form is incompatible (encountered an error of this flavor when using the 0.13 RC builds) nor I have I tested/spent enough time in the upgrade trenches to know for sure. Let me know if you have any insight here. Let's see how CI does. 🤞

@brandonjbjelland
Copy link
Contributor Author

Closes #107

bharathkkb
bharathkkb previously approved these changes Aug 25, 2020
View reviewed changes
Copy link
Member

@bharathkkb bharathkkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

test/setup/main.tf Outdated Show resolved Hide resolved
@bharathkkb bharathkkb mentioned this pull request Aug 25, 2020
Closed
@brandonjbjelland brandonjbjelland force-pushed the fix/enable-tf013-compatiblity branch from ef6608a to 80fd5d0 Compare August 25, 2020 17:56
@brandonjbjelland
Copy link
Contributor Author

Unsure how to manage the stuck triggers here. LMK if you need anything further from me on this PR @bharathkkb . If this looks good, I'll likely hit a few more modules with the same changeset.

@morgante morgante merged commit 6fb2b42 into terraform-google-modules:master Aug 26, 2020
@brandonjbjelland brandonjbjelland deleted the fix/enable-tf013-compatiblity branch August 26, 2020 08:09
This was referenced Aug 28, 2020
Merged
Merged
@oshaughnessy
Copy link

Just curious -- how soon until there's a new release cut with this in it? Thanks!

@oshaughnessy
Copy link

Just checking in -- still eagerly awaiting a new release so we can upgrade our own code to Terraform 0.13.

Thank you :-)

raolivei added a commit to scoremedia/terraform-google-vm that referenced this pull request Feb 25, 2021
@raolivei @GeneralAardvark
@fclerg @rchenzheng @release-please @elauqsap @morgante @konstantin-recurly @seanson @brandonjbjelland @dshah22 @marine675 @UrosSimovic @adrian-gierakowski @xSAVIKx @bharathkkb @cloud-foundation-bot
DEVOPS-1842 Merge master into branch "instance-template/disk-variable…
04f7441 
…s" for TF v0.13 support (#2)

* fix: Correct names for instances in preemptible and regular instance module (terraform-google-modules#81)

BREAKING CHANGE: The preemptible_and_regular_instance_templates modules have had name_prefixes renamed, forcing instances to be recreated.

* chore: fixing typo in instance_template README (terraform-google-modules#86)

* feat: Add support for assigning public IPs directly to instances. (terraform-google-modules#83)

* chore: release 3.0.0 (terraform-google-modules#82)

* updated CHANGELOG.md [ci skip]

* updated README.md

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

* fix terraform-google-modules#88 issues with autogen tmpl for mig (terraform-google-modules#93)

* chore: fix format

* feat: Add stateful disk support (terraform-google-modules#90)

* Added: stateful configuration

* Added: var udpate

* Added: var udpate

* Updated: stateful_disk variable, autogen docs

* feat: Add wait_for_instances and configurable timeout support for mig (terraform-google-modules#96)

BREAKING CHANGE: instance_redistribution_type must now be specified for update policies.

* chore: release 4.0.0 (terraform-google-modules#98)

* fix: relax version constraints to enable terraform 0.13.x compatibility (terraform-google-modules#108)

* chore: Updating Links in README (terraform-google-modules#97) (terraform-google-modules#112)

* Update README.md

* Update README.md

* fix: Terraform version upgrade for compute_instance module from 0.12.6 to 0.12.7 (terraform-google-modules#103)

* fix(UMIG): access_config should be 2D array (terraform-google-modules#111)

BREAKING CHANGE: var.access_config has been changed to a 2D array, with a separate element for each VM.

* chore: release 5.0.0

* feat: Added instance_group_manager output (terraform-google-modules#105)

* add instance_group_manager output

needed to create a stateful MIG in conjunction with https://www.terraform.io/docs/providers/google/r/compute_region_per_instance_config.html

* fix: autogen/outputs.tf.tmpl use {{ module_name }} in instance_group_manager output

Co-authored-by: Morgante Pell <[email protected]>

* chore: release 5.1.0 (terraform-google-modules#115)

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

* feat: adds an output for the health check self_links to be consumed by load balancer resources outside this module (terraform-google-modules#119)

* feat: adds an output for the health check self_links to be consumed by load balancer resources outside this module

* chore: docs generation

* moved change up to autogen

* aligning CI and makefile image for docs generation

* feat!: Update default source image and family to latest CentOS 7 (terraform-google-modules#126)

* feat: add TF 0.13 constraint and module attribution (terraform-google-modules#128)

BREAKING CHANGE: Minimum Terraform version increased to 0.13.

* chore: Remove < 0.14 constraints in examples/fixtures [bot-pr] (terraform-google-modules#129)

* chore: release 6.0.0 (terraform-google-modules#127)

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

Co-authored-by: GeneralAardvark <[email protected]>
Co-authored-by: fclerg <[email protected]>
Co-authored-by: Richard Chen Zheng <[email protected]>
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Co-authored-by: Pasquale D'Agostino <[email protected]>
Co-authored-by: Morgante Pell <[email protected]>
Co-authored-by: Konstantin Kirpichnikov <[email protected]>
Co-authored-by: Sean Johnson <[email protected]>
Co-authored-by: Brandon J. Bjelland <[email protected]>
Co-authored-by: Darpan Shah <[email protected]>
Co-authored-by: Aaron Yang <[email protected]>
Co-authored-by: Uroš <[email protected]>
Co-authored-by: Ryan Canty <[email protected]>
Co-authored-by: Adrian <[email protected]>
Co-authored-by: Brandon J. Bjelland <[email protected]>
Co-authored-by: Yurii Serhiichuk <[email protected]>
Co-authored-by: Bharath KKB <[email protected]>
Co-authored-by: cloud-foundation-bot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bharathkkb bharathkkb bharathkkb left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@brandonjbjelland @oshaughnessy @bharathkkb @morgante