fix(UMIG): access_config should be 2D array

[UrosSimovic]

Problem:

Currently it is not possible to have multiple instances with predefined access configs (external ips). If one would want to create 3 instances with 3 external ips, each instance would get same 3 predefined external ips. Which is not possible.

Solution:

Make access_config 2D array, so each instance would get an array of predefined ips.

[bharathkkb]

Looks like our integration tests are failing here. In particular, this example when we default access_config to []. Perhaps we can have a check to make sure we only access var.access_config[count.index] if length(var.access_config) > 0? This however would mean if num_instances or static_ips > 1 and we want access_config for only one instance, we will need to provide empty lists like

[[{
  // when static_ips=4
    nat_ip       = google_compute_address.ip_address.address
    network_tier = "PREMIUM"
  }],[],[],[]]

[UrosSimovic]

I think this will solve the issue. And also one wouldn't need to provide a list as yours, but just a list with first element.

dynamic "access_config" {
  # convert to map to use lookup function with default value
  for_each = lookup({for k, v in var.access_config: k => v}, count.index, [])
  content {
    nat_ip       = access_config.value.nat_ip
    network_tier = access_config.value.network_tier
  }
}

Lookup with a default value works just with maps and didn't find anything similar for lists.

[morgante]

@UrosSimovic Please regenerate docs.

[UrosSimovic]

@UrosSimovic Please regenerate docs.

Nothing changes:

$ make generate_docs
docker run --rm -it \
	-v "/home/uros/tmp/terraform-google-vm":/workspace \
	gcr.io/cloud-foundation-cicd/cft/developer-tools:0 \
	/bin/bash -c 'source /usr/local/bin/task_helper_functions.sh && generate_docs'
Generating markdown docs with terraform-docs
Working in ./examples/compute_instance/simple ...
2020/09/15 11:54:37 At 24:21: Unknown token: 24:21 IDENT var.region
Warning! Exit code: 1
Working in ./examples/instance_template/additional_disks ...
2020/09/15 11:54:37 At 19:13: Unknown token: 19:13 IDENT var.project_id
Warning! Exit code: 1
Working in ./examples/instance_template/simple ...
2020/09/15 11:54:37 At 19:13: Unknown token: 19:13 IDENT var.project_id
Warning! Exit code: 1
Working in ./examples/mig/autoscaler ...
2020/09/15 11:54:37 At 19:13: Unknown token: 19:13 IDENT var.project_id
Warning! Exit code: 1
Skipping ./examples/mig/full because README.md does not exist.
Working in ./examples/mig/simple ...
2020/09/15 11:54:37 At 19:13: Unknown token: 19:13 IDENT var.region
Warning! Exit code: 1
Working in ./examples/mig_with_percent/simple ...
2020/09/15 11:54:37 At 19:13: Unknown token: 19:13 IDENT var.project_id
Warning! Exit code: 1
Working in ./examples/preemptible_and_regular_instance_templates/simple ...
2020/09/15 11:54:37 At 19:13: Unknown token: 19:13 IDENT var.project_id
Warning! Exit code: 1
Skipping ./examples/umig/full because README.md does not exist.
Working in ./examples/umig/named_ports ...
2020/09/15 11:54:37 At 19:13: Unknown token: 19:13 IDENT var.project_id
Warning! Exit code: 1
Working in ./examples/umig/simple ...
2020/09/15 11:54:37 At 19:13: Unknown token: 19:13 IDENT var.project_id
Warning! Exit code: 1
Working in ./examples/umig/static_ips ...
2020/09/15 11:54:37 At 19:13: Unknown token: 19:13 IDENT var.project_id
Warning! Exit code: 1
Working in ./modules/compute_instance ...
2020/09/15 11:54:37 At 18:19: Unknown token: 18:19 IDENT var.hostname
Warning! Exit code: 1
Working in ./modules/instance_template ...
2020/09/15 11:54:37 At 21:13: Unknown token: 21:13 IDENT var.source_image
Warning! Exit code: 1
Working in ./modules/mig ...
2020/09/15 11:54:37 At 20:18: Unknown token: 20:18 IDENT concat
Warning! Exit code: 1
Working in ./modules/mig_with_percent ...
2020/09/15 11:54:37 At 20:18: Unknown token: 20:18 IDENT concat
Warning! Exit code: 1
Working in ./modules/preemptible_and_regular_instance_templates ...
2020/09/15 11:54:38 At 24:26: Unknown token: 24:26 IDENT var.project_id
Warning! Exit code: 1
Working in ./modules/umig ...
2020/09/15 11:54:38 At 18:19: Unknown token: 18:19 IDENT var.hostname
Warning! Exit code: 1
Skipping ./test/fixtures/compute_instance/simple because README.md does not exist.
Skipping ./test/fixtures/instance_template/additional_disks because README.md does not exist.
Skipping ./test/fixtures/instance_template/simple because README.md does not exist.
Skipping ./test/fixtures/mig/autoscaler because README.md does not exist.
Skipping ./test/fixtures/mig/simple because README.md does not exist.
Skipping ./test/fixtures/mig_with_percent/simple because README.md does not exist.
Skipping ./test/fixtures/preemptible_and_regular_instance_templates/simple because README.md does not exist.
Skipping ./test/fixtures/umig/named_ports because README.md does not exist.
Skipping ./test/fixtures/umig/simple because README.md does not exist.
Skipping ./test/fixtures/umig/static_ips because README.md does not exist.
Skipping ./test/setup because README.md does not exist.