Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

In "mig_with_percent" module, add variable "project" in "google_compute_zones" data source #88

Closed
shraddhajain01 opened this issue May 13, 2020 · 1 comment
Closed

In "mig_with_percent" module, add variable "project" in "google_compute_zones" data source #88

shraddhajain01 opened this issue May 13, 2020 · 1 comment
Labels
good first issue Good for newcomers P3 medium priority issues triaged Scoped and ready for work

Comments

@shraddhajain01
Copy link

The data source:

data "google_compute_zones" "available" {
  region = var.region
}

should be:

data "google_compute_zones" "available" {
  region  = var.region
  project = var.project_id
}

Since it should derive the project ID from other resources and not provider.
Somewhat similar to #60
@bharathkkb
Copy link
Member

Seems like a reasonable change, happy to review a PR.

@bharathkkb bharathkkb added good first issue Good for newcomers P3 medium priority issues triaged Scoped and ready for work labels May 14, 2020
@shraddhajain01 shraddhajain01 mentioned this issue May 15, 2020
Closed
raolivei added a commit to scoremedia/terraform-google-vm that referenced this issue Feb 25, 2021
@raolivei @GeneralAardvark
@fclerg @rchenzheng @release-please @elauqsap @morgante @konstantin-recurly @seanson @brandonjbjelland @dshah22 @marine675 @UrosSimovic @adrian-gierakowski @xSAVIKx @bharathkkb @cloud-foundation-bot
DEVOPS-1842 Merge master into branch "instance-template/disk-variable…
04f7441 
…s" for TF v0.13 support (#2)

* fix: Correct names for instances in preemptible and regular instance module (terraform-google-modules#81)

BREAKING CHANGE: The preemptible_and_regular_instance_templates modules have had name_prefixes renamed, forcing instances to be recreated.

* chore: fixing typo in instance_template README (terraform-google-modules#86)

* feat: Add support for assigning public IPs directly to instances. (terraform-google-modules#83)

* chore: release 3.0.0 (terraform-google-modules#82)

* updated CHANGELOG.md [ci skip]

* updated README.md

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

* fix terraform-google-modules#88 issues with autogen tmpl for mig (terraform-google-modules#93)

* chore: fix format

* feat: Add stateful disk support (terraform-google-modules#90)

* Added: stateful configuration

* Added: var udpate

* Added: var udpate

* Updated: stateful_disk variable, autogen docs

* feat: Add wait_for_instances and configurable timeout support for mig (terraform-google-modules#96)

BREAKING CHANGE: instance_redistribution_type must now be specified for update policies.

* chore: release 4.0.0 (terraform-google-modules#98)

* fix: relax version constraints to enable terraform 0.13.x compatibility (terraform-google-modules#108)

* chore: Updating Links in README (terraform-google-modules#97) (terraform-google-modules#112)

* Update README.md

* Update README.md

* fix: Terraform version upgrade for compute_instance module from 0.12.6 to 0.12.7 (terraform-google-modules#103)

* fix(UMIG): access_config should be 2D array (terraform-google-modules#111)

BREAKING CHANGE: var.access_config has been changed to a 2D array, with a separate element for each VM.

* chore: release 5.0.0

* feat: Added instance_group_manager output (terraform-google-modules#105)

* add instance_group_manager output

needed to create a stateful MIG in conjunction with https://www.terraform.io/docs/providers/google/r/compute_region_per_instance_config.html

* fix: autogen/outputs.tf.tmpl use {{ module_name }} in instance_group_manager output

Co-authored-by: Morgante Pell <[email protected]>

* chore: release 5.1.0 (terraform-google-modules#115)

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

* feat: adds an output for the health check self_links to be consumed by load balancer resources outside this module (terraform-google-modules#119)

* feat: adds an output for the health check self_links to be consumed by load balancer resources outside this module

* chore: docs generation

* moved change up to autogen

* aligning CI and makefile image for docs generation

* feat!: Update default source image and family to latest CentOS 7 (terraform-google-modules#126)

* feat: add TF 0.13 constraint and module attribution (terraform-google-modules#128)

BREAKING CHANGE: Minimum Terraform version increased to 0.13.

* chore: Remove < 0.14 constraints in examples/fixtures [bot-pr] (terraform-google-modules#129)

* chore: release 6.0.0 (terraform-google-modules#127)

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

Co-authored-by: GeneralAardvark <[email protected]>
Co-authored-by: fclerg <[email protected]>
Co-authored-by: Richard Chen Zheng <[email protected]>
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Co-authored-by: Pasquale D'Agostino <[email protected]>
Co-authored-by: Morgante Pell <[email protected]>
Co-authored-by: Konstantin Kirpichnikov <[email protected]>
Co-authored-by: Sean Johnson <[email protected]>
Co-authored-by: Brandon J. Bjelland <[email protected]>
Co-authored-by: Darpan Shah <[email protected]>
Co-authored-by: Aaron Yang <[email protected]>
Co-authored-by: Uroš <[email protected]>
Co-authored-by: Ryan Canty <[email protected]>
Co-authored-by: Adrian <[email protected]>
Co-authored-by: Brandon J. Bjelland <[email protected]>
Co-authored-by: Yurii Serhiichuk <[email protected]>
Co-authored-by: Bharath KKB <[email protected]>
Co-authored-by: cloud-foundation-bot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers P3 medium priority issues triaged Scoped and ready for work
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added project attribute in google_compute_zones data source shraddhajain01/terraform-google-vm
2 participants
@bharathkkb @shraddhajain01