Fedekunze/1010 lcd stake #1068
Merged
Fedekunze/1010 lcd stake #1068
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 2, 2018 11:37
…kunze/1010-lcd-stake pull
fedekunze
added
DO NOT MERGE
blocked ✋
|
We use the prefix "WIP" for our PRs that are not ready to merge. Changed it for you. |
faboweb
reviewed
Aug 2, 2018
| // }, | ||
|
|
||
| // Get a list containing all the validator candidates | ||
| getValidators: req("GET", "/stakes/validators/"), |
There was a problem hiding this comment.
typo "stakes" instead of "stake"
There was a problem hiding this comment.
for some reason my ESlint wasn't working. I had to delete it and reinstall
added 14 commits
August 2, 2018 14:31
Codecov Report
@@ Coverage Diff @@
## develop #1068 +/- ##
===========================================
- Coverage 97.18% 96.05% -1.14%
===========================================
Files 79 81 +2
Lines 1525 1595 +70
Branches 77 79 +2
===========================================
+ Hits 1482 1532 +50
- Misses 36 56 +20
Partials 7 7
|
|
blocked on cosmos/cosmos-sdk#1949 |
|
Reviewed and approved by @fedekunze |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Updates LCD endpoints for staking.
DO NOT MERGE until #cosmos-sdk/1880 has been merged !
❤️ Thank you!